mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Meelis Roos <mroos@linux.ee>
To: Jean Delvare <khali@linux-fr.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Dean Nelson <dnelson@redhat.com>,
	Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: f71805f arch dependencies?
Date: Sat, 2 Jun 2012 09:27:51 +0300 (EEST)	[thread overview]
Message-ID: <alpine.SOC.1.00.1206020925060.2992@math.ut.ee> (raw)
In-Reply-To: <20120601220315.246ba5a5@endymion.delvare>

> > >> > Loading f71805f on sparc64 causes hard reboot beacuse on invalid
> > >> > hardware access. Should this driver be restricted to PC, or some wider
> > >> > subset of platforms where this LPC SUper-IO chip is present?
> > >>
> > >> Which tree is f71805f in? Not in Linus'.
> > >
> > > Running upstream 3.4.0-09547-gfb21aff and it is there as
> > > SENSORS_F71805F.
> > >
> > > In fact, there are more LPC hwmon drivers that people can use to "shoot
> > > themselves in the leg" - SMSC LPC*, SMSC SCH*, SMSC DME1737 (partly I2C,
> > > partly ISA IO), and Fintek F71882FG and compatibles. Maybe more.
> > 
> > Sorry, I thought it was a git SHA1 commit ID.
> > Didn't know hardware manufacturers christen their chips to the abbreviated
> > commit ID in their VHDL repository ;-)
> > 
> > Indeed, it seems commit 746cdfbf01c0a30d59f6e1b6942d432658d7c7cd
> > ("hwmon: Avoid building drivers for powerpc that read/write ISA addresses")
> > was a bit too limited...
> 
> I am fine extending that commit to other architectures. Now the
> question is, do we just add SPARC64 to the exception list, or do we
> restrict these drivers to X86? I know they are mostly used on X86, but
> I have no proof they aren't used on other architectures. That's why
> Dean and myself decided to play it safe at first and only exclude PPC.
> 
> Apparently other drivers (e.g. watchdog drivers) for similar chips are
> limited to X86 so we might as well do the same here. And see if anybody
> complains...
> 
> Meelis, do you feel like sending a patch, or do you prefer if I take
> care of it?

I can send a patch in a couple of days, but I do not know either wihich 
way is better.

What other architectures can use the ISA-IO style LPC - probably quite 
several if hardware has been made (but it probably hasn't)?

-- 
Meelis Roos (mroos@ut.ee)      http://www.cs.ut.ee/~mroos/

  reply	other threads:[~2012-06-02  6:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-01 13:01 Meelis Roos
2012-06-01 13:09 ` Geert Uytterhoeven
2012-06-01 13:12   ` Meelis Roos
2012-06-01 13:23     ` Geert Uytterhoeven
2012-06-01 19:43       ` Dean Nelson
2012-06-01 20:03       ` Jean Delvare
2012-06-02  6:27         ` Meelis Roos [this message]
2012-06-02  6:54           ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.SOC.1.00.1206020925060.2992@math.ut.ee \
    --to=mroos@linux.ee \
    --cc=dnelson@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®