From: Meelis Roos <mroos@linux.ee>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Russell King <linux@arm.linux.org.uk>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Scott Wood <scottwood@freescale.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Linux Kernel list <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH v2] OF: base: match each node compatible against all given matches first
Date: Wed, 4 Dec 2013 15:08:39 +0200 (EET) [thread overview]
Message-ID: <alpine.SOC.1.00.1312041506010.8902@math.ut.ee> (raw)
In-Reply-To: <20131204094010.GO19943@ulmo.nvidia.com>
> I added Meelis on Cc because he found a regression with my original
> proposal (107a84e61cdd "of: match by compatible property first"). That
> got later reverted in commit bc51b0c22ceb (Revert "of: match by
> compatible property first"). Here's the commit message for reference:
>
> commit bc51b0c22ceb
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date: Tue Jul 10 12:49:32 2012 -0700
>
> Revert "of: match by compatible property first"
>
> This reverts commit 107a84e61cdd3406c842a0e4be7efffd3a05dba6.
>
> Meelis Roos reports a regression since 3.5-rc5 that stops Sun Fire V100
> and Sun Netra X1 sparc64 machines from booting, hanging after enabling
> serial console. He bisected it to commit 107a84e61cdd.
>
> Rob Herring explains:
> "The problem is match combinations of compatible plus name and/or type
> fail to match correctly. I have a fix for this, but given how late it
> is for 3.5 I think it is best to revert this for now. There could be
> other cases that rely on the current although wrong behavior. I will
> post an updated version for 3.6."
>
> Bisected-and-reported-by: Meelis Roos <mroos@linux.ee>
> Requested-by: Rob Herring <rob.herring@calxeda.com>
> Cc: Thierry Reding <thierry.reding@avionic-design.de>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>
> So if Meelis still has access to the Sun Fire V100 and Sun Netra X1
> machines that regressed last time around, it'd be great to get this
> patch tested on them to verify that it indeed fixes the problem and
> doesn't regress.
OK, I had forgotten about that.
Tested successfully on the same Sun Fire V100 and Sun Netra X1, on top
of 3.13-rc2. The sunsu console is detected fine and I see no problem for
now.
--
Meelis Roos (mroos@linux.ee)
next prev parent reply other threads:[~2013-12-04 13:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 18:36 [PATCH] " Sebastian Hesselbarth
2013-12-02 12:03 ` Thierry Reding
2013-12-02 14:00 ` Rob Herring
2013-12-02 14:09 ` Sebastian Hesselbarth
2013-12-03 13:52 ` [PATCH v2] " Sebastian Hesselbarth
2013-12-03 20:14 ` Meelis Roos
2013-12-03 22:55 ` Sebastian Hesselbarth
2013-12-04 9:40 ` Thierry Reding
2013-12-04 13:08 ` Meelis Roos [this message]
2013-12-04 14:04 ` Thierry Reding
2013-12-04 19:23 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.SOC.1.00.1312041506010.8902@math.ut.ee \
--to=mroos@linux.ee \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mkl@pengutronix.de \
--cc=rob.herring@calxeda.com \
--cc=scottwood@freescale.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome