From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E7ED377A9D for ; Sat, 18 Jul 2026 21:57:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784411866; cv=none; b=ZfCSM0Hv/37yaZRH0EhTW7IM6xl85CuEyxr6WW2adWpTC/Aq1nHCWLFNrjhYuVkXGPSpNTiCsCDNo0wqAx7t0t6B8+WnrWd5/QOaKRNkL54aXRJW9qD4V400Rs97uCNV6IT+6qwEGL2FIGljKwR+5BzawVmT/WfHKYYWQVHWP40= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784411866; c=relaxed/simple; bh=wa93jje6EgHUk7Zt2ECfepwMi/iCuz+0PNAnYeWTQUc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Hb7NWPddDY4Ipqpl3CMxz3hj2BjDUPcF7CuHHp8sPVuUI48NVgCIGBuoISlfC+cBdA10Meq8LdUI1ZLhSSGKMxPEhkmTu7zrj3y65oAUSyjCGevcoLJ6p5oSBJsz9nFlbpPsF52jDq2GGbW9k/FuEBQ0r49BCqH+s7fhXI2Ifrs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=TlVkOKo9; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="TlVkOKo9" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-475417f010dso4903193f8f.2 for ; Sat, 18 Jul 2026 14:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1784411862; x=1785016662; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=wa93jje6EgHUk7Zt2ECfepwMi/iCuz+0PNAnYeWTQUc=; b=TlVkOKo9vf0EXi5ST7U97oZ/YE9QOwu/dXAcpCa4x1RwzD4nl9rVJSJcCqWgSkVFrl JPXL2aSk/AIxBjERmihCj7mP2ielysI6OdvdN5X/QH03LeKOPrCQxFtQBhaoDDI9qdbe eT9Aoa9x/Tz7cPcd29PPh/B+UPvWadMqYPjOtbGyVHW5Oas+HekerYK8peiXGfqIyRak 5kQogHvp5tLZDzHLdbmR70pElL+7KsObKtjXMPfBNHpGXOgCFPo8fOum+JQ5yMiogE/Z aYQx2OzM3VxJmlcV384exK02GTApIYSt7J+zTekblkNAr2JV2DHyw06rxI6Ws/DPIbrI Dg/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784411862; x=1785016662; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wa93jje6EgHUk7Zt2ECfepwMi/iCuz+0PNAnYeWTQUc=; b=MQ8OJ9GNX64YfMUQC57zCqPi5abFMIBvF7vBmHQcLxgVO1KIMZCfqj/hhJs3aLuMgR bse3Yxq8+DlhPUJpK0TdV1iuztTdotharY/yIhelnjxRlZORzAEP/fcGDMUEmLbvTQ3X ME7XC3bb3xEecTz4kkUVycibPw/lJa3a0t1bCVG7aDeQ8DuNU37QWtUlJ+CopWTqFtPa s9aUTbdnfvaSDWVUZac/9OTdBfx9lVAw2mAEPlpjanGFwOs/i+EsZT/pycmY6H98/277 uh1sbydCj83fdtNqsA0nhulceyPrYFpgPwoQ3ClHtSv5WJB/DeLOEpCerLw8UspXMVmF keJQ== X-Forwarded-Encrypted: i=1; AHgh+RrldUzwYsKYxr57a/D61GqOqFY5PfIPVY3hQXvaRAk9Vlkara1h4AFECfpXV4ZodIFTZG4SsbiATDCXjyA=@vger.kernel.org X-Gm-Message-State: AOJu0YwU95pkHaiyowP1+WTSfofmpvpFAatTmo9L2cp8XdgzsTvdLgob woYIXfv9smcC8oraqPZYwT/lvG/JDEza1W5HO8InqLkBd07H419poQzVCsZXdBRHTtk= X-Gm-Gg: AfdE7clORLv2EQGraAdiWK5r3OCT5iSqtLjUYMpGIWTUFKqIs93BZeE+1wA1iCKG7pg w7Tyv05x2hfZdy33WWLgfSBvJd5uVIZxd0RJr0FmeqIMKZFkKDzd2CXfvvfCs8qn1xtIIEp1Jq8 SqMHW4/BWVv3g1UFghExfiiWQ4jz3HCNZW2FeNiwzX4FQCMng8tE4mpuHkICukHbFBRGpOPGlxP zmbQTa0LNPIabz59S85i/GG3mJ6AFJi9fWe0hQ3g7eSn7kHhrnN/4ifHgqMV21YifbJVeU/9ikD NLS73hxEgQyB5VJWFUIM1dVb6iA6+2HEXJmsCEscCplNwOK2irhfCkLT+OaEvQcnaBuX2XieA8H pYcU/Mv3JrlXa5cGrVe4/7tvp7eAYVn1dN81bb998NfXM8t32r+Ck8TGx7t/l4UeT/+rkCoCqJ/ JH+oS6PqPNzmYlazAvGA== X-Received: by 2002:a05:6000:1844:b0:47f:4e42:669 with SMTP id ffacd0b85a97d-47f623169eemr9423338f8f.22.1784411862534; Sat, 18 Jul 2026 14:57:42 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47f63edcd13sm15085022f8f.26.2026.07.18.14.57.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 14:57:41 -0700 (PDT) Date: Sat, 18 Jul 2026 23:57:40 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Florian Fuchs Cc: Helge Deller , John Paul Adrian Glaubitz , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH] fbdev: pvr2fb: correct user pointer annotation and sentinel initializer Message-ID: References: <20260713101638.600333-1-fuchsfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kf7otoxip247seh3" Content-Disposition: inline In-Reply-To: <20260713101638.600333-1-fuchsfl@gmail.com> --kf7otoxip247seh3 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH] fbdev: pvr2fb: correct user pointer annotation and sentinel initializer MIME-Version: 1.0 On Mon, Jul 13, 2026 at 12:16:38PM +0200, Florian Fuchs wrote: > Add __user annotation to buf, as it is passed as a user pointer in > pin_user_pages_fast(). Use an empty initializer for the sentinel > board-table entry to avoid initializing a function pointer with an > integer literal. FTR: Using 0 in an initializer is covered by the C standard. Anyhow, I agree that { } is nicer. Having said that, I think the right thing to do here is to drop the sentinel entry, because board_driver[] is only used in for loops that iterate between 0 (inclusive) and ARRAY_SIZE(board_driver) (exclusive). Also I would split this patch in two. Best regards Uwe --kf7otoxip247seh3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpb9tIACgkQj4D7WH0S /k6qngf9HPcjOLFf9ebMiIVzfNiUMnp3nKAf85kikPbocb6uZIoVWVmOOAbdaj/C Tt7C7ycDzH1+PbhZFJ+1x3bKOQdYwHpeejamFt/nD2ZAeBxz+9n3ffyHgl2A1mtz NG5iP2KvP12HrLUBl77GyHrNRc8lSNQPDjNoig1hoD/BXQovkL+vHqmarxeGO0b1 8mM+IEnlVfafEVlywlgSPst6xDnp75HoXQeBxEn0URZosnkm5V6qQklbEpIYXc3E MN5ANqf3R7WzP2B2QTJl/fmW5c3QwxhwBUrNHp4GPC3MQI6o5zYgfQ6Ma9RGsTEv j32/Xe/K4MPfVPlfaJrPyCX4JjJmtg== =FAiA -----END PGP SIGNATURE----- --kf7otoxip247seh3--