mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Feng Tang <feng.tang@linux.alibaba.com>
To: Sudeep Holla <sudeep.holla@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	rafael@kernel.org, Danilo Krummrich <dakr@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	David Hildenbrand <david@kernel.org>,
	linux-kernel@vger.kernel.org, driver-core@lists.linux.dev
Subject: Re: [PATCH v2] arch_topology: Introduce nr_possible_packages
Date: Wed, 22 Jul 2026 14:50:48 +0800	[thread overview]
Message-ID: <amBoSHYWpt2jbjGr@U-2FWC9VHC-2323.local> (raw)
In-Reply-To: <20260721-armored-lion-of-pluck-9fc8a0@sudeepholla>

On Tue, Jul 21, 2026 at 03:32:03PM +0100, Sudeep Holla wrote:
> On Tue, Jul 14, 2026 at 01:43:17PM +0800, Feng Tang wrote:
> > For multi-sockets platforms kernel or driver code may need the number
> > of packages to chose different code directions. Some architecture
> > already provides such kind of interface like x86, which is being used
> > in its architecture code and drivers.
> > 
> > Add similar interface 'nr_possible_packages' for platforms which can
> > get package topology information by parsing ACPI tables in boot phase,
> > which was verified to show the correct number of packages on some
> > 1-socket and 2-sockets production arm64 servers from different vendors.
> > 
> > It has been used locally by some arm64 PMU driver, and cross-socket
> > timer-consistency check code, which are to be posted.
> > 
> > Signed-off-by: Feng Tang <feng.tang@linux.alibaba.com>
> > ---
> >   since v1:
> >       * fix the potential overflow issue for 32b package ID (Sudeep)
> > 	  * add real use case in commit log (Sudeep)
> > 
> >   since RFC:
> >       * use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL (Greg)
> 
> This is undone in this version, why ?
> 
> > 	  * change the possible max package ID to 2047 (Greg)
> > 	  * remove the CONFIG_ARM64/RISCV limit for 'nr_possible_packages' (Greg)
> 
> Again this is still there, misleading or v2 is back to RFC, /me confused.

Thanks for the review!

My fault! that I messed up with the locally saved RFC and V1 patch. I was
focusing on fixing the problems you mentioned.

> > 
> >   v1:  https://lore.kernel.org/lkml/20260515144435.93035-1-feng.tang@linux.alibaba.com/ 
> 
> Comments about users is still ignored.

I described the user case in commit log of this version. It was
locally used by several drivers and other code, maybe I should
repost it together with those code.

btw, is there any problem with the new package accounting code?  

Thanks,
Feng

> -- 
> Regards,
> Sudeep
> 
> P.S.: Please avoid personal pings as it will not gain attention from other
> interested parties.

  reply	other threads:[~2026-07-22  6:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14  5:43 Feng Tang
2026-07-21 14:32 ` Sudeep Holla
2026-07-22  6:50   ` Feng Tang [this message]
2026-07-22  8:38     ` Sudeep Holla
2026-07-22  8:41 ` Sudeep Holla
2026-07-23  8:27   ` Feng Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amBoSHYWpt2jbjGr@U-2FWC9VHC-2323.local \
    --to=feng.tang@linux.alibaba.com \
    --cc=catalin.marinas@arm.com \
    --cc=dakr@kernel.org \
    --cc=david@kernel.org \
    --cc=driver-core@lists.linux.dev \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=sudeep.holla@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®