From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F146B2D47F4 for ; Wed, 22 Jul 2026 09:21:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784712071; cv=none; b=H4QQgLSQTWnTiTWwbLOLUVSjiavXyCTpQpx2eVsv4zave3fOpKattOYSrNk+o5DaVmZfTPGYugCtHvwqNG4pVOBcQrEUmBzNmPtmmkoy3cjwXdk4ixmMat/xChWoxaR2clgL+MepVKkoiTjbbPmuPJt8+qCX+BHhcuB9EhSnc6w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784712071; c=relaxed/simple; bh=32rOwesH+gwjrg9sBYG4YxAQXufT8hneixwX2YjRdDA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XNCNpNxFpnp3PZWKaViEM8iOn93dO4QHTY/qoQT4XeaMxzAJJSkP5jRX1W14a0e9t1AYf6X/JDRQ8LJX5iPrLDskbegn9Uc2HiIqCU6At6VDEr084AwI02RKPHUj8aRBEla9w5UcB8Aqb0Mk4cZe2tRtFFfX5T3IDiXUakwZWiA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RDBIRUjO; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RDBIRUjO" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-5b015b2d792so13899701e87.3 for ; Wed, 22 Jul 2026 02:21:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784712068; x=1785316868; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=TzPYGGCsB/JnvYbiM7iDCIZYRT+Lm8x4cI/RrcLbCt0=; b=RDBIRUjO+FMmOIG0vm4tX/IBUNBSoy+iV2kRUFXTaWwR1RZxhTaRFq/ZG6ntknm78Z vBAOXmyTfpoCiS1O8sQeicv9TAnos7JbeNMjgYpa1Qw6GHmXxSFRgpAyciPVm97axY7w mID9M11jP1W8xMTbSymWoJLf++qfskLh2BG7EwVOlTLIE9p2ogOci+Deso01cyDN7iJj bCrI5pJoU+5FD9gDCIWOUciqcO8NJ7+5gfBLJ0SLA2v7iWLkbGEyPLwYq+k44EMNuOEZ U2pCmdTbJgxUGdw/zD5TiKBZYpfUNRLaR8qqcfR6lOP0cevhMM6fD/zj7L4ciIfRgwPV bp4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784712068; x=1785316868; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TzPYGGCsB/JnvYbiM7iDCIZYRT+Lm8x4cI/RrcLbCt0=; b=RPmrfaORJtvqeqFO7DKenn3HcG+h/Vqdf5qGdiHGq4h8bHLjaL74jFwrEdX/gHVhy4 tEKyzQelSt6b/j3h3MK8sLP0u22mjR4Zisq1xZskE9vGZj5MRZhzgEeR4aX1SlvgAcQ7 t6Va/Hm5mZxTHGFlCwJNcVmt884jO4zu+JYo6HBgONAxL2cJi7DkKHxBpRoLGg4uU4OE PkFo5T69u4QPCU3GWQ9nGNIWM6rMtOnjI+y0Yo2HStp5pt+AAQPsjObsa8OuJhgnEVnD WoVXTDE098e+z6FnVxEq/ObqfXlo7qPEWWpNuN6N58R6dDvYWmikHG1kNKfGE0CDq+O6 K31A== X-Forwarded-Encrypted: i=1; AHgh+RpVBkhZuiQj2Gp8J+DLKjLh87OKkOrz4rjDvBDgNYoLJ2gv5wawlfhK/ElTb5rotYFs+Uq0gvfDCKxp8qs=@vger.kernel.org X-Gm-Message-State: AOJu0YwUVJVHeDRcsUv3RvLOMl9O80rIKZ0m5NsQrF1QGwMbX7NcRt3B hv/clnmSsz3t+a2mB0RKhiWxGhi7QSzXrXZZPnHSEOlX8nBrNlyP/L0K X-Gm-Gg: AR+sD12tsdRjFGDYQfBJVzLjhcrLtRYRORgA2USHSjebCWHLlPlCRDyFvFSrDSAvtM1 pcS/WKOoX3MpArSViV2tzGgrR/cVJaoKnBpNn+QitaABCI0Mik7MBHQlDeYJBvWYYEo1RqxlagN BBn/UnoIjJTYPZ5TQLLKFOKMc1pSuOwQG1N9auQkmE1tXMKLkjH3ihntGJRYZlChpZXl3Xo1ED6 AG88Sug2RjZLGrFCoN5NSBwfESJyIKqJM1cd2W191B2qdIVZS/YsypOD/n1awNPHWLHpeKlSthB ct2ak0usezF40mBMSTvrYxv3x3BPlFkfvOwOzqyNQQdq9qz6kdIJ2BER6FSiYdAPWObYQRNgYie gIq1vzgHA2xs7VRHe6NBIYoclgHvRx5BgqgLhHUXrNNqbH7wSXfSApW/9CzOiV6wwbQ7sYUCM1G o6/I6ve2Do5S/FL/j3 X-Received: by 2002:a05:6512:708:b0:5b0:1b0f:7a60 with SMTP id 2adb3069b0e04-5b28f9ba3e3mr2907126e87.32.1784712067687; Wed, 22 Jul 2026 02:21:07 -0700 (PDT) Received: from localhost (soda.int.kasm.eu. [2001:678:a5c:1202:7b92:9ac1:b9ef:5287]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2a9d303dfsm380919e87.47.2026.07.22.02.21.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 02:21:07 -0700 (PDT) Date: Wed, 22 Jul 2026 11:21:06 +0200 From: Klara Modin To: Felix Fietkau Cc: Rosen Penev , linux-wireless@vger.kernel.org, Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , "open list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Subject: Re: [PATCHv2 wireless] wifi: mt76: fix MAC address for non OF pcie cards Message-ID: References: <20260706232857.807044-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 2026-07-22 08:40:56 +0200, Felix Fietkau wrote: > Hi, > > On 21.07.26 22:22, Klara Modin wrote: > > On 2026-07-06 16:28:57 -0700, Rosen Penev wrote: > > > If seems the check for err is wrong as the proper macaddr gets written > > > to from the EEPROM itself. Meaning checking err from of_get_mac_address is > > > wrong as the proper macaddr has been written by this point. > > > > > > Reported-by: Klara Modin > > > Closes: https://lore.kernel.org/all/ajRmlyx_AEGybykL@soda.int.kasm.eu/ > > > Reported-by: Tobias Klausmann > > > Closes: > > > https://lore.kernel.org/linux-wireless/30a90714-02d8-45f2-a7f1-4cfe0627d50b@skade.local/ > > > Fixes: 31ee1582717e ("wifi: mt76: fix of_get_mac_address error handling") > > > Signed-off-by: Rosen Penev > > > Tested-by: Tobias Klausmann > > > Tested-by: Klara Modin > > > --- > > > v2: add extra tags and target wireless > > > drivers/net/wireless/mediatek/mt76/eeprom.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wireless/mediatek/mt76/eeprom.c > > > index b99d7452800f..afdb73661866 100644 > > > --- a/drivers/net/wireless/mediatek/mt76/eeprom.c > > > +++ b/drivers/net/wireless/mediatek/mt76/eeprom.c > > > @@ -181,7 +181,7 @@ mt76_eeprom_override(struct mt76_phy *phy) > > > if (err == -EPROBE_DEFER) > > > return err; > > > - if (err) { > > > + if (!is_valid_ether_addr(phy->macaddr)) { > > > eth_random_addr(phy->macaddr); > > > dev_info(dev->dev, > > > "Invalid MAC address, using random address %pM\n", > > > -- > > > 2.55.0 > > > > > > > Ping. No one seems to have picked this up yet, but I suppose it is > > holiday season. > It's in the mt76-fixes pull request that I just sent. > > - Felix Thanks!