From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D00F339367 for ; Wed, 22 Jul 2026 11:08:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784718535; cv=none; b=CPGOvCqeqYwrw1dax4gasBrwyM/XqOyZiDdlIRZgucAVgOQRMugKzA6YbW0BrWs1tykUdGtF7yZ1bfxLzSEw43nP67kdh0ixhxNOPrYf2DkRz2hZ/qOWjLf+0Z1NNjE+gtwaLHTeZ3PxbpGpuoAEdJLM4MruVFOLryOEz79FRoE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784718535; c=relaxed/simple; bh=dGaK6ahq6YdjKsxo58VyUhgDorerNjunqKzDeEDWtIM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fuVnDQXuwIU8SaMfv05ua/VyULhdTVIwui9E3/7HX6e4uUtk6RR8fXCvuhjdJYe+irry+94WvazNMZO7cO2szA+e9LkKREle8igeudpOIsEilvkPlM4IzUxBYSNt8wQ6GZ0g0+O6bS1SrCN6XZFkYkhsViP/41mZOFYjZtlUeVE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Rc/hP7nz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ThYXRo2b; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Rc/hP7nz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ThYXRo2b" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66M8xCVc401250 for ; Wed, 22 Jul 2026 11:08:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=x3LCiuuukQ+P3+NcqWiQ5cLn eYgsyqSEhRzkWM6AiCo=; b=Rc/hP7nzDHGc8MdN+SYJ6dAvQqF8lozqSu7mf1X4 LXAj8EYfgl6dTDRdfymXRKo23n1WJId7YRvdhUYqrkBkiUtMp3AOQaZWfEbS0pj1 /AvP+NVoxGufMDPQv7oTSrpmPkC42ASJDJDOmQuHF0sh2jEbkeAuahCHLwbVw+vo fiXDZlo41bH1DYSzCrOnxo+jNpeochzcBYe2COKm2PW5DLJWUFw3UA31US887LRd 0i3W/C89s1r4NQrViMmWyUalPGri+zxOyVBcR9w3HZXASzNL7WUFhPptiNOHQ/r8 4xB72/HZ6OSOaZELd/aARlBUy9O8SVpZLJeLQ4AhVKfWQA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fjt798p05-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Jul 2026 11:08:52 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ce8a76df2dso226201025ad.2 for ; Wed, 22 Jul 2026 04:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784718532; x=1785323332; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=x3LCiuuukQ+P3+NcqWiQ5cLneYgsyqSEhRzkWM6AiCo=; b=ThYXRo2bVqdacdXZm4bm7EAKldn/6e4hrelUWyZz0Cm2WE0B+6Ztd20C4Y6H6XuSf9 xsFGLfACPl6MDfRbGlulZ6FWEsTiFFp8TE4Z7ClXEKrvvwYbZLlFFHNK97ZA6kKDn6/u u9kp5suK8xS2d4KdNyhmy+mH83eiZU0YEms62ZrqAAd5kA/6xVEIVinZ9uzIX2+tRcSK tiAEVuwDtkOJuooX4jDq/4swjq2DIxvrtO+pZhl22IMZGSkEUkfv5LzDjpHCQUV91xX5 WwWbRzlgx6PnAcyIY4qWA/fZgeMzY0kIragjBJnLEBDpn9FVeizzFVe9mtgi6Oji1E4r 27LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784718532; x=1785323332; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=x3LCiuuukQ+P3+NcqWiQ5cLneYgsyqSEhRzkWM6AiCo=; b=PI6cSUMlPuo+HUY/BVrRtvc4MI/sWCbWVXjV2xiqkvkeTz3hoRO6K93Mwa6Y15PgKX HwgIK2qnJUUIBcGhS604mP+HheQ/2ZVCDQ9rcqXu4JpWoEQTfW1QYm08wAK2oWkp3wOh 2f8Q5GoEcss1SKyNX7LZ+NHh0aryv5Jop9f41l9aWVUYtBgo7uN67/xEP+jBAn8w4lPa CKshC6A8CNgyu7AFtDAw9e7rYqe2ar5j5tLa6JUKp7VYGp3sMpDd6a9uqn7vY371tDCK DGnDcwpxG8YxtRvhNSufyenOMzcfuGJJp3IbrVTW7/+3bt9vZQpeUe+ie26UfzEf7g3c +08Q== X-Forwarded-Encrypted: i=1; AHgh+RrPGSXUudfG6pMeJAQe3lAYoi24RWa+omMJ/NJiQYk5447qg1R3Ug2A5hHz9AIiDQ1lHWdZx6rqzhSh1uw=@vger.kernel.org X-Gm-Message-State: AOJu0Yzq75uRgKV5tMpL1Jc/SkddRiQ0I118kIz2tAijYo+3iorJvt8O F2JsJyGJHLeTPJSOoRHBw+p2dtdrJhwiGhrOht6t7BVjDQluwUc4yWEI92ZPVDuiUL/XRzxas+7 PKB5okxa3dgsq1HxDcrvwJZc3ALUfyPhJE75xehsGzt6V6GlzbPnF1UnM70VicBao0UY= X-Gm-Gg: AR+sD13QM3XYk6i2f1i9gMTOwq/sZGVQxKDOe1O1fVjEoOl8TQkOqQiIW0SVUUHaMNC RquTfs1YgObwHiaog7gJx/imYa6zc4xYbB3bjh7HYCCm232lueio0UqfvUG1orryehFr2awxW/P 5o7MrFFVYbgC3a0WNveIafdIUdqUVobhjIePQb8/XFz1HIBVy15IRUAyelQgfSCGRBUKneY8vdz lh9iIM/eFu/AsExOT8G/vUPzbygsOb37HsSXEGC5e5zoq0WNgncX6npLUUbsXwPyCfw1VkgSncY 7t9sFM76mzCfYj1vjjEyH6KcsZAAaMHL+5rRaF+l8f3+U+Emd6mmZWbr4GgjlEMO2/paFovMaw4 musd9l9z9B+VHNHU7Q72g2DSjCA7fjT61+3vvDQ+Ogd4rV6aXEzYAVpovAaW+FX7BiYVsDS/C9M 3y11LFx0NjDraZdddU4jBqze+zDD5WTQ== X-Received: by 2002:a17:903:3bcf:b0:2ca:ed41:d33d with SMTP id d9443c01a7336-2cf34a80342mr261919125ad.45.1784718532015; Wed, 22 Jul 2026 04:08:52 -0700 (PDT) X-Received: by 2002:a17:903:3bcf:b0:2ca:ed41:d33d with SMTP id d9443c01a7336-2cf34a80342mr261918435ad.45.1784718531430; Wed, 22 Jul 2026 04:08:51 -0700 (PDT) Received: from hu-varada-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147dc1a67esm9225691eec.2.2026.07.22.04.08.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 04:08:51 -0700 (PDT) Date: Wed, 22 Jul 2026 16:38:44 +0530 From: Varadarajan Narayanan To: Konrad Dybcio Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: ipq5210: Enable USB and PCIe on RDP504 Message-ID: References: <20260715-08-dts-v2-0-b060b68e0256@oss.qualcomm.com> <20260715-08-dts-v2-2-b060b68e0256@oss.qualcomm.com> <56522c76-389b-486b-ac64-ded7745f512f@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56522c76-389b-486b-ac64-ded7745f512f@oss.qualcomm.com> X-Authority-Analysis: v=2.4 cv=Sr6gLvO0 c=1 sm=1 tr=0 ts=6a60a4c5 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=oMAPo0KStigxr9RxYcgA:9 a=CjuIK1q_8ugA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: 5dujDlmSpfHiVhc8DMMNkZlpc719fnhf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIyMDEwOCBTYWx0ZWRfXxSbiYukcnytI aE3D12s6YBtjP1f9XKNnLnTuWLP7/VBfOtWZRCNg8Fy0etZwGq6ptLG6ADEubLoZYb+TNf06JxM WIR+ghlGdYnASy6QtudCtIdIUQZinW4zx1UcBTgAEV5xyN3jVyC+gb5/eEVWcP2jdrM/JvkDZdy 0PWQlJqwR7w/UlUUYKDSdghyfbgRQY/kp4hkHh0x89713Ss4WWX40yFMWraX6rFhyX3Nhj1R8f8 ET05QTQdivDZ92EITf6woHEpbm143mMXPyBxBxQCAltP8yF2WdS8NiFe5sxSXfCtpUXwyWO+cw0 l5v5ms1cynwLcGH1hQlHyii7dWapt7hDyitzP7wxDOudnoqETvGhrBpcFGT0EeDY0dbQ8dcvCCJ SpFtmBfwdW6hJ2/aVtBka1EqBZPdNHRp/AIwiA8NkLX9rZ8rvUUZahFy9WC8BqQ4DIy4fD1znbv rSdhd0HeFaIv8UcgmCA== X-Proofpoint-GUID: 5dujDlmSpfHiVhc8DMMNkZlpc719fnhf X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIyMDEwOCBTYWx0ZWRfX9MiBRbYCHOST uc7b+2knv3jH6ILayzs8jBCSXu6dk/mD8n8HR78paw2LKHZIhOXlMOLMwVrGuKGmnVOJ7aHtkLB BHZujK9ON6lCH8s5CNGtcQTm2kwSXkY= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-22_03,2026-07-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 clxscore=1015 impostorscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607220108 On Tue, Jul 21, 2026 at 05:36:23PM +0200, Konrad Dybcio wrote: > On 7/15/26 9:11 AM, Varadarajan Narayanan wrote: > > RDP504 has USB, PCIe and SPI NAND devices populated. EMMC and NAND > > share the GPIOs. The board has to be reworked to change from EMMC > > to NAND variant. Hence add the NAND node but do not enable it. > > Does that warrant adding a DT for both variants, both inheriting a > common .dtsi and making the necessary amends? Ok. > > Describe the fixed USB regulators, PCIe reset GPIOs, QPIC SPI NAND flash > > Are they controllable? Are they provided by some PMIC? No. Not provided by PMIC. IPQ5210 doesn't have any software controllable PMIC. > [...] > > > +&pcie0 { > > + pinctrl-0 = <&pcie0_default_state>; > > + pinctrl-names = "default"; > > + status = "okay"; > > Please keep a \n before 'status', uniformly, file-wide Ok. > Also 'pcie0' goes before 'pcie0_foo' Ok. Thanks Varada