From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C8263E1D15 for ; Wed, 22 Jul 2026 11:31:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784719866; cv=none; b=Il3WdqWYFDvA6K8uydq/96J9oY7uozx1OywZqiT9Rs2FfshUc3sE8GJjT7yYgJ0JhSwixuS67cSU4SkhxDnVd2tRTOp3Pe0dnlixZ7VsdPN7O1Y3QnvR7O07UXLJhAi2jaAVIxk1hj+aJMv8xEDBpGmPbN72QDXFtbJrA9SjlN8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784719866; c=relaxed/simple; bh=fmMpHGfZ3piJhS16SuWAmgh3lRyl2EAwX31PgDbmXeg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JDicjqejVI/ujiPb2r63NAndyiDCV6plYdktogxhaFHDltLu1X50oLgt9KM33597nfLxJizOlc3i12HtivbH9doHtNCgOmwVy1iVIHZEJQCkcENBHkuBFxnUMkGjAcEDkMWTIbMq0nMM1xuAMmi3K6bvoF7IjDk0osfwuVwBG54= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WZE6F3/0; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WZE6F3/0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03EB21F000E9; Wed, 22 Jul 2026 11:30:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784719861; bh=+shRNGBj5Owp+uVGh3Xp8g/6GJInc0RvJCbh8LgO5Wo=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=WZE6F3/01WTp/lAinJIxVK6/EsQhlrlX2KXOvzmSPlCZqP8jC5mFOR0S8xfvNvboG bvasr1TP8hjB5AKJ2yqL620A8IOPAWztB0M6uRSv5QN6CUgciyncyHEhgwi5D87xGv PV/LGb1KTBP6eWTCnPLpjbDOoM0A1PJyS8tRhaZDzNC2J6HSWvu9iY3kO94VT9XvX1 Zt6lJADr2o4/DNqbr7uW2s/Vk7eXpIeKf/PtMXaulg+1AHZMXQ6EIpYnrjX72DzBd/ UBzORVJqLtDpVMjV6m0bbfxLf9DHK8ynfE2gZUS9G4kWfPODKlapdihYaC6gzCx7+8 PZfGzSNPazBfQ== Date: Wed, 22 Jul 2026 12:30:52 +0100 From: Will Deacon To: Andrew Morton Cc: muchun.song@linux.dev, osalvador@suse.de, ljs@kernel.org, david@kernel.org, liam@infradead.org, Dev Jain , catalin.marinas@arm.com, kernel-team@android.com, riel@surriel.com, vbabka@kernel.org, harry@kernel.org, jannh@google.com, lance.yang@linux.dev, kas@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, apopple@nvidia.com, rcampbell@nvidia.com, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, ying.huang@linux.alibaba.com, ak@linux.intel.com, nao.horiguchi@gmail.com, mel@csn.ul.ie, j-nomura@ce.jp.nec.com, pfalcato@suse.de, tglx@kernel.org, dave.hansen@intel.com, jpoimboe@kernel.org, linux-arm-kernel@lists.infradead.org, ryan.roberts@arm.com, anshuman.khandual@arm.com Subject: Re: [PATCH v3 0/6] Fix incorrect access of hugetlb pte entries Message-ID: References: <20260703114202.365553-1-dev.jain@arm.com> <178464737122.1305746.12295190523058911270.b4-ty@kernel.org> <20260721133636.df1a012df895054d3fd34a2e@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260721133636.df1a012df895054d3fd34a2e@linux-foundation.org> On Tue, Jul 21, 2026 at 01:36:36PM -0700, Andrew Morton wrote: > On Tue, 21 Jul 2026 18:18:38 +0100 Will Deacon wrote: > > > On Fri, 03 Jul 2026 11:41:53 +0000, Dev Jain wrote: > > > There are various places which use ptep_get() to get the pte entry > > > corresponding to a hugetlb folio. Some arches (like s390) have special > > > handling to compute the pteval, so they provide huge_ptep_get(). Use this > > > helper consistently. > > > > > > Additionally, some code paths may provide huge_ptep_get with an unaligned > > > address. This is a problem on arm64 (I checked other arches and it looks > > > fine for them), which is fixed in patch 1. The fix is made to be > > > to huge_ptep_get() - that is wider churn and we can do that later. > > > > > > [...] > > > > Applied first patch to arm64 (for-next/fixes), thanks! > > > > [1/6] arm64: make huge_ptep_get handled unaligned addresses > > https://git.kernel.org/arm64/c/9175a8c7cfe88 > > > > I'm hoping Andrew can drop this from the mm tree to avoid a duplicate, > > but I didn't hear back yet and I'd like to land the fix. > > I can redo Dev's series to omit [1/6]. The patches apply that way, but > there might be build-time or runtime issues running the other patches > without [1/6] present, haven't looked. > > Also, review indicates that the changelog requires updating > (https://lore.kernel.org/all/2b9d60a2-8698-46b0-80ae-b8747a66a85b@kernel.org/) > and I believe that Dev plans to do that. There's been no update for two weeks, so I wouldn't hold your breath! > IOW, it would be better to carry this in mm.git with your ack. > > Do you plan to upstream this in 7.2-rcX? If so then I can hang onto > this patch until it appears in mainline. Or something. Yes, I'd like to get this (just this first patch!) in for -rc5 so I picked it into the arm64 fixes branch. Will