From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6484333C182 for ; Wed, 22 Jul 2026 13:15:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784726128; cv=none; b=tfSdD02QoNwq5zZ++rBiONwMBq+HBS+7/hKw2r0J3pgs0UX6NEBrJggDlTcawier6qAgcTyNCFc0ABYhd2+V3yFltbrtpQ/jmwC1pJw1JRfmsaIGn9iKLVfDshdCnU64BFRaRLooQaZW0F4oXaJa2QZkpVoulPKZP6A4I+WKyjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784726128; c=relaxed/simple; bh=/byUoJ/WMc6UHqgCYQepUc84g2a8J34F7f8DVdRPKCU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fnh/vET4JTFIsF26R235/SFj1nueoXTP0V73XK7/+q1k7jvQkWDBlNaUqpWY1rWdcUaXERATU+r5Lv9ptw/s9sCTH6OdH79LUAu1qfnTzsLGsNIhuB3/kX1QFkiiJ8aQWiP3+7+SlQN5VVvCu54UqzOd8l96pfUxQ55/ZMKotFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=R0uGdrtc; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="R0uGdrtc" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-8485b358552so5141b3a.2 for ; Wed, 22 Jul 2026 06:15:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1784726124; x=1785330924; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date:from :to:cc:subject:date:message-id:reply-to:content-type; bh=iD1PTipWdU3DcXEKR2UtQxdCuq75xUopzE+YD6AEWUQ=; b=R0uGdrtc33TPlbNHKEqRhN6iNt4LRedE6PP3/Bv4cV+PX4o4w11ID1ci4liis1fVje B8eLSDLzdBRMTKOujFdZF54NQl8vqnCnDKIgPC+y/KuCBDW1j7/B3MLX0WSxdKJM+zic DUMQZM7+j5iNFhQDhP3ugrTZmOxvsakcQ/Pa6Ct6MDWEveRverGv4J3/AWW7WOi/pIQO FJN32z3AJNpLQ4Uq91Hi6rLlDujnye471NBEQKJ6AfGEx6btQT5DfcghLk+IUWA2K1Md wNQiPwj2ozLk1Gr2ugwgxQfpcET0Y5pNvY2xoTp3GoFsgveYaPOeTP/wu27HqI+7WG4b /gRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784726124; x=1785330924; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=iD1PTipWdU3DcXEKR2UtQxdCuq75xUopzE+YD6AEWUQ=; b=G8T7ESY75p3JIf5g66b0nA1n6snkHnn2woeCz/H8O50a/jhPtrjIqoZ8m3bDv5KSVd WL1QjsUiIi9XsIonvmeXmKodK9GicNvTaq+9MDu2xoTflMT63SSK6zGYzfjMop9UwTgn cvMS+Mw6xet1Gb8OAdSnm+9qwrXoS2xUipTStd+HTsDsOfGciIcKVPHedfO3nyISw7JN IE/u1nw1Azw8nzx0Zgrng3efjzJiSOtUftJfa0E4ahK9ZIcCD/woOCYtdDChB5qmWhoD KYJZ1Un+6fvdtl6Xm8halLNAlbNw9m9SBobMeiJBoF5rhrdXwZWlcIWASUp1AJdFQ0b8 Fkjg== X-Forwarded-Encrypted: i=1; AHgh+RpPLaF0n/AZYjFWU/U3UkrxyjLz1PqpQ9Mq4jp2QOr0kHz/IFxfsZEwp9xqXOUGnQr7o10VhVSiHKEC6Gc=@vger.kernel.org X-Gm-Message-State: AOJu0YwRcL2q0shO1LHwX/yFogufylIb5OGczuc1UOy/BMO8U4aWa2AN NT/P9bEfTQQxHSgDZxlxK6sT3fDFN3vONXpG56V2BRNkO16y1SLWFOG9unfvffDh6HQ= X-Gm-Gg: AR+sD13iQFcB+JXSsE0cv4H6HRGeic0aUyQN3Q96M15LDqAB/cW+yebVeoFWplplCq4 9xYZVOREat6IqUjMUvsUD219vMUikv2FII1LFPlmRXoLLhhV5qmVMDbNTplonpgRU9SFBWEmO9m oIzFzHJ9Wc7bGyRAK+eHeDpGToD/ME0CFm7Wn/2F93G/oXP4nfs3PDcyO5NYGHJ43w6SmmJCDyd U6aeDS8yjsJpe/u+7+J4ftYWkCK1iM5v2ceMZf3D+tLnYW4BNkQnexpFsMIFPYakRyU8WbOw9js twYX9afGhiBOrQ7fl+9Ljm8WzsMq+W/BW53onyUeK9zFwjmW3sQ5G3iKrIfElBuTcFIFVAQ0+BR jW69ezI/UCsfJ40sBw8FI8ytwCim23Zlppp/jM6PVo3P/OfJ2OlpQc+tdY1Y= X-Received: by 2002:a05:6a00:3a21:b0:847:8d2d:712f with SMTP id d2e1a72fcca58-84c29239a02mr23869158b3a.10.1784726123466; Wed, 22 Jul 2026 06:15:23 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:49::]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e17237c3fsm1368442b3a.9.2026.07.22.06.15.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 06:15:22 -0700 (PDT) Date: Wed, 22 Jul 2026 06:15:19 -0700 From: Joe Damato To: longlong yan Cc: pabeni@redhat.com, kuba@kernel.org, davem@davemloft.net, edumazet@google.com, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, shuah@kernel.org, horms@kernel.org Subject: Re: [PATCH] selftests/net: use MAP_FAILED instead of (void *)-1 in tcp_mmap Message-ID: Mail-Followup-To: Joe Damato , longlong yan , pabeni@redhat.com, kuba@kernel.org, davem@davemloft.net, edumazet@google.com, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, shuah@kernel.org, horms@kernel.org References: <20260722015129.916-1-yanlonglong@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260722015129.916-1-yanlonglong@kylinos.cn> On Wed, Jul 22, 2026 at 09:51:29AM +0800, longlong yan wrote: > mmap() is documented to return MAP_FAILED on error, but tcp_mmap.c > compares the return value against (void *)-1 and (unsigned char *)-1. > > Replace these with the standard MAP_FAILED macro for better readability > and type safety. > > Signed-off-by: longlong yan > --- > tools/testing/selftests/net/tcp_mmap.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > Looks right to me. Not sure if it needs to be set with "net-next" in the subject line to make which tree this targets more explicit? Either way: Reviewed-by: Joe Damato