From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D0BA220F49
	for <linux-kernel@vger.kernel.org>; Wed, 22 Jul 2026 14:07:59 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1784729280; cv=none; b=qmhzmIDNtpb84l4sRUSEk6bC24xwrdGhDf/j71YjORSP2s/rCLOwHzu6EXXf8Rllb4Tjf40SdmPARXpeoEV765O71NcjfAJeV+s8b9Zuq983WGTo7Ac++zkeecWjEx9XoxbFe5904p2QEznf5bquwCOhNdyPCrS7kKyNmQ1JEio=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1784729280; c=relaxed/simple;
	bh=0RcduR3l5A2gHysZQweQOOrLqRe2p075nwHH4A6SflY=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=K/bk7yKEAguWDYyXbJscYwugu2PuMffQ5sveytXovYrnVgFs6Ev67rTDDwzzVHP+FFFbVuA/JP5edBZPmfht2WnQ1sE+MW5tkwBX6TOZR71omqTkqu/hIpKvxTdUOu2lCvuW4YWdRxy8aA0eR8b6RNoq9IRRGRWnKdphbo+yzeQ=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Uf/YWz4o; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Uf/YWz4o"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A8791F000E9;
	Wed, 22 Jul 2026 14:07:57 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1784729279;
	bh=uZmcu9JwILxWNgtqt3rva5gGU0v7tA/kk0QDObandDI=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=Uf/YWz4oKOWBTF5U0A1Mq8618mE6on5JiP8gsgPKk/fM8hRDVtt+gM13GzyNx0qaX
	 YhGMZChIixfEVihBa9Y4GFjw73uMSrd3rn2iLpNqvv3Zje+7OZj3weNQUE5S25ZR95
	 abCRgoNLTH8V4iW9RFkfpljEevhD42/iSazbyfczyPVJ8A008B0Kbicral4Lr7kvih
	 pWBwt6sxv2Zyz7ja/o1wKMOQVFTqHlhXesSow7/6Lmjzaq6en23ELxTgUjh3bPYBu7
	 miFU+sd6B367O9Rq6v8f/YtvwYoBbCIxfsiRhyZ9/pxZM1QUQsjGi1QA3qqeq7S+nT
	 NYiH3c7gPIZFQ==
Date: Wed, 22 Jul 2026 19:34:05 +0530
From: Naveen N Rao <naveen@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, linux-kernel@vger.kernel.org, x86@kernel.org, 
	Nikunj A Dadhania <nikunj@amd.com>, Manali Shukla <manali.shukla@amd.com>, 
	Bharata B Rao <bharata@amd.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v3 2/3] x86/apic: Introduce a variable to track the
 number of EILVT registers
Message-ID: <amDNjmJDbwwq_xrI@blrnaveerao1>
References: <cover.1784619898.git.naveen@kernel.org>
 <39d39c3b91d174f4090fb954c6690edae9ed8295.1784619898.git.naveen@kernel.org>
 <878q74ldj8.ffs@fw13>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <878q74ldj8.ffs@fw13>

On Tue, Jul 21, 2026 at 02:42:35PM +0200, Thomas Gleixner wrote:
> On Tue, Jul 21 2026 at 13:33, Naveen N. Rao wrote:
> >  
> > +extern unsigned int apic_eilvt_count;
> 
> Please do not create yet another global variable. It's an APIC property,
> so struct apic is the obvious place for it, no?

Indeed, sure - will move it into 'struct apic'.


Thanks for the review!
- Naveen