From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2F9044334BA for ; Wed, 22 Jul 2026 17:53:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784742802; cv=none; b=olWwINx1q8LkfNu7n52jQNDyt5PDVAklx1fQgfjfUiXyYT4izbKIQIqqURiPCjZKwCDnm1hTevynAlz03/FxYEyUm2UUireAmsy7aiQu3pS2I5fz8R9MRpNYHGPc0dNSl75PbbwEWpewBWxDWIe5PvFLVKY+MdTRjF/3ObFRDt0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784742802; c=relaxed/simple; bh=fMrr1EsINhfW5QJIPFIQnz7kAJDQT3TUzGoHNqkajoM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WXyoEYcbuIbq3/sQVHiqZ+Va815DaNbiRoO23SLHbqmG1nr0BTthFJ142vTUtLhmIWwFCdTn4TJ9m2xqqG13sFSHrubDvNkM2j5D3GpCZQvSvv2AIk7dtdEV8Zx/Bzuwsu1ceXZ2Uj5Xa/kFecHOu6R3TPeplzBsPtaXKYcFGY0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=VV8usQ3T; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="VV8usQ3T" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C35FE1595; Wed, 22 Jul 2026 10:53:13 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5C0483F66F; Wed, 22 Jul 2026 10:53:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1784742798; bh=fMrr1EsINhfW5QJIPFIQnz7kAJDQT3TUzGoHNqkajoM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VV8usQ3TrTKJNSS24PjGKT7sMpgJvIZI1eNdlyDL/cj7zRt94zuVFtkKH4fq6Bv9G UigW16XdxUeMwEC4J8u5g2+hOpzeE1zMMHYKzn187Ci5w8N3mNsxyBOtVsgLaUWgs4 QHmF0a3G5NA+cY8yWDJKsSFzgqVwBkuUaTh7IScc= Date: Wed, 22 Jul 2026 18:53:10 +0100 From: Mark Rutland To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Chris Zankel , Max Filippov , Will Deacon , Peter Zijlstra , Boqun Feng , Gary Guo Subject: Re: [PATCH v2] xtensa: atomics: drop kernel-doc comments Message-ID: References: <20260721020023.3463952-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260721020023.3463952-1-rdunlap@infradead.org> On Mon, Jul 20, 2026 at 07:00:23PM -0700, Randy Dunlap wrote: > The arch-specific kernel-doc comments were supposed to be deleted in > commit: ef558b4b7bbb > ("locking/atomic: treewide: delete arch_atomic_*() kerneldoc"), [1] > but these were missed, so delete them now. > > Warning: ./arch/xtensa/include/asm/atomic.h:45 expecting prototype for > atomic_read(). Prototype was for arch_atomic_read() instead > Warning: ./arch/xtensa/include/asm/atomic.h:54 expecting prototype for > atomic_set(). Prototype was for arch_atomic_set() instead > > Link [1]: > https://lore.kernel.org/all/al3q54jxOKZujYue@J2N7QTR9R3.cambridge.arm.com/ > Fixes: ef558b4b7bbb ("locking/atomic: treewide: delete arch_atomic_*() kerneldoc") > Signed-off-by: Randy Dunlap Thanks for this! Acked-by: Mark Rutland Mark. > --- > v2: drop the arch-specific kernel-doc comments (Mark R.) > > Cc: Chris Zankel > Cc: Max Filippov > Cc: Will Deacon > Cc: Peter Zijlstra > Cc: Boqun Feng > Cc: Mark Rutland > Cc: Gary Guo > > arch/xtensa/include/asm/atomic.h | 13 ------------- > 1 file changed, 13 deletions(-) > > --- linux-next-20260720.orig/arch/xtensa/include/asm/atomic.h > +++ linux-next-20260720/arch/xtensa/include/asm/atomic.h > @@ -37,21 +37,8 @@ > * where no register reference will cause an overflow. > */ > > -/** > - * atomic_read - read atomic variable > - * @v: pointer of type atomic_t > - * > - * Atomically reads the value of @v. > - */ > #define arch_atomic_read(v) READ_ONCE((v)->counter) > > -/** > - * atomic_set - set atomic variable > - * @v: pointer of type atomic_t > - * @i: required value > - * > - * Atomically sets the value of @v to @i. > - */ > #define arch_atomic_set(v,i) WRITE_ONCE((v)->counter, (i)) > > #if XCHAL_HAVE_EXCLUSIVE