From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 311E33F58CE for ; Wed, 22 Jul 2026 19:59:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784750355; cv=none; b=FrzZY+3jWf6gXd+T37+LgSXLyBHgiKXTAEvyGPOgKLSv2TqhzxqolG/8HF4ZSXcE+JCOUx4MaXEOqgC10yXlEoyrSRg0ist9q4yRrY9YRorjrGSx2LTf0JBAEdUe+zaWe1LJJndZBUwtO7vzYaVVaRb04YtVTu7n1pjgtKk26Y4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784750355; c=relaxed/simple; bh=QzKGPAMMMcYp8C3yznRY+b0+buzB7XKjOZxs2Zi0vAE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OmKpyGPOTGdNKz5Z1OsX1vJNvlHvIjUbxC6bXoAn9P9o0Gq8Wwm2oO9CTOkhO2HE4P+IHBw2BCoYCKV7Mx5Qi7bvqsH7VzFY3pkyX/mLEwOCCb8by98C0z2UKj2wHh5yFXphsmhJui9X3LE6+7sBM0nkmmGs5EcZfe0koaw2MY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=eBukXR/E; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="eBukXR/E" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38e3617ba36so7399599a91.3 for ; Wed, 22 Jul 2026 12:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1784750353; x=1785355153; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=EEIQnXJI41GVGpHCEj7IDcqZ+AmiiYPwRk5ZlYk7rZE=; b=eBukXR/EsjSSPdjGAt6oue4EPdv626XfkH8m3FKgn91ujkV/y6GptDL2sICWDF0t8d OntmcgG0cUrI17tvqqFVW+eeoxJraybSXYIT0sqsovZGBTg0PmzHOZERuYqJdEn8Yd25 Py0s55El45+7/jSvGkGe14TnCIKksIn8caOC5LhFx1nZTPN3rYsWpmYzBkKd++ByaX2o eVCuw7zH4an6RUQQAd6wEhPl4RhdMbeqTrxhL9ovkZG7BY+nHqfsX8kg64D0gcXVEb2e AeDvBD6HWk2jCO7wDKD4+Q0jSjJJDww2a1imWAyC3W1tGOcmx+LClRZY/Mpip3AbEiR9 BQ6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784750353; x=1785355153; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EEIQnXJI41GVGpHCEj7IDcqZ+AmiiYPwRk5ZlYk7rZE=; b=qZOxJFu1HjlRtzPTTYZEzLgxkK9CQ7t/vHqhuvhbJ/Zbz+2nEiQOzPv0i/VRiTGx/m RKH5RNjFN2xmFMQ+ztaLu0jNv75Pg+J4TfXcyBoHL0LReorP/rl0LxncFRVuVJjoXNeo jGDmciJQ5u75HRV8YWc4qWlCImmv0PyC7NKN268Wd3VtMMvsQzs4ucjGRb3Vo8433Gq2 oe1gKK0UGnZ6ozZ32SciDrlgPYS8hJqt1j0XssDeCMoVrWnUmKmsqz4dSXCn+R6JapK0 6v5+MBfKMzVQZ0hTPG64Ar9OQrAD4QY+OiZzjJ37jlDDhzhsHDwTLRccQjhLAu+myIOX 8wzA== X-Forwarded-Encrypted: i=1; AHgh+RrZ2TYdaNIYeJlqXjlAl8VN1lZXYIZycQn9Si7F/ZSCqMQJyRQQ4GOtmofaRR4kLs2aC8Ht5v+brOC00UY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4ft7xZl2tRxIgudjI4Iz+/YO/hoHW47YwIoD/n9RzRGm1GhHv fQQ+OBrBXSFpfKw/dFsPiZFVgDTEKPR09jFhUn26Pea6bS9VqMY0DkQEGq0gisQncOU= X-Gm-Gg: AR+sD12XcEyjgaoTM8Otv/vleeDtSl77Dt4GGGH8iJ6ZYMhH9RTbMsnmHrbs33MI4kR hhKgVYlGB8tLs0MJEj/h6a1JWaRRfoBaoW5SzMHj1PpoeItDOAmJP0C3+8FqOgTXd4PgOmCNcgL r40k/UJN1g58qiayI4/7bmIncmLdcE7uH3/tXCcc7alN3vZFHqcwpjQFCPrC1BtTFYzgP7kP8BK xg+MAGDH2YiUrL6RK0K0yOhgWCqW2RQfM9+s1KbLR46cMfxnhmbq0+oAIQxdL9/Xt4O6bgfiXZn +GJ3Als1+CIxpSZ/Zh9sRdjxlFzm3AUhpTm2XPthYFM9afjjQ0ez/S4lLaS8bn8d1k1XzrMyi+J Nch+/4uUxxVZbBEFOje1XmCSntjQrMO627xLN7xbdCFEir/7LFk5c X-Received: by 2002:a17:90b:28c5:b0:38e:7080:b4c0 with SMTP id 98e67ed59e1d1-38ec6979bc6mr98413a91.10.1784750353408; Wed, 22 Jul 2026 12:59:13 -0700 (PDT) Received: from ziepe.ca ([216.228.115.8]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13d13003f12sm14809771c88.2.2026.07.22.12.59.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 12:59:12 -0700 (PDT) Received: from jgg by NV-9X0Z6D3.localdomain with local (Exim 4.97) (envelope-from ) id 1wmd60-000000002O0-1hvF; Wed, 22 Jul 2026 16:59:12 -0300 Date: Wed, 22 Jul 2026 16:59:12 -0300 From: Jason Gunthorpe To: Leon Romanovsky Cc: "Aneesh Kumar K.V" , iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, Robin Murphy , Marek Szyprowski , Will Deacon , Marc Zyngier , Steven Price , Suzuki K Poulose , Catalin Marinas , Jiri Pirko , Mostafa Saleh , Petr Tesarik , Alexey Kardashevskiy , Dan Williams , Xu Yilun , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , x86@kernel.org, stable@vger.kernel.org, Michael Kelley Subject: Re: [PATCH v8 01/23] dma-direct: return struct page from dma_direct_alloc_from_pool() Message-ID: References: <20260717180442.110954-1-aneesh.kumar@kernel.org> <20260717180442.110954-2-aneesh.kumar@kernel.org> <20260721115456.GI110966@unreal> <20260721142921.GN110966@unreal> <20260721153321.GO110966@unreal> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260721153321.GO110966@unreal> On Tue, Jul 21, 2026 at 06:33:21PM +0300, Leon Romanovsky wrote: > Something like, but probably void* needs to be phys_addr_t: > > static inline struct page *dma_phys_to_page(void *addr) > { > #ifdef CONFIG_DMA_DIRECT_REMAP > return vmalloc_to_page(addr); > #else > return virt_to_page(addr); > #endif > } I don't like this, we don't know for sure the addr will be in a vmap and this will fail if it isn't. Jason