From: Xu Yilun <yilun.xu@linux.intel.com>
To: Michal Simek <michal.simek@amd.com>, panchuang@vivo.com
Cc: Pan Chuang <panchuang@vivo.com>, Moritz Fischer <mdf@kernel.org>,
Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
"open list:FPGA MANAGER FRAMEWORK" <linux-fpga@vger.kernel.org>,
"moderated list:ARM/ZYNQ ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fpga: zynq-fpga: Remove redundant dev_err()
Date: Thu, 23 Jul 2026 12:55:10 +0800 [thread overview]
Message-ID: <amGerjZAOCySe2c2@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <701a4078-721c-49a9-90ac-d59697fef82c@amd.com>
On Mon, Jul 13, 2026 at 03:48:57PM +0200, Michal Simek wrote:
>
>
> On 7/13/26 15:22, Pan Chuang wrote:
> > Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> > devm_request_*_irq()"), devm_request_irq() automatically logs
> > detailed error messages on failure. Remove the now-redundant
> > driver-specific dev_err() calls.
> >
> > Signed-off-by: Pan Chuang <panchuang@vivo.com>
> > ---
> > drivers/fpga/zynq-fpga.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
> > index 9d1d599ef718..2f8ba32e4002 100644
> > --- a/drivers/fpga/zynq-fpga.c
> > +++ b/drivers/fpga/zynq-fpga.c
> > @@ -598,7 +598,6 @@ static int zynq_fpga_probe(struct platform_device *pdev)
> > err = devm_request_irq(dev, priv->irq, zynq_fpga_isr, 0, dev_name(dev),
> > priv);
> > if (err) {
> > - dev_err(dev, "unable to request IRQ\n");
> > clk_disable_unprepare(priv->clk);
> > return err;
> > }
>
> Reviewed-by: Michal Simek <michal.simek@amd.com>
Reviewed-by: Xu Yilun <yilun.xu@intel.com>
Applied to for-next. Thanks for the patch and the review!
prev parent reply other threads:[~2026-07-23 4:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 13:22 Pan Chuang
2026-07-13 13:48 ` Michal Simek
2026-07-23 4:55 ` Xu Yilun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amGerjZAOCySe2c2@yilunxu-OptiPlex-7050 \
--to=yilun.xu@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=michal.simek@amd.com \
--cc=panchuang@vivo.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®