From: Xu Yilun <yilun.xu@linux.intel.com>
To: Kiryl Shutsemau <kas@kernel.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
rick.p.edgecombe@intel.com, dave.hansen@intel.com,
dave.hansen@linux.intel.com, yilun.xu@intel.com, djbw@kernel.org,
linux-coco@lists.linux.dev, chao.gao@intel.com,
peter.fang@intel.com, xiaoyao.li@intel.com
Subject: Re: [PATCH v3] x86/virt/tdx: Formalize SEAMCALL version encoding support
Date: Thu, 23 Jul 2026 13:43:51 +0800 [thread overview]
Message-ID: <amGqFxt/9DquRGO3@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <amCnuX8XAjxWFlHd@thinkstation>
On Wed, Jul 22, 2026 at 12:23:04PM +0100, Kiryl Shutsemau wrote:
> On Wed, Jul 22, 2026 at 04:46:34PM +0800, Xu Yilun wrote:
> > While both options have merits, I chose the latter from a
> > software-centric perspective. I sent v3 to invite more discussion.
>
> I still don't see what postponing the encoding to assembly buys us,
Sorry, I overlooked it. I think this gives us consistent view of what
'fn' is for all seamcall-related functions.
> but it is not the hill I want to die on. The result is centralized
> and correct, so let's move on.
>
> Reviewed-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
Thanks!
next prev parent reply other threads:[~2026-07-23 5:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 8:46 Xu Yilun
2026-07-22 11:23 ` Kiryl Shutsemau
2026-07-23 5:43 ` Xu Yilun [this message]
2026-07-23 9:35 ` Nikolay Borisov
2026-07-23 18:13 ` Edgecombe, Rick P
2026-07-24 3:14 ` Xu Yilun
2026-07-24 17:05 ` Edgecombe, Rick P
2026-09-11 19:58 ` Kishen Maloor
2026-09-14 4:58 ` Xu Yilun
2026-09-15 0:18 ` Kishen Maloor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amGqFxt/9DquRGO3@yilunxu-OptiPlex-7050 \
--to=yilun.xu@linux.intel.com \
--cc=chao.gao@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=djbw@kernel.org \
--cc=kas@kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.fang@intel.com \
--cc=rick.p.edgecombe@intel.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®