From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCBC03F1ACF for ; Thu, 23 Jul 2026 10:10:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784801434; cv=none; b=SGL9rywsAGc9cG5+ebIi82QNxiV0JW6CFiW9j0of4Mq4W9BNtY4HmT8I4I0IL3l37z/mrt1uoBshsQPkvRflUmzWWHPjBPCHQbZG7vh3kQRPPkDF3Fj4Y2Jyhw/66g1WT2zbnsZgVeL7NWGSJAuub/dG9oLMf+qgM2v+yX6zJP8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784801434; c=relaxed/simple; bh=yItB58k8BFtqh2Q5pQjupFSfMUetmTfeicNvjsKB1j4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CgPjo0+Ksoz9IK3zCSsQ04HG4BBxhdlFnxWq3ViBWCpr9JJk3QH+462AiV1Lqr/0x7kdYOip2VmZJH5lz00EPVMNkfc8impw7Hm+Q+WjVbp98SIj7IOhWx258v8qrySfjizVAqXRNanxrpvQLCVdzuOGxY2JhajODJHWlZgA2l0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OflSZdNH; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OflSZdNH" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-47f703a9e5dso194133f8f.0 for ; Thu, 23 Jul 2026 03:10:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784801431; x=1785406231; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=jpc/Xl7lBNJNdoEZz5gUFmHlWajy28tsF9ky0//+6w0=; b=OflSZdNHIuqapsdvwgjSJQbVOSx3r7P8Ws3cgnd6J9L7BYMJkbaZUGNJMzLAXIAvEB CDcr+ZDp6sdSLQbD8sieN26kodB5WKRtVtkbQxwi965XNyoXscN6cscxkpdRL8T/WfbR it5pdTj7aLj0KNNis88WdGg+2l1AT3rwDGn7TMQYBMCvVNUM1h7hPgw/Dv2R7/gkB1My 69kZ2lGxaRXMK6syGrE0dC5omORhSsxf96297mvr/cIXP4B5xynf0theGp1atj9E2su6 9k9vRXMzRclVXccL9s2POmyPW9G3EurAKCJndZi69DHtskJjqUbNa17LowVmzeMbtLOa efCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784801431; x=1785406231; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jpc/Xl7lBNJNdoEZz5gUFmHlWajy28tsF9ky0//+6w0=; b=nA91faOW/WU2pHXYuECGgK/pQsDVfSGS6krBrQVuP7TqvJT96qqnV8c6fEA/gTZgG3 u7mvixC7tQ23vMvx7U8LZuZHfZ/gItoVjapKHkrAHcnzhvdx6YANpZCYgQaZrmmph+ba s1Iv9+ev+K41KQY/bOP9vK+RMToPYa6EE1eYWNSMgrdEjRFv5JEJ2Ntk4sG4fI6B1Wol TWLRLS+myzU5vJLGnyvlabkLv/F3It9zlIXOh+FEMZNPZAiH09wslvuAUze79WQx9LbI 8R/qea1RYPrJLx0YtM9WEholEQg/gEQe0DTPIKgaXtP9VHR4FJhrJdh8u6SIyM0Tb7hJ b++g== X-Forwarded-Encrypted: i=1; AHgh+RoDqY7sWDxmvECDxLl+fDWk901ozAEt3n6P717Cam0qI81lSAW6zL+Op2qRFwRPc3k/i/4kls1cgtVilXI=@vger.kernel.org X-Gm-Message-State: AOJu0YzFzLTI0mCXxP8AfyfGL8QNEIdVegOvsGoJtnz1XLIncAthoPrW 7MAVcC18dwi3tz6estR32TbAT5+9F+gO+bjsicDxbsHmfatxDruIbbAe X-Gm-Gg: AR+sD11dRDcUqtwU+n9Wum9+n139Y/Wv/eltHw1b+dbEDBGjg3Lcnl8WuD7DSuMN05M IRBTSPnw/qOCDXosuyZSnssG/GyUAl+WsR8BbyiOtVg/u8lPS9yTtbmVL4cZ7VcsgTlfLJMqsqf 1FFV+ldzhRNQmpJ22oFZg461AO0dczjLSh2hd6Pxd0UdZG+Vhd4iTvzaP/2xHccUhuGKaKPyilG XTmR7HLtyq1CHZ358zC1oJkjXi22663lMT5r5eYUmIGQN4uxgHeXaIsugD9bw9VirbDAxOzV2ic VWqVYzvHH56EdN31ULv1IqYJe6RVUBNxJeG1SAxExR57CkIECRaPStAST+ouxEA7Ledp2Y9ggsR m/0DqKSYXahaBpgQXbTzVwV3XlDPoVQVlklUjiZcg4483vVrV+tOe6izX3dZZcuEtUMHI6NyhtA == X-Received: by 2002:a05:6000:2302:b0:476:8a:5 with SMTP id ffacd0b85a97d-47f8d755530mr2890703f8f.34.1784801430971; Thu, 23 Jul 2026 03:10:30 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f85b9a5d9sm13544887f8f.5.2026.07.23.03.10.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 03:10:30 -0700 (PDT) Date: Thu, 23 Jul 2026 11:29:42 +0300 From: Dan Carpenter To: ColtenOuO Cc: Greg Kroah-Hartman , Hans de Goede , Michael Straube , Nikolay Kulikov , Andrei Khomenkov , Jennifer Guo , Minu Jin , Khasar Munkh-Erdene <02khasar@gmail.com>, Mohammed Rizwan Kaniyate , "open list:STAGING SUBSYSTEM" , open list Subject: Re: [PATCH] staging: rtl8723bs: remove unnecessary else after break/return Message-ID: References: <20260721160236.80963-1-jun930436@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260721160236.80963-1-jun930436@gmail.com> On Tue, Jul 21, 2026 at 04:02:32PM +0000, ColtenOuO wrote: > checkpatch.pl flags an else clause following a branch that already > returns, in enqueue_reorder_recvframe(). Restructure the if/else-if/else > chain into sequential checks to remove the redundant else, with no > change in behavior. > > Signed-off-by: ColtenOuO That's not the name you use to sign legal documents. But really, the original code is fine, just ignore tools when they are wrong. regards, dan carpenter