From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2385A4C956B for ; Thu, 23 Jul 2026 13:02:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784811755; cv=none; b=No6+gsZgRbB1yPRFTTZ/+tiAk1IWBgDaduPZYRYcJZHG+HwJAIu7o2ZeotiFHqQyYKn9gxE+GMNAxx+mmX2je+TDzvY89QGSK3HycO4MBby4lth2pxX6dA8YBV7GkFCGu7IStuR4bs3iO1rKGkn6++UBKpzkhtRAitriy4kl7JE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784811755; c=relaxed/simple; bh=07uF5rL7d5aKsdRkufqv094Ri7PWzAEpa6mJZUA5QXk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UM1SAg4HuJQDBcU3xE5xz38A2V76M7AxhCXdrWn/sqEdOmRABa4vHytjtVLxevq6gk8lIe9thk3sAR6MOvVstVQlRWrkxrFJz1bl72pA8SwByp9dgGV+pjIFUEFUaUGAQxlscLtv1rU9jO+zYt0+fdH4E8Yo/nGyl06ndAeo6E4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=IoSvxWvj; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="IoSvxWvj" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2ceae1ed204so5701485ad.0 for ; Thu, 23 Jul 2026 06:02:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1784811748; x=1785416548; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date:from :to:cc:subject:date:message-id:reply-to:content-type; bh=3lMFDKKyt9GdKFeZbUjldfucgXKXS6SFWpdSFPP3BCA=; b=IoSvxWvjoKnKHtJ5r0aSYkv6+CWiRNOzLtVPbbd0RHNoPRcSaEsxrwerQKDLVjoXDA FRaKb2SNA3/9y2iikuU0PsJ3U7Vu1k9CAaSbLz5n0l2EEolE5MmezN8A+42sid4/IeHN FmOWHycw+UHSb2DWYxy38L3EJiCbIW7i8AAXgLKx6+pOpI07S1PEnJKiRtjNnYfBY8ee Lah3a8upNhdpTgA6BQJqMAOKcFLA1fCBLX2omgV3CeXIj0MAiAvsK9qXRQVaqzqT1XO9 Yw9lyLYL+LUlhxjsdWInfDWr3ZOUob6McqSMNNCWhJE17TzwJMVAGwqT3uqOpTWhYDNZ 2uQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784811748; x=1785416548; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=3lMFDKKyt9GdKFeZbUjldfucgXKXS6SFWpdSFPP3BCA=; b=paja3lf061/OzpKHdgFXlFn0DFBTAgoSis2NjSxIFdQdKEjoxqz/6Hz65/M5WmTmP1 SwLzGjHKZWDbT03P1gH3Lw2nHcNLT8ETnuSKO46SUYOuceeSlrcIw5XBxXt1P3Aq5uP4 ZYivdcpVFaE8+UPVAIMnEJ+plQbcQLae+i4LP7WXSjsrcIJLFSdV79qju/MxDRej7sKz N5D3/aToZp40gFy6UCbGCOhQkUHkKUPfgFZ0nk+6MsQr09EEiROPdMr4hVJjmOAPt94z hRxKNg9UaSK3yCiA0BgcVBsZWXE+/ZsQdW1v+UrYE2QQLy4qI3tCcW3eOKZCouXOZv4n wCNA== X-Forwarded-Encrypted: i=1; AHgh+RpLGmum0pL3oAvhL2Eln/KCQaUVsOA03iDFmGrSFhgsJpmO1Yq3how+f1NQ6Vbv5u0LRcupmh8Vrizi/aw=@vger.kernel.org X-Gm-Message-State: AOJu0Yxmn+OR4vg1ZyahjR9fkcvBLM+tePF1fsPrycPexvxBeoLR0oaA 4EWlGxMrqlMSo4Li6qVgUM8+77e+qXPTbr5C8hqjC7OzqS+8vC/aI7fwLk+DBwmmSXo= X-Gm-Gg: AR+sD13GLFR5noy92tr3YkaOaDuVMZxq61eMFUykTMyo23oi5oBq/nGpwnqLeE8ebXc LsLtoyO6tIAo7pApEbx472YlpL1hnMxzfKcAwPriucLkqtJYYQZRQY8TqBGVl1nqTclwR2EqRoC 5rrYs/yoG7p+7NhEcslQb8lYUwFEqZUjDtbt7Q/Qea1WeKKSg+0rhEOhjcICT4R8FzfSyJzylCv qeEDS03isDeTmyX0FA8Z3USYYI0wAioRcHmpviicLBOO5PfrkKG2WSnkOaKBwzxICSyiC1HqQEr z5vlfS0uF1TKICK1CGzye4pcPP+KC5V/hE3HoYXwXdmw/vq7An0OuhbDJpN3qPKnVmU34bo0KRL Kmtf6P8l04w2nBcdtJ/5IP6ipqDqbJIL0R9daQ2bHuWPhEZtN4F/5+/0cBYo= X-Received: by 2002:a17:903:184b:b0:2cc:307c:51fc with SMTP id d9443c01a7336-2cfa6bb32a4mr34615355ad.21.1784811747711; Thu, 23 Jul 2026 06:02:27 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:46::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf8f350554sm33032095ad.66.2026.07.23.06.02.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 06:02:26 -0700 (PDT) Date: Thu, 23 Jul 2026 06:02:25 -0700 From: Joe Damato To: Hungyu Lin Cc: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] igc: Remove unreachable break after return Message-ID: Mail-Followup-To: Joe Damato , Hungyu Lin , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260723070451.6545-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260723070451.6545-1-dennylin0707@gmail.com> On Thu, Jul 23, 2026 at 07:04:51AM +0000, Hungyu Lin wrote: > The break statement immediately following the return statement is > unreachable and can never be executed. > > Remove the redundant break statement. > > No functional change intended. > > Signed-off-by: Hungyu Lin > --- > drivers/net/ethernet/intel/igc/igc_main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c > index 2c9e2dfd8499..6252d4b68f88 100644 > --- a/drivers/net/ethernet/intel/igc/igc_main.c > +++ b/drivers/net/ethernet/intel/igc/igc_main.c > @@ -2528,7 +2528,6 @@ static int __igc_xdp_run_prog(struct igc_adapter *adapter, > if (xdp_do_redirect(adapter->netdev, xdp, prog) < 0) > goto out_failure; > return IGC_XDP_REDIRECT; > - break; Hm, from Documentation/process/maintainer-netdev.rst: Netdev discourages patches which perform simple clean-ups, which are not in the context of other work. I think this patch probably meets the definition of patches which are discouraged.