From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1D66439F8D for ; Thu, 23 Jul 2026 15:04:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784819058; cv=none; b=js05+aYvKou7GhjXeyan0B9T3OJufoO1JAh+LCWqA1MBmCFiIXddpOZD5+5yzSblR61iN296S91C/k9Z0VtLUF7a4AN5jo4UJ0ZjS0Y6AKfiJ4UCVmMW/rHo8tKnJo9S9FV86LOSKh60GUkb1mBAWo5cj1BFVJ68qjrjFTExu9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784819058; c=relaxed/simple; bh=UEMwl1mUTJq51zU6rBTHe0+55FnjRFqfSf95Y/ByeA0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HALSo+eRDacrDtfHl/fmxRYoOuJERwstslN0LLi9lUFh83SoennTVmXdOjE54r/BSUVSDv4e3wWK4R5ry1c1wGOyLKNIDreE4YW5fPNVWSb4QwXp0Nf09CPWLh7f4JiHsGaHY2pEXdP7LI8a96ACjD3IiylmvkGONEyryL4LcEs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZG8ETC/c; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=XgFku1er; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZG8ETC/c"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="XgFku1er" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784819055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aIw6GIPoYXkHISLGH2TozSxZ9dhllUdd+v51QggT3+w=; b=ZG8ETC/ckOrzbedFhQ9vSAwHoPwiQ2kOklaYEGEBWfdu5iSBkcHRaI//W5gSY+AtEBUDAZ 6l3w3Xq1cQlbJB46YUswiJX61yzT08hg3cPGq68q1P8k7VuCX/yTnQ80kRlmQnWqLTqH2a d7rIdgscyuyfh2HvCSpJxswGTo3NKcI= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-397-6PRBnpbnPKCvxOKSAHghlw-1; Thu, 23 Jul 2026 11:04:14 -0400 X-MC-Unique: 6PRBnpbnPKCvxOKSAHghlw-1 X-Mimecast-MFC-AGG-ID: 6PRBnpbnPKCvxOKSAHghlw_1784819054 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51bff5c7035so20921611cf.2 for ; Thu, 23 Jul 2026 08:04:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784819054; x=1785423854; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=aIw6GIPoYXkHISLGH2TozSxZ9dhllUdd+v51QggT3+w=; b=XgFku1erIFKjnCWJ294bJGfDCMvAg805NaEB4LA5LjtmogoUtGYVNBzDk+BQCmKltT q9z2NkU9MHJ6mkrLIHVp/gD41Z+MDBVAGrZGuyulECuvAOGDYDoYOk73q0QAJJdwGtAy iAVyOpdy9WkDIhkUplxygxaXB1zHLUXGd1V5TE6IzgsPVhJ93GvQUUg5Yg8GkY4WJpD5 gu+OFglsQckTx9/3HxkFxUHcMNqQz1S1TrM+qSEXFLuxb7/SIAu4MhiDmFvl1xBpOdht yoFVbfpWX36Xtbmgo2dltr3x1TTwmZG3IhAnoEDaiJc062Mw65cbPzF08OsWbLCG57sc sIKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784819054; x=1785423854; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aIw6GIPoYXkHISLGH2TozSxZ9dhllUdd+v51QggT3+w=; b=Hs3HtsPQfMHzzRItoOykIOlVTRuIpJAatRU7kCO7BXtQuSN4Uy5ZVIVtBprtODABfF 8egMP4g2LOjUqWDAlwicum1uE4Q8VjZHgCUP/+PBldrdZ6D/86kOMDupkyAwI26VLTSp 03BzDCPe6WC95CnQKn7hZcHRknm18POneaLgStX9L4OF0P2qyOZykEMlu7az+lYXUEum jWYMQQOWUmCEuiHbP8W6KdUjfgIW2pwpwm9iyw23k+ZrtCJReJk/I7Du9I6b+d2/V+LO uCr4QjG91wX5E0UQZl04Fp9nqEBZ9SN0jxmFtDvzj9GmieEBfkhRNQDvPkUuAK0g0wZC HB9Q== X-Forwarded-Encrypted: i=1; AHgh+Rrc6IWy4W3SAl51ZP8t6YFbfa4/fFBwxAIm1Nd6lAPZZVMfP/mRH0ajVAgmUGwYQUtffUQnNccVmP+0k+Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzWDNOv2OojMAfo1X3al5Im1L0kXTeiecIebfeXP/tIYpG8m+Jt BDdcOm5e/sFPaVoDeNcqvgy39SzJi3hOPEGwJkWarrkdp3uZy8M9sa7jDCskdQISNFfHeCYYcrQ unSQih1jRO6oxfUfHuUkHqBFJmADCSHGH/e8Ur3Ydfph6t8ZSs8qq8JjP2TBh3FnQKQ== X-Gm-Gg: AR+sD10k9bVKPDDookUrLT20X7694Z50P8tCLhnCrqKlLx7M00NGDF1GBIOZ/9JPMg0 bp2mBhEEzKXulGIGjOJE9mEL271e+1TvK1scpye51BwjKbJ5R30KBav7Jb4FcN46njGFeDGkfAM qZosxoAeurhknBUNFSJ2ylELQbGe3ysJDe3mtDH1g3RZLKT9QbUY2tQdux8fyz93DJ+nsUGRrF7 UhiBs01TNxF2QD0hGKpXDfZ1Pd2beiLSJEE32ZUBsWbvufolrTT58f+1Y+JnN1AzsVzEIkyFQWJ FFk+n+bD3ZSQHB+YOoQP8CcID3l8SnYPrV9N6Wa3KchKvdMu7ZfXgqjKYeojNfB6S+kmK59UDUT PfW1+l3Zx9VuS24irLMc4EunQCope4bvb8lY= X-Received: by 2002:a05:622a:244f:b0:51c:7b12:5fdc with SMTP id d75a77b69052e-5283e03d447mr32053571cf.88.1784819053785; Thu, 23 Jul 2026 08:04:13 -0700 (PDT) X-Received: by 2002:a05:622a:244f:b0:51c:7b12:5fdc with SMTP id d75a77b69052e-5283e03d447mr32053161cf.88.1784819053161; Thu, 23 Jul 2026 08:04:13 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-527d402cb05sm36676211cf.31.2026.07.23.08.04.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 08:04:12 -0700 (PDT) Date: Thu, 23 Jul 2026 11:04:08 -0400 From: Brian Masney To: Suraj Gupta Cc: Radhey Shyam Pandey , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Simek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , "Rafael J . Wysocki" , Danilo Krummrich , Jonathan Corbet , Shuah Khan , Michael Turquette , Stephen Boyd , Russell King , Shyam Pandey , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-doc@vger.kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, harini.katakam@amd.com Subject: Re: [PATCH net-next 1/7] clk: Add devm_clk_bulk_get_enable() Message-ID: References: <20260723123838.125145-1-suraj.gupta2@amd.com> <20260723123838.125145-2-suraj.gupta2@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260723123838.125145-2-suraj.gupta2@amd.com> User-Agent: Mutt/2.4.0 (2026-06-19) On Thu, Jul 23, 2026 at 06:08:32PM +0530, Suraj Gupta wrote: > devm_clk_bulk_get_optional_enable() gets, prepares and enables a set of > clocks with device-managed cleanup, but treats every clock as optional: > a missing clock is silently returned as NULL instead of failing. > > Consumers that need a fixed set of mandatory clocks enabled for the > lifetime of the device currently have to open-code devm_clk_bulk_get() > followed by clk_bulk_prepare_enable(), which loses the managed disable on > unbind, or fall back to per-clock devm_clk_get_enabled() calls. > > Add devm_clk_bulk_get_enable() as the non-optional counterpart. The > underlying __devm_clk_bulk_get_enable() helper already supports the > required (optional = false) path, so only export a thin wrapper for it. > > Signed-off-by: Suraj Gupta Reviewed-by: Brian Masney