From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44F9F25785C for ; Fri, 24 Jul 2026 01:10:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784855452; cv=none; b=jv91uV3utNDnZ2rc+hw4HOiZMwGMtWtcd2U7hzqyUXYNHc3hxNWUGuRKk8bYyI1nhIvy+EyyiCfFXtMkALYbAIYS78kbEaAuVmI0GBsklewjWr8axwkq1fFA/uT5y/bZpW76Y+vFOJq1Ihd/sKk3ksENUAKz052jgdB6DS69Djs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784855452; c=relaxed/simple; bh=cKCXzL/Gz7oPhZJ4mW0g34rVgolKaoUYkZt4WwmXgvI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TDLjIzK0WZjwt7tK1x9GT0zpL8pm9WNJmmwvRoZ93qY+TdxiBWDUkc4N6oHicEiAH9VpPVXfOox3FTCb7hGptNWiml1u3/AoHx1Af4a7vlNSGIAK385uAoJBxx3BkTt6NsfhxAlLCpzBjyV1FN9OmtwRQJOlm/0SwGytWPq7Ts4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=n5zFC0Ya; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DEiTU/KE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="n5zFC0Ya"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DEiTU/KE" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66NLeGlC1055296 for ; Fri, 24 Jul 2026 01:10:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=HPYsD0/TeExFSSyQteQLZbxh X5u9ElKV6bb6GLLxXCE=; b=n5zFC0Ya9YRS8LACbWev7keCsBaS0bJa1bNnxKg9 9VNXYkeRhLfjWLn3uMuUM4zNjUeDk955PYoQambYU2WXJEpPiqN+w+rZj9uZqXFl QmntrSOSB6vLxOQTV0Tn0FCVhHbbiEp1H7OnyDMqDS2X2NZfhdy6nW5cQ/W4zLVP pR2fy6V4TfRmpYFdiqaNcnFgaRrP2GrrPXfAn7IDZDk0Tql8k616EvEYPZkcvKnT zdtOVBkNLqVvEEjhe+k6cBe1GcmLVWEvOjppDcWQtb9oTI8+h+sjflKEBUKjGNdC m4C8ljugBVO/qPBqrF3uyjEUalCrOUOW7i9AyY175DDC3Q== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fknbmj72t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Jul 2026 01:10:50 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cd01a14e81so17577565ad.1 for ; Thu, 23 Jul 2026 18:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784855449; x=1785460249; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=HPYsD0/TeExFSSyQteQLZbxhX5u9ElKV6bb6GLLxXCE=; b=DEiTU/KEpjqEQoIC+xBwTEyV42CsuNh+GKgyv8SIaZnkd7suyWfViP8+OnRtgV/dNT z+raT5AUySwyRrk0bcKSX1dn/gv3m/ufQUpO1OrH1thkZC96pr5lsk6t9vxnczRZCzBR KNOagFrJRjNsUOqoxhhlZlRTLv4ZiZ7CfAfIZRb28os/45v1sGAqtlRTHlW2ccVi9Lfe ie81OWQyelykOeAwK717hy/n5CG6ooQr0T9MquSkb2NlwyIOglHaaMm7QH9qq5rDs7a6 hZskHFOT3I8wCYGDJ9CzUnXmtYkahACeco+qARIQITwxXI8XiYiMl2KdhNg0dmf99NVs yaOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784855449; x=1785460249; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HPYsD0/TeExFSSyQteQLZbxhX5u9ElKV6bb6GLLxXCE=; b=HmUIJMTsL/FO301ExmnvRJ+QmAqgrWLJdARcxFPE5zY7VKHNxxMOZlbdbUtFmFI1BW 3XxG2BgttXFTzR371zTsgkatVx3yQUuKieJD4mBRteRKGN2R0UE2yvggRYMFVnD3Wen3 9AWz7Kxasshb2rRuOfYiOJ7k3Tok4zbFZMREar/QbShst2KwFg1sO4fUjtMDGvgQ1cFA r10RkuyPaIPgLhniYoLILGtsbnQ16eFVT/J3ndwv/B2ihV89fdRKVj6XiWH+gAIbQ2d+ lrLYlCpK6nr9Ag9H3WYBhL+nPD9PE6D8BFAKwlTtoeE0pEG7TFcLyKtaYV/06spI/cR4 DiUg== X-Forwarded-Encrypted: i=1; AHgh+Rr8FGB2f1WE+lQ7d5hg834P9nN+sWEUaDc/TJg4eM3IdqAcwNMnZnnflbrucbMYw3lVSbLp9hOKqS1GZyM=@vger.kernel.org X-Gm-Message-State: AOJu0YxHUniLJzkN7hdt/O5NHnuC8zbS6JvED9o5OyH7dJg86IF7D6ii wWn1TsXCBXtlFrCqehNYlIDF6dvaw94ekNfj1q8ZvbLefcBKShBGDTGhoy3yng3yEIpK0nN/pia XGLo7dUastKUb0SyUTkZq4NWIFYqruoHwlVWwHKK9EUYjrEzZQfb5anQkke9aqp5v7Iw= X-Gm-Gg: AR+sD10pQxcu/d8/ChSZkbzu+wWRZW+UWgEm1MeuSYOsd0GzTIClV3YRdGSWHJs+uqg MciKXfw2SriWrdspmQG91SgZDUvJNh9zklZjGCOV2/eOGxDfkQnmKS0vqiuX4uFt+agyVQHAdk4 33a+/9TlNeybUUMWmMO1ukEAVvC7P2ulVjexsJilgzIP4o6SBnHpylXZBG/dBn7Yz5P4rhZSYa5 hcrOl7kHagw2p1ohFmKPpPpvtv0BmsUReT20faIIqh9m3Wt2D3NOf0vQEzQJglY81+Uk0cuBChM 62wBywl+tt+JQYYV92ykkgh9gyzTIyk3J+RBcnkai7VxqOKGaHeXipCz/nw3ZkzD3eWjJ42xr4i HWiU8XR9963anWgGL3HMJlvPQdZ1kLze+pSPtQ3Izgi8= X-Received: by 2002:a17:902:cece:b0:2c0:e5ee:f55e with SMTP id d9443c01a7336-2cfa6a4b3dbmr64006285ad.7.1784855449135; Thu, 23 Jul 2026 18:10:49 -0700 (PDT) X-Received: by 2002:a17:902:cece:b0:2c0:e5ee:f55e with SMTP id d9443c01a7336-2cfa6a4b3dbmr64006015ad.7.1784855448680; Thu, 23 Jul 2026 18:10:48 -0700 (PDT) Received: from QCOM-aGQu4IUr3Y (i-global052.qualcomm.com. [199.106.103.52]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147e081978sm22045229eec.24.2026.07.23.18.10.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 18:10:48 -0700 (PDT) Date: Fri, 24 Jul 2026 09:10:43 +0800 From: Shawn Guo To: Manivannan Sadhasivam Cc: alim.akhtar@samsung.com, avri.altman@sandisk.com, bvanassche@acm.org, James.Bottomley@hansenpartnership.com, martin.petersen@oracle.com, peter.wang@mediatek.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] Revert "scsi: ufs: core: Remove unnecessary block I/O quiesce for clock scaling" Message-ID: References: <20260723124733.341789-1-manivannan.sadhasivam@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260723124733.341789-1-manivannan.sadhasivam@oss.qualcomm.com> X-Authority-Analysis: v=2.4 cv=e742j6p/ c=1 sm=1 tr=0 ts=6a62bb9a cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=b9+bayejhc3NMeqCNyeLQQ==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=PaeuHutDJpf9VW2w4SkA:9 a=CjuIK1q_8ugA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: efHEk7VllEV29QFmT7igt_Nm56lqwZHx X-Proofpoint-GUID: efHEk7VllEV29QFmT7igt_Nm56lqwZHx X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI0MDAwNyBTYWx0ZWRfX0ZOl/Pw7YRVP OBK2IDQCGL7VLM1sTWIffM+Gyj6oWrlbwxqgSi052mvWJ2J1amGxYBhc0LRRD3iMiU5jVRTPa7J ULbN6hul5kz1M4dqQFIcSDvFAPMahEw= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI0MDAwNyBTYWx0ZWRfXzOffXS+3BSqQ PkwXkX8LtNqq3jmE4OC8dEYaxfMycwVt34bko05JDCah+3iTfLSuZpU3zqPW7tIn2OTAzUfaYrW j/8q3rdkIVbXmHlLu+QuYxepu4S2Ah3LplELFWS5rrCh0kkNMi9WWh7rdfFS68nz1ZCI61L4BC7 99tclJJzTICW0afSUx6Fvm5UwWuFpXqYbOaQ0+wm241iZKU0QRKFcxUfMOzWC/p9chriW0uLP3A pDAR6VoJrYMVOaOOiojtJNQsQZb3rW6fOKYxz27MUlCEhh7ykSCNj+wt7NpBPzVjRuyWhVjUzyg AHIRR4/woSRdKwk7vSGI7WJoVRGqc+/ReSQ1ZrQRxietDPPKYzw4PVBEqzHu2IxLmzyUzNUes81 fuHKikvxiEkULIkWQVIT5NrvS+iboPTZ8kPBZUWPxMGx/fKrUYWHDs9gQPDgmK3PmixR2geDG74 +HQtSSWEcDjXym13nOg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-23_07,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607240007 On Thu, Jul 23, 2026 at 02:47:33PM +0200, Manivannan Sadhasivam wrote: > This reverts commit 85b2b966285498e1b551ac85f02c79cd06c0cff0. > > Qcom UFS Host Controllers do not support scaling clocks when the traffic is > ongoing. But the offending commit removed the block I/O quiesce in the > clock scaling path, which causes below UFS failures during clock scaling: > > ufshcd-qcom 1d84000.ufshc: ufshcd_check_errors: saved_err 0x80 saved_uic_err 0x0 > ufshcd-qcom 1d84000.ufshc: ufshcd_err_handler started; HBA state eh_fatal; powered 1; shutting down 0; saved_err = 0x80; saved_uic_err = 0x0; force_reset = 0 > ufshcd-qcom 1d84000.ufshc: pwr ctrl cmd 0x2 with (MIBattribute 0x1571, mode 0x11) completion timeout > ufshcd-qcom 1d84000.ufshc: UFS Host state=3 > ufshcd-qcom 1d84000.ufshc: 7 outstanding reqs, tasks=0x0 > ufshcd-qcom 1d84000.ufshc: saved_err=0x80, saved_uic_err=0x0 > ufshcd-qcom 1d84000.ufshc: Device power mode=1, UIC link state=1 > ufshcd-qcom 1d84000.ufshc: PM in progress=0, sys. suspended=0 > ufshcd-qcom 1d84000.ufshc: Auto BKOPS=0, Host self-block=0 > ufshcd-qcom 1d84000.ufshc: Clk gate=1 > ufshcd-qcom 1d84000.ufshc: last_hibern8_exit_tstamp at 196451913 us, hibern8_exit_cnt=20 > ufshcd-qcom 1d84000.ufshc: error handling flags=0x0, req. abort count=0 > ufshcd-qcom 1d84000.ufshc: hba->ufs_version=0x300, Host capabilities=0x1587031f, caps=0x124f > ufshcd-qcom 1d84000.ufshc: quirks=0x0, dev. quirks=0x310c4 > ufshcd-qcom 1d84000.ufshc: UFS dev info: SAMSUNG KLUDG4UHDB-B2D1 rev 0400 > ufshcd-qcom 1d84000.ufshc: clk: core_clk, rate: 300000000 > ufshcd-qcom 1d84000.ufshc: clk: core_clk_unipro, rate: 300000000 > > Hence, revert the commit to bring back UFS on all Qcom platforms. > > Reported-by: Shawn Guo > Closes: https://lore.kernel.org/linux-scsi/al8YkXydXJQZrl_Y@QCOM-aGQu4IUr3Y > Signed-off-by: Manivannan Sadhasivam Tested-by: Shawn Guo # Qualcomm Nord SoC