mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Cc: Weimin Xiong <xiongwm2026@163.com>,
	catalin.marinas@arm.com, kernel-team@android.com,
	robin.clark@oss.qualcomm.com, joro@8bytes.org,
	robin.murphy@arm.com, linux-arm-msm@vger.kernel.org,
	iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v3] iommu/msm: Fix dangling list entry on probe failure
Date: Fri, 24 Jul 2026 13:33:37 +0100	[thread overview]
Message-ID: <amNboRxbKIoi17eK@willie-the-truck> (raw)
In-Reply-To: <20260723164944.hglmw7kgbikfgtcx@hu-mojha-hyd.qualcomm.com>

On Thu, Jul 23, 2026 at 10:19:44PM +0530, Mukesh Ojha wrote:
> On Wed, Jul 22, 2026 at 10:39:34PM +0100, Will Deacon wrote:
> > On Thu, 16 Jul 2026 16:53:12 +0800, Weimin Xiong wrote:
> > > Move the list_add() call to the end of msm_iommu_probe() instead of
> > > adding cleanup paths, which avoids the dangling list entry problem
> > > entirely (suggested by Mukesh Ojha).
> > > 
> > > This approach simplifies the code by ensuring the iommu device is
> > > never added to the global list until after all potential failure
> > > points have passed.
> > > 
> > > [...]
> > 
> > Applied to iommu (qualcomm/msm), thanks!
> > 
> > [1/1] iommu/msm: Fix dangling list entry on probe failure
> >       https://git.kernel.org/iommu/c/6bea37b176b8
> 
> Will,
> 
> By mistake you have taken the wrong one; it should be v2, not v3 that
> should be picked. Sorry for the confusion.

Damn, so close!

I had already realised I wanted the v2, so I'd flagged that to be applied
and marked the v3 as "read". I then carefully passed the message-id of
v2 to my wrapper script around b4...

... which invokes b4 with the '-c' option, causing it to check for newer
revisions. D'oh!

I think I'll just revert the v3 and try again with the v2.

Will

  reply	other threads:[~2026-07-24 12:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16  1:32 [PATCH v2] iommu/msm: unwind probe state on registration failure Weimin Xiong
2026-07-16  7:27 ` Mukesh Ojha
2026-07-16  8:53 ` [PATCH v3] iommu/msm: Fix dangling list entry on probe failure Weimin Xiong
2026-07-16  9:42   ` Konrad Dybcio
2026-07-16 12:05     ` Robin Murphy
2026-07-16 12:19       ` Mukesh Ojha
2026-07-22 21:39   ` Will Deacon
2026-07-23 16:49     ` Mukesh Ojha
2026-07-24 12:33       ` Will Deacon [this message]
2026-07-24 13:02         ` Will Deacon
2026-07-16 12:26 ` [PATCH v2] iommu/msm: unwind probe state on registration failure Mukesh Ojha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amNboRxbKIoi17eK@willie-the-truck \
    --to=will@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=kernel-team@android.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mukesh.ojha@oss.qualcomm.com \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=robin.murphy@arm.com \
    --cc=stable@vger.kernel.org \
    --cc=xiongwm2026@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®