From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1E2031960B for ; Fri, 24 Jul 2026 18:41:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784918464; cv=none; b=FpTrBmgQ3rf85qaM+k1cujdKZ0Ksprv+933ApdQYTGYG4VXKKfPiv3RxTbJfmOpstQV4kcWZypcQg+sTSfdPFmF2WeFTBogjUlEv3X1wxzscu+BGcZaaIcRNiHaaFUfIPT2nCh7KBNyXbAX4lq48FjtPeYjgXBYu1J6BH7svrvE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784918464; c=relaxed/simple; bh=AbqBLWv6eHA19RKDwn823OvccLgVBlxq+9onD+gI5t4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qVheymu3AQ2+eb2LixrYUT3UgoErSZBbcEXNWDAt+kEBoi+2ifA2POrkT8+gg4nS/61GTYEJFy5RffQ3TDUaefrkTZ5O7F7c83FBNrLn9tPcqIu+NyCCrjvyFCfAT/xOGJgPu2igLZLJBMEiF8cOW219Eryn1XCPw58qJodKgag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=EzExRZDW; arc=none smtp.client-ip=209.85.160.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="EzExRZDW" Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-51c2149571dso6976741cf.3 for ; Fri, 24 Jul 2026 11:41:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1784918460; x=1785523260; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=t1qXGBunFwcH0vasyDsq+hrXxoqTsrx29FgrXHzj3JQ=; b=EzExRZDWB9dyOjG821yV9ATGV2Q1A3TOQNmcGt3rbDkB6BLMjIR9u6EUn2rgOdDAQd 4AlAhnheHEilgZj3oP1ArM4SJrt3yvwLJ+bFE+dMmFJ3+qLThHKAsbEEynyNM6H3p4qL VgHjRBFPyYaSK/4xcMKLcJtX4/jiB566P/6WWmnL6oY+/ckaqY+UM4X9WTFvaSA+/Gbf 0mrFj3/bFuxZ6dCEpKd+ISNtkMYSuaEkeYtFl7+vEfiJt34ZEy/sd8AdqSCw9m6dGaOU iQdzX129mTc20mq/g1H2wVP81nvU+uuf6M5ZL/tEC6NoJ1oWoq8sTyq0tFDB0x2MLY5p B8JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784918460; x=1785523260; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=t1qXGBunFwcH0vasyDsq+hrXxoqTsrx29FgrXHzj3JQ=; b=e280ZGhXSP8SQEtStZ0lUJ4x8NC7rV9qouCGm4+HO02tk3/8PxDDhaEXzccI2CQU2H PtgZnvElcateY9gJ6LvC1jYbWSv21w8ATnDAt9e0Lrtwt012+oT2SJd/rU1sJUIFSX4L I5FV3aN9DLDaLtYs1aFZZOBAayWdsf6wJZL0nrp7ocpkbhWc7GtYvYqio/wqjukpgZY9 SnhwhPG0yXl6CyTnvyrz4YQsIn+sjDru8QXvz9J7RN3BLYHQDBjXj+myXMs0Ep9IoJEZ ie7Cb3DVymq/+PdJmS4rf5s6cla0h+EaQYi7DKaVDGBqIQK1N+qJqTQxuKPU5TdpW9EU Y0uw== X-Forwarded-Encrypted: i=1; AHgh+RoA1eo3t5ngKi7TJhu5AHEG72/7xtvve2hsMew+ZrFS5FUZrJ9xmBTucpIVabZMlzwIA1lLzMUABf+uzMU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4BmNBa0UvZyg+qrcMT9c+4H6WPwmwg15+7Vx3Gmbp0uWTU4E+ 5bcp6ddynip9jQ/htFrYrxCE6gsDhrGkaje0RFjYUohg/0/Q2z0zKBVhAmkzHtAPqou8tf09QlG Iia6N X-Gm-Gg: AR+sD116s9IfUGkC44lVStMeyixWpiR7eVtpa6qbAux1GHeqOYuJORuCsFPAXcxRKce vv5zwCDXNo/Oyiv3RUZhric73QsaPRRzWMiQOyz/ORVHlUKBuK/CMSn5kvY6LDpIfIbp2uxYykE oIaR5r0iJpU8E3tBsaA1eMkYBNXOkai706XZQ4U8CX2ARrCy25yQqG2r70Doew3//ha7460TeWh uYjwfImdXo4OSYJFl+IKWn0nWOwFJENz/CUHkynylacy+gkDms3o0ADY2kLVof3Sikx4BQoB6V/ 7NOCli56PSH+m+uctmBwp3AuOSwWXEd41NOBv2Q8o7kRLPHkJJn5Dvynz3qLLOAfGBpkWC0XN7s lKMtF0EQJ16Adose9UqlJd+2ljvT21+/vO5rXIovsajvkddY0giohL/g9OEW5fwo1+BSRMCd4po U3 X-Received: by 2002:a05:622a:c08:b0:51b:f40b:2fac with SMTP id d75a77b69052e-5283df4fea9mr83122981cf.50.1784918460467; Fri, 24 Jul 2026 11:41:00 -0700 (PDT) Received: from localhost ([2603:7001:f100:500:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-907e854e497sm4176346d6.11.2026.07.24.11.40.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 11:40:59 -0700 (PDT) Date: Fri, 24 Jul 2026 14:40:59 -0400 From: Johannes Weiner To: Hao Jia Cc: Yosry Ahmed , akpm@linux-foundation.org, tj@kernel.org, shakeel.butt@linux.dev, mhocko@kernel.org, mkoutny@suse.com, nphamcs@gmail.com, chengming.zhou@linux.dev, muchun.song@linux.dev, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Hao Jia Subject: Re: [PATCH v2 2/2] mm/zswap: Support batch writeback in shrink_memcg() Message-ID: References: <20260717085151.22822-1-jiahao.kernel@gmail.com> <20260717085151.22822-3-jiahao.kernel@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Jul 24, 2026 at 06:20:50PM +0800, Hao Jia wrote: > > > On 2026/7/24 00:39, Yosry Ahmed wrote: > > On Thu, Jul 23, 2026 at 6:55 AM Johannes Weiner wrote: > >> > >> On Wed, Jul 22, 2026 at 09:52:18PM -0700, Yosry Ahmed wrote: > >>> On Wed, Jul 22, 2026 at 7:27 PM Johannes Weiner wrote: > >>>> > >>>> On Fri, Jul 17, 2026 at 04:51:51PM +0800, Hao Jia wrote: > >>>>> @@ -1369,7 +1402,7 @@ static void shrink_worker(struct work_struct *w) > >>>>> goto resched; > >>>>> } > >>>>> > >>>>> - ret = shrink_memcg(memcg); > >>>>> + ret = shrink_memcg(memcg, NR_ZSWAP_WB_BATCH); > >>>>> /* drop the extra reference */ > >>>>> mem_cgroup_put(memcg); > >>>>> > >>>>> @@ -1493,7 +1526,7 @@ bool zswap_store(struct folio *folio) > >>>>> objcg = get_obj_cgroup_from_folio(folio); > >>>>> if (objcg && !obj_cgroup_may_zswap(objcg)) { > >>>>> memcg = get_mem_cgroup_from_objcg(objcg); > >>>>> - if (shrink_memcg(memcg)) { > >>>>> + if (shrink_memcg(memcg, 1)) { > >>>> > >>>> Why 64 for the global limit but only 1 for the cgroup limit? That > >>>> seems arbitrary in multiple ways. > >>> > >>> I suggested that we keep the writeback here without batching and do > >>> that change separately, mainly out of abundance of caution as > >>> writeback is done synchronously here so the extra latency could be > >>> problematic. I think we probably want to measure the performance > >>> impact of that separately. > >>> > >>> That being said, this path is potentially too expensive anyway due to > >>> the flush, but I would rather we do some basic measurements before > >>> batching here. > >>> > >>> What do you think? > >> > >> It's not an unknown, right? We know this works for direct reclaimers, > >> cgroup limit reclaim e.g., and what the latency implications are. > >> > >> Because of how reclaim works, we also know it'll call zswap_store() in > >> batches of SWAP_CLUSTER_MAX. If we don't batch here, they're likely to > >> each call shrink_memcg() once we're at the limit - while still risking > >> rejections due to compressibility differences. > >> > >> My worry is that if we start with an inconsistency, we'll be stuck > >> with it for a long time. > >> > >> I'd rather start with the clean, consistent version. Dial it back only > >> if we have data to justfiy the complication that we can put into a > >> comment and the changelog that outlines why exactly it's different. > > > > I am fine with doing that and basically always using NR_ZSWAP_WB_BATCH > > as the batch size in shrink_memcg(), but I would be more comfortable > > if we did some sanity testing. > > > > Hao, would you be able to do some smoke testing with NR_ZSWAP_WB_BATCH > > used for all paths, and memory.zswap.max set in a way that induces > > writeback? You can probably set memory.zswap.max to 1% of total memory > > instead of the global pool limit and rerun the same test. > > Building on Test Case 2, I set zswap.max=320M (~1% of total system > memory) and updated both invocation paths of shrink_memcg() to process > batches of 32 or 64. The resulting benchmark data is shown below. > (Note: Test Case 2 also sets max_pool_percent=1.) > > baseline-cgroup batch-all-32-cgroup > batch-all-64-cgroup > shrink_worker wakeups 7,238 766 367 > shrink_memcg calls 12,059,142 1,961,194 983,878 > written_back 28,277 301,157 327,997 > zswap_store calls 1,349,572 1,168,190 1,114,549 > store succeeded 492,861 521,315 459,246 > store rejected 856,712 646,875 655,303 > store reject rate ~63% ~55% ~58% > pool_limit_hit 510,130 50,096 57,715 > pswpout 884,989 948,032 983,300 > pswpin 1,251,268 1,638,668 1,878,453 Thanks for testing both! Looks like 32 shows the better matching with the reclaim batches than 64: it writes back less and swaps in less, while still having the improved rejection rate. It even rejects slightly less than 64, but that might be noise? Absolute stores win handily in any case - not sure if that's meaningful in your test design.