From: Andi Shyti <andi.shyti@kernel.org>
To: Linmao Li <lilinmao@kylinos.cn>
Cc: Troy Mitchell <troy.mitchell@linux.spacemit.com>,
Yixun Lan <dlan@kernel.org>, Alex Elder <elder@riscstar.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
stable@vger.kernel.org
Subject: Re: [PATCH v2] i2c: spacemit: request IRQ after controller initialization
Date: Sat, 25 Jul 2026 00:52:05 +0200 [thread overview]
Message-ID: <amPsP5o2wWqszbfU@zenone.zhora.eu> (raw)
In-Reply-To: <20260723021140.2293844-1-lilinmao@kylinos.cn>
Hi Linmao,
Please, next time don't send the v2 as a reply to v1, it makes
things confusing.
On Thu, Jul 23, 2026 at 10:11:40AM +0800, Linmao Li wrote:
> spacemit_i2c_probe() requests the IRQ before it enables the clocks, resets
> the controller and runs init_completion(). If an interrupt is already
> pending, the handler runs too early: it reads registers while the clocks
> are still off and calls complete() on an uninitialized completion. Request
> the IRQ after the controller and completion are initialized, but still
> before the adapter is registered.
>
> Fixes: 5ea558473fa3 ("i2c: spacemit: add support for SpacemiT K1 SoC")
> Cc: stable@vger.kernel.org # v6.15+
> Signed-off-by: Linmao Li <lilinmao@kylinos.cn>
> Reviewed-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> Reviewed-by: Alex Elder <elder@riscstar.com>
> ---
> v2:
> - add Cc: stable # v6.15+ as requested by Troy Mitchell
> - collect Reviewed-by from Troy Mitchell and Alex Elder
No need to send a v2 just to update the tag section.
Merged to i2c/i2c-fixes.
Thanks,
Andi
> drivers/i2c/busses/i2c-k1.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
prev parent reply other threads:[~2026-07-24 22:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 9:43 [PATCH] " Linmao Li
2026-07-22 12:15 ` Troy Mitchell
2026-07-22 12:20 ` Alex Elder
2026-07-23 2:11 ` [PATCH v2] " Linmao Li
2026-07-24 22:52 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amPsP5o2wWqszbfU@zenone.zhora.eu \
--to=andi.shyti@kernel.org \
--cc=dlan@kernel.org \
--cc=elder@riscstar.com \
--cc=lilinmao@kylinos.cn \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=spacemit@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=troy.mitchell@linux.spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®