From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC62E291864 for ; Sat, 25 Jul 2026 01:01:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784941297; cv=none; b=glQtra10l2HbKLnBjEr6a/94PRHMJx6D5iUllAINFwsRj6QJAPU7g54yu//2LXm9r6VwFVTZhpPA1UXvtAyqiU75l7qNa4H6ZA8Un6sMNM4GDjgfSRq4NTXHiqh0kk4DJyUcOprEUP4kNYcis3Kq++z3+PEWmGvsPR1C6tQ5Uo8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784941297; c=relaxed/simple; bh=t8fxi+lm5mZk3h0QtiD57w12TvuQE1dLio/9A3tild8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uPdRX9Fjn5AI2dOdGPMikoVWo75XkAYGmSlIfR8mbDMnoC5nblFB93p1mIY2eXxFA3f0ixYoNMKPFnwFucPe9ur1ufEDtZr1R71J1B2ZYEPOSSZFhx4ApaR5KLbmUjjyGAOcx2nQQGeXQte5VZEL/y9iQLjeglQdSizyK+P+mlM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Me7xOFFD; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Me7xOFFD" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-38dc4553f62so991307a91.0 for ; Fri, 24 Jul 2026 18:01:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784941294; x=1785546094; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=eL0z5oMGThYMtVLCeXNbkW2YxtHOpeXLeMPRqOdxPNo=; b=Me7xOFFDcTZmHUtjyjB/g4g/U8yE8riYwzxblXevm4BOxw8sYSkcnOLO4ytUaIHfec YUgwdmUDJ2zsgwKZ1RrVg8ZicO3jqpZq702RWIO88dG7JFXbjedCKWmIRYhc1Ipg2AqB l7LI49oHgcyIgucSpBjna57QhY6focxOx5WLhTIZextYldDwiPwPBBBLLzDssKzTt3mn OQLV57xxQ8afBZKMAJHopqCpqniXlrN0Q6IH8wYwznv9aDJCAIdolDP2Ziuz4UNcfvlZ O3I8unzIK2GMta15fvLiWeAF2Pzooe/hrC1AMKfMpSKh44owwsr90nXO3bdNOwoA99B4 o7gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784941294; x=1785546094; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=eL0z5oMGThYMtVLCeXNbkW2YxtHOpeXLeMPRqOdxPNo=; b=X2DbKA7vFAunaP5Z07/yzi4aZFOTANBWgOijL0RaBQA+OofLlF39dw57QZ9yaR8Z7t dBATeG+PPprFTvDQi0R77+Pc3+EqfvkA0nLt2TgXCRcG6Hwa7LF7HG40HJE6Z+SG1P8N L/OW8J/dtgQmUgOBw8cROIsWeP9ryPc7O1FCuES6oR64klxaF63ubU0fXE3ku+tCXAI1 nWJVVIaDpqydsuziJW3/EuQElPulgVTmowtRkVpTNgXYLzaJRKZfBV/8kwj4Hvpmpe5U Re/+7SYca7fcW1nIvIVmBnlWVtvzRpC+axJF61BQytKjjCgkXKUgINgIhH22YOnfZxiA s2BA== X-Forwarded-Encrypted: i=1; AHgh+Rqc5xyt7+rg6wWvPgWVzPeqdITYmvLR3vclOtQks+MqhgW/8gnJnXYcbQ4G6ptOx4Bno6/krXVyRpX92+k=@vger.kernel.org X-Gm-Message-State: AOJu0YzwBHPkt2sbIxZrXfKM4iGhpOsHFk9OF4vtBBjpzB916iVuD0Vm pK08bSTV8ECbkgfDzZSgSfBeKpaKYWQo4xyqCMYf/CS3nWxJJjGRhc+Z X-Gm-Gg: AR+sD117RAbc/tSVf2doPA7KRXlTjS6g7vXne6p9N2kVPBwwHZYiXUyOounEJv2Lbuv t+6XH7AqpKRK+s4DGLy7h5PAq1IrXa/eBoPBnoqxDf/lTjIBf9LMs73U0oQxH0NlpcprMIHlq3u s/0Ya51T4IKt6fzE9Lc7yva38bs1jLEmE6hZ7x9Wqx9vUsxmHRFUiaVLlSOWGs2imOfytSHkFew jJuHIMyVzIujIY+mw74tG0deuzJYKCfy4oymCWbBtKuXjMs5losxNC60VHmTrX4VCI8vkYKbpqC xZ4OE4sHtbCD9c7PEHkS3wkWJcatWnQZNciA2S7Cl1dVbl3+hhrT7cOYdodKvJk7SuXmBFLY0vq QVqxUdgtvAbSlt0D4Oz4R8hvISkWGz3va6bHiBoQKZJ9xRn3lrLkLLu42ia+Xmg== X-Received: by 2002:a17:90b:3bce:b0:38e:e0b:320d with SMTP id 98e67ed59e1d1-38f297812c8mr631281a91.41.1784941294392; Fri, 24 Jul 2026 18:01:34 -0700 (PDT) Received: from localhost ([2001:da8:7001:2000::1:5491]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03adb224sm2297589a91.2.2026.07.24.18.01.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 18:01:32 -0700 (PDT) Date: Sat, 25 Jul 2026 09:01:27 +0800 From: Inochi Amaoto To: Yixun Lan , Inochi Amaoto Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Yixun Lan , Longbin Li Subject: Re: [PATCH 1/2] riscv: dts: spacemit: Add enough deassert time for the PHY on PICO ITX Message-ID: References: <20260710063314.1030249-1-inochiama@gmail.com> <20260710223804-GKB106000@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260710223804-GKB106000@kernel.org> On Fri, Jul 10, 2026 at 10:38:04PM +0000, Yixun Lan wrote: > Hi Inochi, > > On 14:33 Fri 10 Jul , Inochi Amaoto wrote: > > RTL8211F require at least 50ms deassert to guarantee the register > > access, 10ms is only enough for the PHY reset. > > > IMO, it's kind of too trivial to split into two separate patches, > while duplicating the commit message > For backport, I suggest keeping two patches, so it can be backported in a more clear way Regards, Inochi > > Fixes: 74657a376960 ("riscv: dts: spacemit: Add ethernet device for K3") > If you agree to squash the patches, then should be fine to put both Fixes here > also suggest to adjust title to be more simple and explict > riscv: dts: spacemit: Increase deassert time for PHY RTL8211F > > > Signed-off-by: Inochi Amaoto > the fix looks good to me, so > Reviewed-by: Yixun Lan > > > --- > > arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts > > index 1eb5abbc61f9..b2a7d2d0d3a8 100644 > > --- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts > > +++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts > > @@ -200,7 +200,7 @@ phy0: phy@1 { > > reg = <1>; > > reset-gpios = <&gpio 0 15 GPIO_ACTIVE_LOW>; > > reset-assert-us = <10000>; > > - reset-deassert-us = <10000>; > > + reset-deassert-us = <50000>; > > }; > > }; > > }; > > -- > > 2.55.0 > > > > > > -- > Yixun Lan (dlan)