From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FB3D399D02 for ; Sat, 25 Jul 2026 08:59:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784969996; cv=none; b=fMdlPdjmPhNzY8rfbpFTjwOdu/eEdV0FbfYv2OL1qS/uDIi6DDl4MuwJW3ahg+lMik/K/76HgIAAo9L2Cjhgw5+EEhgp8xkuPCpzWBmlIgugnZZrYjP+/V0xiDtCFBviJhukGGL2ZwWy/I/GiZSUoQeFpqipLEXlIJlmb0yH49s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784969996; c=relaxed/simple; bh=5MwmaoaW95tVUWMj8ol9Sr1didcpfiPdV9xHydvh54I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A3dE6GmgtpymocDSRH1oz2kYQcKkeCkPukBke51ctcFQjfbDNtvrVYjIOlNmV9HIr+er2zrJ3EKO8ChsSprknfKwFWmRLSakI6uXuKcaKKm+CgPws7MmsVX4LODuMNi/lD0tamWlZdzg8ZE0Mstp+TBAP16PNownU140Tc3E9ws= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a5kjR6HN; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a5kjR6HN" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-848643382fcso1319113b3a.1 for ; Sat, 25 Jul 2026 01:59:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784969994; x=1785574794; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=UbQYEEJpzV2V7mwGYT8rwyfPdNnK/gZ6YuB02J3vSqU=; b=a5kjR6HNCva01Sg8o1NWgYXcC3U5ZnMsQborA16GL628ypZEm3HdMMpkpp253QvN9E XOS1IqCIfYI3saId60jWlGbybllaqhCcO20X5Qq0Dh4Fygvf814o0yFdL9OLCchUnmwj C68fJBgReiFZEaGOH0z5xAOju0JR136U4PZifad03yLezsBkmlvEftAp5I3BKwvrwCSo 78e1MnFe665tRf7TL9J2UZOtejx4E6CLUm7ewjQuiOkqAnuNMU+gsEWZn849aG1xm8aJ P5MzeuztOqRZecv3F4A8LwqqVYjYUFth8qCWliVxmyZFEDCgquZcGkCDkWABMgvf00v4 yjFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784969994; x=1785574794; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UbQYEEJpzV2V7mwGYT8rwyfPdNnK/gZ6YuB02J3vSqU=; b=SLQ30Do9hBo63K4g8t9RJJRphZ8eH62FxZJoV8S9B/e8pZSkgxSDk57f9S9unPw4B3 GvcGDPiQUhup+lg5AxPdE89fahHS/poUuSpb65Sscw//mSSJuO9Fg0nBykrWlqD36Oid wYbWDtbI6/DnyAclAT/iXQqqzT5gZiFE6lbioAGScTkvr/gUEtRpWnlef4SNWlEF7TET A6hlUUbEYsa0wKdDtxUjdLWRkujT8BuD+LhcKcDyst+FVRTj0/gr6rtjb4425B8vBNU9 Yin1tfN+CKDdwtMHfYF2yDTVqb4lDTEzyjAe1e39omHZTD0fpHZD35HoMqC1/nqtQU9C kmcA== X-Forwarded-Encrypted: i=1; AHgh+Rr1V5ptlUghImktp2FF28ss4Wr7Vgev9/CslUOEncr/1Y4HdNbzOaD3u9sRyN5y+jXEU7qZZ/zx1YmFr4c=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7oJXaH8Ic0J7L3OISrGlzbr/SV03FSIiBAb9mGKYCFLyV/MWn iPQ5hkGtz+LDuVIAWmFOTUxNyEx3vKWZvjQiT/5XFvM4ONXlRzfRxfJj X-Gm-Gg: AR+sD12jSs7Xbi68ySo/y47IrziA79CizvljdAWVXadLuMzz1OhZlv23JViJDSoVIlx mCu4Z8ssQz1arRMBR+9EQRaZ493wCAMoGIMw1luzGittHgr8AU/Y+jL06wbxoF+DXGTq3TIKTG5 ZYh+ylRGY9UswfvdXbIRON1acjn1To1sqUhlYnZdrdklltGatNOQ1id2PUiH7f4c5Iy/0TAym2U Du6C/zDb3Pft2DBx0c7PPIh+Nv9WNsmzNEykRQl5kZzIo8FgPw71F48TWhkKCz8w4t62TTuRxwZ j3H+PKuRRXCEQTtv12xUJPZUTDPuNFuk/KOntjL3PE/utCwzMcDqVnyvYtaB25YKRipqgbZjyBu TKtUqS5/mv4bFEspGpl3IH3pShwD8E4o9rpxp1J0S84dFd/SuR/aCFTK8kKILjrNgcjefL4+C X-Received: by 2002:a05:6a00:180c:b0:847:99b4:d011 with SMTP id d2e1a72fcca58-84e59554766mr1191339b3a.39.1784969994409; Sat, 25 Jul 2026 01:59:54 -0700 (PDT) Received: from localhost ([172.216.252.11]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e5325856dsm909382b3a.9.2026.07.25.01.59.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jul 2026 01:59:52 -0700 (PDT) Date: Sat, 25 Jul 2026 11:59:45 +0300 From: Dan Carpenter To: Mohit Mishra Cc: Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: sm750fb: Remove unused function sm750_enable_dma Message-ID: References: <20260725084649.106589-1-mishraloopmohit@gmail.com> <20260725084649.106589-2-mishraloopmohit@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260725084649.106589-2-mishraloopmohit@gmail.com> On Sat, Jul 25, 2026 at 02:16:49PM +0530, Mohit Mishra wrote: > diff --git a/drivers/staging/sm750fb/ddk750_power.c b/drivers/staging/sm750fb/ddk750_power.c > index d617f554f58d..e4bea8da1827 100644 > --- a/drivers/staging/sm750fb/ddk750_power.c > +++ b/drivers/staging/sm750fb/ddk750_power.c > @@ -90,19 +90,6 @@ void sm750_enable_2d_engine(unsigned int enable) > sm750_set_current_gate(gate); > } > > -void sm750_enable_dma(unsigned int enable) > -{ > - u32 gate; > - > - /* Enable DMA Gate */ > - gate = peek32(CURRENT_GATE); > - if (enable) > - gate |= CURRENT_GATE_DMA; > - else > - gate &= ~CURRENT_GATE_DMA; > - > - sm750_set_current_gate(gate); > -} > You need to delete the blank line afterwards as well otherwise there are two blank lines in a row and checkpatch.pl -f will complain: CHECK: Please don't use multiple blank lines #93: FILE: drivers/staging/sm750fb/ddk750_power.c:93: + + regards, dan carpenter