From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D527D2D9ED1 for ; Sat, 25 Jul 2026 22:51:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785019897; cv=none; b=UvzET95dg44Zgz1phC5nS82cRxTKkDVDXfyk/mc/UqtZsQlIFgW/Kl308eEmtiQHKDDOKkMmQTC/zk+/GdPx/PHm86u0RMEGZBljdyZ9lV9LQkxaaeKpYkdIOX78J1SX3kMJb21lw1di66zyYFxenN3GLQ2X8mLF+s3BLVplLFQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785019897; c=relaxed/simple; bh=OTMLoaXNmc0daefahm7Ve/Ya1YVd+Uzup/9wVhoFs/M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RKg/VrHXNW7bYZvFyxV95ueu6+Pugpa3eLsOI7K4w/0sfy6NQb86aVTIWOxWLFYc1y6FK7mnTRtbj/Usl6Gg8N7sw+XlzcYATKYLZRJGunXqMBYWFLXt9D0hzu6AREFBTIpHHFu0FbWsNkOypKAcNFZDZxoPuj4EqbjZQPXNBlc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ugm1IM1g; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ugm1IM1g" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-381c51fde6bso1681536a91.2 for ; Sat, 25 Jul 2026 15:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785019895; x=1785624695; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=e597SzF5n/PM9EkMnGuBBQh4XkUddaPspXC7fYxFtHE=; b=Ugm1IM1g3IdKVSV76YGowyNU5KXZU7ZFTU+lQhnVIQXSw7EF35SrRC5MudtxWAoJc+ Cw0JDVe5342OIOYuaWnEyczcucP1a6R1GsJu3kHbYfebgbLGkgF+Fs9rxsEI3j1+Q2Xv BP9xkpI1ZVvfE9lvRHV7zuBv0+nUgWnNIgc/FZhUfNKj5EUylcGi6IRCa0lZxT2m0aIc xWzA8OfJ6O5beLcEHmlLTAqYyS+71aA4pFIeWL0viP5bD3/I+MOUIGD9S3aqxwUti2tK RXYXX0UwetLRTgXdeBDnPnYL6qwsLt9kiKg6FyL5HWjHOW3YOglNxptIohnims3JANrQ w12A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785019895; x=1785624695; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=e597SzF5n/PM9EkMnGuBBQh4XkUddaPspXC7fYxFtHE=; b=FbRiWygBdxrykgKWtUy3uIGFLDoQf9DGn0PwupVcjvBhZ9Fp+FwCDaLz3y4hbWalqw jpIy7mNgYytnOxH44jgM0N7mTPjSc38K4NWw1bp6oh3FgMSm2LMO7LyI8tDFMWhGb/8Z hWiYxdtxl3PIwyWBNyUot4MRSCg8jDclX6/8Q1VvInrYmyfKA6/AyLIOhgmC/INrrrZ1 XQXeHzNDGkdGwMp/3qgZwUw9UXainmfioujFEfj/SAcBjkbS0zlNF+iQ2tl9aT6q0Syv 3/pfnnS65BUJOrF5rDZHEI9v5UmFJvlp8yTx5icwo4xfHOzlgRo4QAl4sghepPoCndC0 LRTA== X-Forwarded-Encrypted: i=1; AHgh+Rp4r/SNb14Ukg3IJmEZlAc2UdSOtvpXgttpUlSN0n2nIpMJHCKQ1cJ8aj7eips+D+PIgBc19t/lltZYZN4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3mANfLw9xhwgjxLn8ZesyBzT8wDa4IpzCsxuiDe7uiIUB7I0K glkQOcFg6QiRCYgAmhW8Bt3X55/Mo7eOs6ZPIAST4kGqB2x+ZcxVqtJO X-Gm-Gg: AR+sD13oSZ1KkNxLk0oQfmay2IT7aYOGeWpXOMKmt61ggjb30pAFoxcUK1g6Tkqtg/s b1Dv6RndYgciFKPF8RuaDZuAgnZyenhkCrak5RAhfn3UjkQY6q6upSR9oGuODRgUgklWeHcqPXv el1lb1pzPlgbnb7U8XxsbaYNoHhj77tZwoYVhOrLF1hGU9KTcvpdr71J1ELHWTwOHkZeFyNJX/0 ggn9Xy2AGMOUYrUm7vCvppGprlFkQ9BkU3tca8H8Dcs+nkWDpGKo+wUF7/CQmBN3guO60eGedOE gA5cmhff15V9tZbQO44xYXvV5XHU4n+KQJDC1EYmkXpxZzBjQZy+Jgg2uNAmQ7Z5PXeKOMeuR25 f4sB/VXyFoyZ9qAtnTkANb06M7cMEjeo8WGHPKSN3TgdRRdP+HJ8dZSTtrJP8I6n6DZvUS+kNf3 uP X-Received: by 2002:a17:90b:268f:b0:387:df8f:1408 with SMTP id 98e67ed59e1d1-38f2978b966mr3637050a91.41.1785019895045; Sat, 25 Jul 2026 15:51:35 -0700 (PDT) Received: from localhost ([2001:19f0:8000:3e6e:5400:6ff:fe38:3d01]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03b0eaa8sm3263879a91.8.2026.07.25.15.51.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jul 2026 15:51:34 -0700 (PDT) Date: Sun, 26 Jul 2026 06:51:28 +0800 From: Inochi Amaoto To: Andrew Lunn , Inochi Amaoto Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yixun Lan , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Yixun Lan , Longbin Li , E Shattow Subject: Re: [PATCH 1/2] riscv: dts: spacemit: Fix phy id check for the phy on pico-itx board Message-ID: References: <20260725005804.373698-1-inochiama@gmail.com> <20260725005804.373698-2-inochiama@gmail.com> <0d11de51-546a-42b6-80cb-8ca258389a17@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0d11de51-546a-42b6-80cb-8ca258389a17@lunn.ch> On Sat, Jul 25, 2026 at 05:57:42PM +0200, Andrew Lunn wrote: > On Sat, Jul 25, 2026 at 08:58:02AM +0800, Inochi Amaoto wrote: > > Current phy framework can not reinit the phy correctly, as it will > > assert the phy reset GPIO so the phy id can not be readed. Setting > > the phy id of board pico-itx manually so the phy id dectection can > > be skipped. > > > > Fixes: 74657a376960 ("riscv: dts: spacemit: Add ethernet device for K3") > > Reported-by: E Shattow > > Reported-by: Inochi Amaoto > > Closes: https://lore.kernel.org/netdev/20260712045233.800748-1-inochiama@gmail.com > > Signed-off-by: Inochi Amaoto > > Tested-by: E Shattow > > --- > > arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts > > index b2a7d2d0d3a8..b9d2de878f38 100644 > > --- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts > > +++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts > > @@ -196,7 +196,8 @@ ð0 { > > > > mdio { > > phy0: phy@1 { > > - compatible = "ethernet-phy-ieee802.3-c22"; > > + compatible = "ethernet-phy-id001c.c916", > > + "ethernet-phy-ieee802.3-c22"; > > There was a patch recently from one of the DT Maintainers removing the > -c22 compatible when there was a specific PHY ID. I did not look into > why. Does this pass all the binding tool checks? > Thanks for this mention, I have found the patch link. https://lore.kernel.org/netdev/20260323194803.GA1241974-robh@kernel.org/ It seems like this patch is not merge at now, but I am fine to send a new version for the incoming change. Regards, Inochi