From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from out-181.mta0.migadu.com (out-181.mta0.migadu.com [91.218.175.181])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA809398915
	for <linux-kernel@vger.kernel.org>; Sun,  2 Aug 2026 23:42:25 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.181
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1785714148; cv=none; b=G1ku0m/uI9h5MQdAS89zsghIYsUVu046MH6jCvRr7hQ5S6QQroUeTdrH1gdC1xJQWhfuzi5nBvarvtP2pGtdn9uS81sYsVbJzFc7lEZWQkp8VRJZr3Gy0/0aRDZJQe8zUHFnq+t2vzcRuckWwuEHxD6sIQcSM77ijAUJWRdUK1o=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1785714148; c=relaxed/simple;
	bh=sd9SUbTw/kUVxTTW5ejZ2iREqK4xdBRHSw3s4f0dPps=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=n5B1QaUUiqlkoNJvrbAxUnIUxtYEApTnWuCbav2CuAXenVBULEjjgTMvZG5WFOxZDTc7gzga9KyL01VM8vX3WpNF4DKJAMz8nkO5auk52Sp8SEPd7yWkqiBu9z0cDZSVuGPIZw3hlFlz5N4Rjrgwdk2d7iUk9A1dgz5sXhyS2uQ=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=lo/ICJfB; arc=none smtp.client-ip=91.218.175.181
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="lo/ICJfB"
Date: Mon, 3 Aug 2026 01:42:14 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1;
	t=1785714143;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=joJw4d3E8htE1b3XWkpkIGHoc2NvTJLUI126Vy8znbE=;
	b=lo/ICJfBC5AnuHwjCscpcIubIRtD+V6YUKlhzW9UkQKKsl/ikQQEXyMmd7gpIhLVPstJM8
	e50hqdO8p52n0ErFcYKQclP7MOe2NDp2w4dh8rkmqdOU6gucgBBjRN/6+VriZv4M/9HzZF
	bDVqsvHOLCsdnzLYSfG04fsNqfv5/64=
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers.
From: Thorsten Blum <thorsten.blum@linux.dev>
To: Borislav Petkov <bp@alien8.de>
Cc: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
	"Pratyush Yadav (Google)" <pratyush@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] x86/kaslr: Remove two redundant if checks
Message-ID: <am_V1qH4EktlKYo4@linux.dev>
References: <20260802093531.7165-2-thorsten.blum@linux.dev>
 <20260802172402.GBam99MtgAHg3a6TeG@fat_crate.local>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260802172402.GBam99MtgAHg3a6TeG@fat_crate.local>
X-Migadu-Flow: FLOW_OUT

On Sun, Aug 02, 2026 at 10:24:02AM -0700, Borislav Petkov wrote:
> On Sun, Aug 02, 2026 at 11:35:30AM +0200, Thorsten Blum wrote:
> > added the *output != random_addr check because add_identity_map() was
> > only needed when the physical address changed.
> 
> The check is there to update *output in case a new random address has been
> generated.
> 
> add_identity_map() was simply called to make sure that the new address is
> mapped in the page table.
> 
> Are you sure you understand the code you're touching?

Are you objecting to the reasoning in the commit message, or to removing
the if check itself?