From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f3.google.com (mail-pj2-f3.google.com [74.125.227.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C5D9390C9F for ; Mon, 27 Jul 2026 15:27:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785166035; cv=none; b=KAabINMl18+iZNmKjywsuylAvkuY/R/RbNiO56zIxzRV4Oc0+cVoIyXghM7hr2ZXOjsoIkAaO1IadJeVyziijhwSXj/h6wb6Vvv1ASbKwFpT7FrkqcZ95aHdlm6R2aG2vh7CNl8v06gkjkj4v7Q6ugt52JHepi9bGFVMauFAwQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785166035; c=relaxed/simple; bh=r1xueNEdriHwGLpNKX6pZV0hBnHxPWQp7+iPFAwMmi4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KfcuOE6cLnSnkjMiWQZIudkSe8d6pNkwpEL83NRymtvCbbENoJphA8Dpl7I5D1Iz1kSTNf4OHMyzjnmgkmfcmBN9eoupdB5x7X4isJJ6UZWoawcATik2zWjWRpUcP4/97p16jzEEYQme5tY94oiDLilQNuTesN0LMIQuMiKEoAU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HBrVel8N; arc=none smtp.client-ip=74.125.227.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HBrVel8N" Received: by mail-pj2-f3.google.com with SMTP id d9443c01a7336-2ccb0e85312so18230195ad.0 for ; Mon, 27 Jul 2026 08:27:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785166033; x=1785770833; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=FiseIjhWXpAg2kp14eHFJ/tqWX7K2DoK7xXRjIlIli8=; b=HBrVel8N1rOwQCkO0nruv4sq8VwtUPJO2JO1idIK7WJogGaMsqT+zb6GRfJc3BMNa7 bTltE8n6Wo/osFNMPdZP67C0c6n/KsSMLAvLgsWjmQTxkfqbCkfDVqfjrorrOr34CXks GDm/OgC3QufRnwB0j4V36w+EzNB69B/nRcdd9AF/D6M5buvCz+xgqKNYMbqAp6FxTTCD QGF+aNU+alh2iIOhRM5KC+kQo8a7YUAQXjk0JKsFdfIwH9EVhQGCZw2XnLN7BDiWnxC+ +ltTigj78qdZ7MqVsm2/utTKYgiRNsUNaXF3C2p7+wBt6jDssy2ILj2LaXsRbywyu1+Z bnhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785166033; x=1785770833; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FiseIjhWXpAg2kp14eHFJ/tqWX7K2DoK7xXRjIlIli8=; b=YdYTeM26A8Nfy+x7bqO4ezD5aesMtiaqF8x/CEDaDZZ1pg9RE6zMFW32WlnN0ac3o3 QkKLLe/dTVzLvR/y+U2cxLg579l2kD0NyNPb7s2M/Q6xqIBORuDaPUWyRDADz5cqXyfq mX+gS0DqBAPWZ4SZ3gxnReyuoyNLdRDjdRIMqU1Lew7G39wirMNANLA5BWLxW3UT2D2l yaCM1MqrHiBgYowqToWV7gGK9k5243S0KU8+7yYYD/XcPmeHXVx6RkyK3qf6HiqNnLQq hxk8BfZC5jZ0pWrENLIs60Zlalu1YfWQtgVK6TSDx5kS2/7k/Y8Y06cvs0hP4NbYqOUF uOvg== X-Forwarded-Encrypted: i=1; AHgh+RrK95pvaMU2lzusiMuYGdmQywFGiF6BLaMDyMKFwgB3QcHNC/G30DJjZ0/6D5uzDj8IpSq/8oYWRHImgQ8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9Db/hKMabNZxMfdCIF5h3KvYvIYhcjL56IPuGGzCyfKSU0otf 4SID7hTue6F0h0wwSpB54NurWIBPdKD7snt7N/uqbfpRnLifQJqmcird X-Gm-Gg: AR+sD13ajYif2l/QMv+NOECYFFRceMVZi97CV3bmhyqw6Qn3MHRWcnamnWL8OJbUO5t 65Or40S7NXM/W81/5I/07VFbMqO8ICHab5weju9vm3uMmmsOyAEOXaJbO97eouX4Zd4biUO/RgF x2MD7BF4At888EFHXlz/ESDiyKaE5ekNMpR93ShYH5zmEAJ4jXLvmQ+LYdHJYiSc+rC2aD6f1Pi M8WkkHHzkTu8ggUUFKgfaJCaSoMAm38HRfpvhydTvf5zhulYtvajRFbVrWdb5jyYLH+45BaRhWG Ili/CnMaijIoS4L9D2N96r+xhWl+UT+gHdCQOvxTJ9mgRprcnt8iIehueqcCoBAjvzHZImvK+Ah odpqLPwzvHrEYubFpEx2JftndFqDwJLzK6ABn23fxx+1TErbBqqgwLrsjyftsh2Tpjygb3J44FE WFjvYH5w== X-Received: by 2002:a17:903:2ec4:b0:2cc:f4d4:299f with SMTP id d9443c01a7336-2cfde85fe0bmr85023955ad.27.1785166032740; Mon, 27 Jul 2026 08:27:12 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:50::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cfde5e2b8esm37003525ad.31.2026.07.27.08.27.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 08:27:12 -0700 (PDT) Date: Mon, 27 Jul 2026 08:25:58 -0700 From: Stanislav Fomichev To: Breno Leitao Cc: sdf@fomichev.me, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Alexander Aring , Stefan Schmidt , Miquel Raynal , Remi Denis-Courmont , =?utf-8?B?UsOpbWk=?= Denis-Courmont , John Fastabend , Sabrina Dubroca , Shuah Khan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wpan@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@meta.com, Joe Damato Subject: Re: [PATCH net-next v3 6/7] tls: convert getsockopt to sockopt_t Message-ID: References: <20260727-getsockopt_phase4-v3-0-e89627544639@debian.org> <20260727-getsockopt_phase4-v3-6-e89627544639@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260727-getsockopt_phase4-v3-6-e89627544639@debian.org> On 07/27, Breno Leitao wrote: > Continue converting the proto-layer getsockopt callbacks to the sockopt_t > interface, converting do_tls_getsockopt() and its per-option helpers to > take a sockopt_t. > > The thin tls_getsockopt() wrapper keeps its __user signature for now: it > builds a user-backed sockopt_t with sockopt_init_user(), calls the helper, > and writes the returned length back to optlen. The helpers use > copy_to_iter() instead of copy_to_user(); the NULL optval check in the > TLS_TX/TLS_RX path is preserved by testing the iterator user buffer. > > No functional change. > > Reviewed-by: Sabrina Dubroca > Reviewed-by: Joe Damato > Signed-off-by: Breno Leitao Acked-by: Stanislav Fomichev