From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDE9C245020 for ; Mon, 27 Jul 2026 17:59:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785175166; cv=none; b=GUHjwcmt0PTnVuRGvWIK55+8A+wiCMbAvfWo9u9vRf75EktTv8MOGBDn7XjstPQlVCRTmsTqivkFEm0KT8wdb/OuSKZ6dSAdIWNP/36ui/f+zUYhdfiyQ6xEJZRdda6kaedF6QasfpIrUgZEGXXpu10VRU0rh5bPVaNs9p/LfAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785175166; c=relaxed/simple; bh=Cq2h//tjOBirhh+fwz99fTqwQXJmKrJ1A+2RAX+V9ho=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WPa4A+RrA/n3S5J60IPfBf76SiyE+LPoWOp2c89b34B8sdZLOiV4TtJ0KM57UG4geW4ZXuXqpIo09ib1VGSOm+lEcRhCvxrswTi3NPbhMB9Q2LTv8iuY6X3gYaAN7EtvWXoIYkiJHsX8u/ikXY1Egm3IYclEzlpPHqtQhZxqOII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RT7e8r+S; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=g/zPgTQa; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RT7e8r+S"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g/zPgTQa" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66RHbdmM002930 for ; Mon, 27 Jul 2026 17:59:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=9S3WjwQolNgmabnyJkRJH2WI IeIuQXY01SEDicZi6so=; b=RT7e8r+SwcMUzkBvuF1VRSl6HZmY3CQ9ikyuX81R WulVq4fxxRRoEcaSTZylKXuuUJPxQ8SpdbU230cUjUEBuM+swtw7tbbNOsgQyvHJ hIllz+DF8yEkHmZx/T6lmK8ZpiBj2F4rNvdKkXUoxFRbP0D/akHIdGa2/GqTEhqV cLbyv/qLo2y1eebIswKGo8UMJ1v2LIsSu6dU7HSTk/i6VSZb/ICvASjYNepna3VH 30btQ12KolvYUBMaoh3UzHo6vKLn1rME0j2+Oc58+dlguTvc95bWI3xJrHRJv/JU KIjaYuKIaPTvb8VrcwKfkGea3egUW9BBI06rWKwUBxEHQg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fpbp885u4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 27 Jul 2026 17:59:24 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cc73f47bdcso52393865ad.3 for ; Mon, 27 Jul 2026 10:59:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785175163; x=1785779963; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=9S3WjwQolNgmabnyJkRJH2WIIeIuQXY01SEDicZi6so=; b=g/zPgTQaOsI4C7zq2GjgyqX0hPAuW5jMi9+JcNh0v/WmjYD4roXgsra/sTxKH2P+Ha 5YScrHi205kMsu8GW57P62zpDU+XMmSL0Q88MJ/MntJ0gDmpC1DSktWU8Qo0lQtDUv2N e+4EYBX4TgHBEnoMuF+69YZuW9mtH3DQkiWyUMFydqYcfPum05YxorBnPy0lUZm/d9J5 3A8qY2Rwns3+VZ6vfx5b84Y18WIyCvyC/dluD7GeZVWOxhbNB8gWPc3kY5w8ZweVQH/W HW+CKDwefRD9TQSiOcFlVemOAcC3FYaMDrmo2opJH6Q+sME5WorvTw2/91fKE1ASeMJm hiCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785175163; x=1785779963; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9S3WjwQolNgmabnyJkRJH2WIIeIuQXY01SEDicZi6so=; b=krmw9tdo+47JA3S5vntOPwzy9XdqSW0hR0d/wxBvgt0SUCRt1T4erAJ2yGgVqumLjL RWfm06dM17D0+BCUTvNR2di7m22vBYbEy/CUWQ++msxAcWNDO2I4ccGiTNQN6qjdgPGB MMGZqMeIXfkRsvoo3G/c5TGC6EJ/RlBtmcFuk45cdAAIFMGlTiMvORBL850VXjIjcwM0 jNWg395aM8oNfPAOtB6g1+rAnI6BhuPBt4svIkAkzC8q8TKwoh+OZK19iKIrhtxArvR/ KE1eH4kUTnwax99MDK+pQBa5EfK5Vjfomb3mLGYDU41erdsMKcV2cREg/iTRyG1UXS5b deQA== X-Forwarded-Encrypted: i=1; AHgh+RoYGaKDBbSXU7uYWQRp5RNkwr0bDdE0Fvx7SzYcC/+Ybu2aqmmvw7QftUAI8TBndKXlqdhTzwTgmnSAbCk=@vger.kernel.org X-Gm-Message-State: AOJu0YyybMmVS2aMiSK3bL7mDrG1EYXwj3DYYQBBtW5v7hMPzD/w5zHE /6H2rsUxCb6fTQKESKosv5Ebfk9Itk6Nb8TZ86UmfIYgoqrmqOn0Rgs6XuK2T6Gjck/caPruRlR fQ+Worx1j7cY2FMEGbfFpvvqEuS7jZ2z8xXhN3C4z4WC8WKnkBVjykKOK9CA9eBF7jxM= X-Gm-Gg: AR+sD13hQKRUXcL8aQjFLZ9Nba0VVrci38dYjsZRUt/5/4v4em9OCBka7ol58nxfS41 K3BmnWWBd9JtM628fWFcphmT9Yzt9B5xhcAN4Jh+CH1p1X4ArC2rBXeqtz9dUXk4OXCF2BQ/tGo Ab6F6uEZxadP9SZyrVfAOS0m7E2Ibk7RMt6bGDnJ8nv+5kwH7BabtI8m6BE1YH3Hp654F51VbTw J51PhyJMOKjMRaioUeTFm8/fhJwFlGy+7p5/WPJcFiGN5MdSy7EO4I/07eX9RdOdM1xTOawExPo WDG7/MDTbWEVE1oj1L47oy6tTC1p4x3jVTZF9sjUvflvIFy77PkkWQscA/NRi3PIrwh3+/x5ucC Cl63rw+9O2r6feqNWirGg7iIyD09JjAUxGnjjbr8= X-Received: by 2002:a17:903:37cf:b0:2cf:a5da:705e with SMTP id d9443c01a7336-2d00f3ee5ebmr2770815ad.41.1785175163322; Mon, 27 Jul 2026 10:59:23 -0700 (PDT) X-Received: by 2002:a17:903:37cf:b0:2cf:a5da:705e with SMTP id d9443c01a7336-2d00f3ee5ebmr2770385ad.41.1785175162748; Mon, 27 Jul 2026 10:59:22 -0700 (PDT) Received: from 058f6326d650 (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-314bc3e127asm56467208eec.2.2026.07.27.10.59.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 10:59:22 -0700 (PDT) Date: Mon, 27 Jul 2026 17:59:20 +0000 From: Bjorn Andersson To: Joe Perches Cc: Dwaipayan Ray , Lukas Bulwahn , Jonathan Corbet , Shuah Khan , Andy Whitcroft , linux-arm-msm@vger.kernel.org, workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-next@kernel.org Subject: Re: [PATCH] checkpatch: Validate committer sign-off Message-ID: References: <20260724-checkpatch-committer-sob-v1-1-68550513106b@oss.qualcomm.com> <933506f1f210d3498d515d55266951e1914cbc9b.camel@perches.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <933506f1f210d3498d515d55266951e1914cbc9b.camel@perches.com> X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI3MDE2NiBTYWx0ZWRfXzJTLYuYJ1mcZ j0BJHEld2GpMmXEf4W2BK8J4GgMyliGRLHq/v1+jzBMIQrJMMHoCHjwgfkg2T9iFrgMCkQ+ZscO uX6iPJIXyB82WyvFpcxORxxo1HJdYaA= X-Proofpoint-GUID: 3uqDv_ydYWWnNAVRoD7oa4_t9iyyc8dB X-Proofpoint-ORIG-GUID: 3uqDv_ydYWWnNAVRoD7oa4_t9iyyc8dB X-Authority-Analysis: v=2.4 cv=KLJqylFo c=1 sm=1 tr=0 ts=6a679c7c cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=yzAoCp6uCkyargD1Up4A:9 a=CjuIK1q_8ugA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI3MDE2NiBTYWx0ZWRfX/NNN+HtdPWR9 bo0EqrUMau0mvIQaeSjrtGIE3fS6xPxciIBYtx5OY/X2vXslLEZvXZI7HuZiluIYBuIBAb8pUXX sJaSX1v4hCYQVJNQvWQbnfFMcsgG1O6flwBchllFG4U55QCAI29qq00BP8Zx8TKfXS0JxKeZio4 mJSRfqkj/rcyPR8CaDIxf44Zs0qEI8ZgjXtCLQhO9f/muw7KqLasvB1OHY7/aLfW3jnyen2eM75 T/GUnWwHPe8IQYFq+xRNEZFkpfivtECTe2kX8sReKjseea+DMOZRy98tb0Z0KMbuKKGy+Sr4I2J M8MwBmIn88fegEu+ec4B8vxMuNMJk+kTS2BHxjPrI8vBHOdKnHMvilVF3d+ty0gU+59bEdZcC1i ZBZzfmHV+2K9vJ5v6NBR9dWeBWKPKviwKlb2PoS3WHk37UktRRSeOGmIJRcZ8Oq9T8BNws4bpPG W4j9lcJ+mcb4AiMqKHw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-27_05,2026-07-24_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 suspectscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607270166 On Sat, Jul 25, 2026 at 03:47:34PM -0700, Joe Perches wrote: > On Fri, 2026-07-24 at 18:56 +0000, Bjorn Andersson wrote: > > ``` > > checkpatch validates the Signed-off-by trailers against the patch's > > author, but misses the opportunity to also validate the committer when > > run with --git. Maintainers therefor need third-party scripts for the > > final Signed-off-by check. > > I don't actually see that need as an issue for checkpatch. > > checkpatch is for patches, not things that are already committed. > Fair, this is only applicable for people managing/receiving/collecting patches - be it maintainers or people gathering patches and then resend them... I didn't dig deeper, but my LLM found 32 cases in the last 90 days where linux-next maintainers points out missing committer sobs, so it seems like making this check more conveniently accessible would help more than me. > If something like this is added, it should _only_ be used when > --git is on the command line. The 3rd hunk (that extracts commiter, sha1 and subject) only runs "if $(git)", and hence $committer (from $git_committers{$filename}) will be '', as such signoff_match_status($1, $committer) will not be evaluated, and the check will be skipped. Regards, Bjorn