From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D155A2BEFEE for ; Tue, 28 Jul 2026 05:49:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785217777; cv=none; b=B81vhDn6kkBwiQ/k2u0E+IKGAyJ93GxIvRk6h+bDq6TiwqKfLwDZymRcfAd1i60WLrN4YmSW4G5pj6+QcI8DN6ZH6oyFmuLaKCNeiPw6zJj4abnnabrcomdpErbdEVnrI03tvzZzI39UrpyIaCqb9Wxm2w4StH8WA4ylIrQZKRo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785217777; c=relaxed/simple; bh=MopVskLzHv5CirLNHcAfYYLsV7BbcnNeEYcg/xSev/s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QbA+KbYF8+hbOzITAXlaTD5nNLpUgRh+MtBsIlBbcbeXUE6EJeuc7KPk9andpzvOhc3vcrVk768c9VIty5q+sae2zv9RnlJQq+KuZoWr+00nS7uC1kUtIlReQdcGk0K0THYhe6hPJWFoQx0h3K8nh5Kj15GJTJQrs5alAj+TcJM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Jz5f/nPy; arc=none smtp.client-ip=95.215.58.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Jz5f/nPy" Date: Tue, 28 Jul 2026 07:49:23 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1785217772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ng9NIeTNRBL0J9elmdvvVcQb7px40vMN/udNLD2rYh0=; b=Jz5f/nPyZAqVunjimm6nywVlT0Ou7nH/mLZ+BTbA6zUmC8Jfbvs5MgnENl7fN02c3tS6In nc6N46CGcM7C+TCtqv6fS7jNO7A+zqbw/knM+b0gTZNBF7fVEDg0+MCEnbhVSCpoOF4FwU xiPS0uPdFUkXfiqmld7Coj5HUN2WtxI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Ard Biesheuvel , Nathan Chancellor , Nicolas Schier Cc: x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/4] x86/boot/compressed: Enable -Wunused and remove unused variables Message-ID: References: <20260624120300.590233-6-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260624120300.590233-6-thorsten.blum@linux.dev> X-Migadu-Flow: FLOW_OUT On Wed, Jun 24, 2026 at 02:02:54PM +0200, Thorsten Blum wrote: > This series marks potentially unused variables and functions as > __maybe_unused and removes truly unused ones. Patch 4 enables -Wunused, > matching the W=0 kernel defaults. With WERROR=y, the warnings failed as > follows: > > arch/x86/boot/compressed/acpi.c:25:1: error: ‘__efi_get_rsdp_addr’ defined but not used > arch/x86/boot/compressed/acpi.c:29:6: error: unused variable 'ret' > arch/x86/boot/compressed/acpi.c:57:15: error: unused variable 'nr_tables' > arch/x86/boot/compressed/efi.c:64:16: error: unused variable 'et' > arch/x86/boot/compressed/efi.c:136:6: error: unused variable 'ret' > arch/x86/boot/compressed/kaslr.c:600:13: error: unused variable ‘i’ > > Patch 2 also drops a redundant efi_get_system_table() call and uses the > existing efi_get_conf_table() error path. > > Changes in v2: > - Fix a kernel test robot issue by marking __efi_get_rsdp_addr() as > __maybe_unused: https://lore.kernel.org/r/202606240416.cXegPpiJ-lkp@intel.com/ > - v1: https://lore.kernel.org/r/20260621144116.224010-6-thorsten.blum@linux.dev/ > > Thorsten Blum (4): > x86/boot/compressed: Remove unused variables in EFI helpers > x86/boot/compressed: Clean up EFI RSDP lookup in efi_get_rsdp_addr() > x86/boot/compressed: Mark process_mem_region() index __maybe_unused > x86/boot/compressed: Enable -Wunused > > arch/x86/boot/compressed/Makefile | 3 +++ > arch/x86/boot/compressed/acpi.c | 18 ++++-------------- > arch/x86/boot/compressed/efi.c | 17 +++++------------ > arch/x86/boot/compressed/kaslr.c | 3 ++- > 4 files changed, 14 insertions(+), 27 deletions(-) > > > base-commit: 840ef6c78e6a2f694b578ecb9063241c992aaa9e Gentle ping. Thanks, Thorsten