From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F35563F65EA for ; Tue, 28 Jul 2026 08:22:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785226924; cv=none; b=GPWvk/mySE92fyuy6q8+YUfpXpat/rzpxCN4DmFk4Ozwr9t6ccyxeDIcNsLZuzAQ1ujrZGnjPK0Uo7AfFJVsig70N8fU8jXEi5vcXZbLBkGw+32C0zJcdN1wgQRL5E2ZlVdyB1TLS32rxhcoLF4m135Fw4wtVs8k3cnWkvVcNOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785226924; c=relaxed/simple; bh=743zbxPSWY9LXSLECHD52e5NJjTvQZ1kd9uEZiehS3g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R3adYFHFffmzf6jNRScXxAUxjVwpFmnOJrqiaixbSysSQGKTSLgv9PVlfEztUzn0yJlw3Np5dvpDxsxSkmbqPvOXgHozeyxb9RZfRAB14g1YAxSx+6wp8ESw4HQXjA1lV5gsx8lKZfUv0uRHLYdXj4QH37U6P4Tkb8tH/TsrG/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dpWMnOcN; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=LsrU8N9g; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dpWMnOcN"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="LsrU8N9g" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785226922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7L3Oa6yWKDj9Irs9koCNMMfNBAhfRI7uo2QmecVaVL8=; b=dpWMnOcNkTK9k0NLHWMLR5n+7Zi0DcFDTzLDUkrB7oI32TZzI4wjF9DZHZfdOasiXNppzd sKIa6FwUXfMffOTXAjMU8VqpDLgaJZBOzfmofGRWb7yUmgXERwCQz4H0YtGVxnxGmTyqmC +9btkJlH+RCmgzVQrpRd3h3LdB0i5F0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-epbyg1uYP96KNLoltFSPvQ-1; Tue, 28 Jul 2026 04:22:00 -0400 X-MC-Unique: epbyg1uYP96KNLoltFSPvQ-1 X-Mimecast-MFC-AGG-ID: epbyg1uYP96KNLoltFSPvQ_1785226919 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-4740be00302so2843812f8f.2 for ; Tue, 28 Jul 2026 01:22:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785226919; x=1785831719; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=7L3Oa6yWKDj9Irs9koCNMMfNBAhfRI7uo2QmecVaVL8=; b=LsrU8N9gqCZk+zHIOtFGKoH6NNNeOr1AQ8EvayQm6s6A6nwdTkmdQsLzSwOsWIAhmS uJoxLG+0WqVFFngZ3Kc17A7RYX/XVpWzf+iDNxjW/PQfJPRTQoLbcawcBkEdq8eucIY/ 5afp5KSwTdr/ee3AAHkPKYr3YH6L2yF2gwtk81EnL8h4piB3viJL0j8tZaaQ8LnykND8 cBwIKVGeMk3f4DmNPMDllDZ7sjqzXXgY9N48XzlEHQ8EN39ndB3iLhViPu4/uBmmMyWv yCk+ZHN3NAwd3HlVGGM0JkoJ5pM3LB7PlkeuTK+6XNE5vuSyTxZ2Dxon2MoCb4/quR6M 68wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785226919; x=1785831719; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7L3Oa6yWKDj9Irs9koCNMMfNBAhfRI7uo2QmecVaVL8=; b=Qr5+A/tGLC4qp/SPZcT8H3DHCumiu7al4f+at+9GC6t3xbs+1mIHTBdfDpwTitfFgj jCOg14kVf4++yoLoJOBRTzEk4qQ3lIxOUSE3xMBdWQCcA2KxRW10qgEJ89td7iGqkTxa Eah5oJzI67j6atD6pWfXVF3UPP/xtMJSfoVnw1o6bfN9cYTsvp8TrkYOgNgFSidF34u3 6uyzk0jG4mDxHzFGytPYV0lTx6XCLH3KwDjhzam7Ur5neriHWljb6+nZo9JEAkd4SMB6 wP9+Uvt8lHJ1hWMAzAXdG921pweGfMOfdOLb80sknDksfC2wdLZ1Ai7OzHc6YwL6Ly3v Jueg== X-Forwarded-Encrypted: i=1; AHgh+RpOXU4VCg6XcCnetTzcmcl2u9LP40XNAV4ZBqibAD/75fHBAy96GZoqZyTjd1qviPg82fLbF84DmIAnMDw=@vger.kernel.org X-Gm-Message-State: AOJu0YxGxhcu+oHq/d0Aocno6mNdp+QciSyyiQV4Q+oN1sHP6oGwg0ee /HeQLfD/bAO0LrqI7UJqjp5BnXcQg3f6h0u8RqTbfw+CNSY33MBR0UgSehnz700sovypgYfXscy g5yF3x5Dh/Rec9wj+sWEb2Puan/d+QrcymuA0dqyENKBrb/7DsJaQ3Em+U/a9xJKYbQ== X-Gm-Gg: AR+sD1331YI+QdpeJKSRdq7duxwq2cEOluQ86GX4bDK93YUwE++HVTTLAZE2WtJycQY bf9Omn+RVMTQgRGHXVlqEtORS7k8HAbOSk3NV2qjPFhG5cZnFg5hNghRTes1a+HqeYRoUnfwKKO fAw6wpR7KJdx8rbZo8+5jWlxyw8ZXgTBeMACz/JaqF/LqCRr5g+r+BXvtpaSxpwgVaMwMRQbSRj jrlI3vhAb/SpCS+sZTAKLPTBUIqFFHPp+FLaOw6AsLcg2pjivEik+d4YPK15hAf/daGE5AJfz/6 DoNIZ/9BKOnYLW/2oHbDgREbfOLMzu0iYoEv8IRbflXjgiOD6U9GVzqmGBIn2MIQHqEN3d2QgwU 6aMSc4LlDoiXJ5ZxIrK30E2TNiHhxlt+VtscFWBeiN9A= X-Received: by 2002:a05:6000:1889:b0:475:f0d1:eb56 with SMTP id ffacd0b85a97d-47fb1eabd10mr1428739f8f.49.1785226919040; Tue, 28 Jul 2026 01:21:59 -0700 (PDT) X-Received: by 2002:a05:6000:1889:b0:475:f0d1:eb56 with SMTP id ffacd0b85a97d-47fb1eabd10mr1428707f8f.49.1785226918560; Tue, 28 Jul 2026 01:21:58 -0700 (PDT) Received: from sgarzare-redhat (ip139-137-192-82.pool-bba.aruba.it. [82.192.137.139]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f939c1465sm41353599f8f.26.2026.07.28.01.21.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 01:21:57 -0700 (PDT) Date: Tue, 28 Jul 2026 10:21:52 +0200 From: Stefano Garzarella To: "Nguyen Dinh Phi [SG]" Cc: Michal Luczaj , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , syzbot+1b2c9c4a0f8708082678@syzkaller.appspotmail.com, virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vsock: use sock_error() to consume sk_err after connect timeout Message-ID: References: <20260719220103.684489-1-phind.uet@gmail.com> <78225425-1ca7-45fb-85cb-9e04f489e68f@gmail.com> <95cd0d4e-58c9-44ab-b94f-fcf57b88583b@rbox.co> <27412e44-ab4b-4dd3-9685-481875683860@gmail.com> <6b684c2f-1f98-43ea-84c9-9b6f162d5e9f@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <6b684c2f-1f98-43ea-84c9-9b6f162d5e9f@gmail.com> On Fri, Jul 24, 2026 at 03:34:23PM +0800, Nguyen Dinh Phi [SG] wrote: >On 24/7/26 05:43, Michal Luczaj wrote: >>On 7/23/26 12:26, Nguyen Dinh Phi [SG] wrote: >>>>>>>... >>>>>>>Yeah, we need to handle that part better, I think it's a leftover when >>>>>>>we generalized AF_VSOCK to support more transport than vmci. >>>>> >>>>>Speaking of leftovers, I have trouble understanding where does vsock set >>>>>sk_err on listener sockets anyway. If it doesn't, why vsock_accept() >>>>>checks for it? >>>> >>>>I can't also see where it can be set TBH. Should we remove it ? >>> >>>I couldn't find it for listener side too. >> >>Removing sk_err handling from vsock_accept() solves the problem, right? >> >>thanks, >>Michal > >Yes, confirmed, removing sk_err checks from vsock_accept() does solve >the problem. Okay, so maybe better on going on this direction. WDYT? Stefano