From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.andi.de1.cc (mail.andi.de1.cc [178.238.236.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 011543A641F for ; Wed, 29 Jul 2026 06:44:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.238.236.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785307460; cv=none; b=EvOK72nCdDjTez9MZ+xVd6PJX2QaSJ73OqthIgDgD5XdagFdJVsa0y0ND4XWQrwBVObRjqFyHcsfQDgYNsUZwSbsbA5SBsGD/qtkou0Ur1hSlFOKo7G3eQtrVd1nuejVAj/ExN3f49q0cLBRTRfVNEL/DiFiC8y/EQ9CJfKDIoc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785307460; c=relaxed/simple; bh=CundQ0eQTuHB/si51CX54FEPvo8E20UBoFa/m2kIXFE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jrXhEDOdmTXa49+bmlEPiIiI8DsT1JK9JgxrmMIuEKv9Qly+l2p2AO3966S/ey8azS/os5GXQbOXxnp0lwhR/bUyc+qqK3yzRhpzoVaCuQsJTK72uXX6TLgwW8/20TaVNqvbGZeUPma2ZPHOkjcvAmzE6FDECKUijnOhzR6anxI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info; spf=pass smtp.mailfrom=kemnade.info; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b=SA3MOJpC; arc=none smtp.client-ip=178.238.236.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kemnade.info Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="SA3MOJpC" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=In-Reply-To:References:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description; bh=psW064IlC0vFDRsVkw4/kjQpCROVNjpBK1z0U0x10jc=; t=1785307459; x=1786517059; b=SA3MOJpCWtP16j5xRnLuqa75uhMON+Ks9QSeDQKv2XCzGmcyLFv27J9boxEeHr3NhlsuuYqXwGD KVJwPwWKTMQ8ybtHyFhJAsbxPuKtnDSvoAr/0vm48Bq6Urhr4fL6tXIIYN8K5VijKIPb74xTmXOUm SrVxN8N3Kc1gr4Siy+rgowbvIdMclBA+1oa1kBEciFmN5SomQyppN3mEmXb23fOJ4pr/PdpSXizlB l8uj04Cm3OTMyjwAe2RotgdQyBBtQiM9QJF7Iz3+qN6NFNVei2pszRrFDKz6sgrgd1LscuNu6VTmj dQAW6k/K8qWscU642KNPe+rDazNtsYQhgkXg==; Date: Tue, 28 Jul 2026 20:43:21 +0200 From: Andreas Kemnade To: Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tomi Valkeinen Subject: Re: [PATCH v2] drm/omap: dsi: do not copy isr table Message-ID: References: <20260702-dsi-uaf-v2-1-dbb4aa0f0b8e@kemnade.info> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260702-dsi-uaf-v2-1-dbb4aa0f0b8e@kemnade.info> On Thu, Jul 02, 2026 at 05:27:11PM +0200, Andreas Kemnade wrote: > To te able to unregister stuff from isrs, the corresponding table was > copied. Nobody seems to unregister stuff that way, so it does not help. > But there are stack-allocated objects passed to these isrs giving chances > of UAF of these objects if irqs are unregistered while they are handled, > so better do not copy that table. > > Fixes: 4ae2ddddf44cd ("OMAP: DSS2: DSI: Add ISR support") > Signed-off-by: Andreas Kemnade a friendly ping... the corresponding fix in the old fb code already was accepted. Regards, Andreas > --- > If this gets backported, it should be re-checked that > no isr unregisters itself in older kernel versions`. > --- > Changes in v2: > - remove variable definition (Sashiko) > - Link to v1: https://patch.msgid.link/20260629-dsi-uaf-v1-1-a5e894f4e4d1@kemnade.info > > To: Tomi Valkeinen > To: Maarten Lankhorst > To: Maxime Ripard > To: Thomas Zimmermann > To: David Airlie > To: Simona Vetter > Cc: Tomi Valkeinen > Cc: dri-devel@lists.freedesktop.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 7 +------ > drivers/gpu/drm/omapdrm/dss/dsi.h | 2 -- > 2 files changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index 27fe7bca9e2c..70cfb779d6ae 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -455,15 +455,10 @@ static irqreturn_t omap_dsi_irq_handler(int irq, void *arg) > timer_delete(&dsi->te_timer); > #endif > > - /* make a copy and unlock, so that isrs can unregister > - * themselves */ > - memcpy(&dsi->isr_tables_copy, &dsi->isr_tables, > - sizeof(dsi->isr_tables)); > + dsi_handle_isrs(&dsi->isr_tables, irqstatus, vcstatus, ciostatus); > > spin_unlock(&dsi->irq_lock); > > - dsi_handle_isrs(&dsi->isr_tables_copy, irqstatus, vcstatus, ciostatus); > - > dsi_handle_irq_errors(dsi, irqstatus, vcstatus, ciostatus); > > dsi_collect_irq_stats(dsi, irqstatus, vcstatus, ciostatus); > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.h b/drivers/gpu/drm/omapdrm/dss/dsi.h > index 601707c0ecc4..2b25247ea893 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.h > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.h > @@ -379,8 +379,6 @@ struct dsi_data { > > spinlock_t irq_lock; > struct dsi_isr_tables isr_tables; > - /* space for a copy used by the interrupt handler */ > - struct dsi_isr_tables isr_tables_copy; > > int update_vc; > #ifdef DSI_PERF_MEASURE > > --- > base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482 > change-id: 20260629-dsi-uaf-71bfbf3553bf > > Best regards, > -- > Andreas Kemnade > >