From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.andi.de1.cc (mail.andi.de1.cc [178.238.236.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C07132B13A for ; Wed, 29 Jul 2026 06:43:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.238.236.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785307426; cv=none; b=gQsM4fDcp7O7sZqJjghKB+JxLG8WCnbYV0qZSVz2kTqm+rU3fvIGkM3jZdI4MU58+FM63BGCA0+BdfbSC+h5+tIcuNqd5pRn4vud7AlkRdFmJiID2lqfPhKrIEN8BbgLrJPvxLG3np+bv0LL6UQVnbR0zUeMkF6jImV29MXSqts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785307426; c=relaxed/simple; bh=AojpDcJ5jmKbNMEDeVXkwxf1vQycX1i+hF6zvdhRFl4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Bb+CjW22kEtLcqwf0cT2U6C5k/tXICAYeB6TqCxrcHZR8f0YVoc+klPiVfWW21Cht7Lw7XoFOEqCuFMDZM1Qbqx2OZVTU1xxwYOSAGoYyU7S//mhAPYXPFiKVEVlAUu6g6jFG34DC0q6hjlLOnn1YcN0NKRAJcLfSekdSNP+faU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info; spf=pass smtp.mailfrom=kemnade.info; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b=mUx6lflr; arc=none smtp.client-ip=178.238.236.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kemnade.info Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="mUx6lflr" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=In-Reply-To:References:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description; bh=0yYzMYBvw0NnZxtz9Xhm+IOuYSVx8LPey7+8rgI2dlI=; t=1785307425; x=1786517025; b=mUx6lflrI0bqxqCFX3Fm5I3KdUyadTwjjVFdkmZi479zhihdDz5d7bWFaTXaP16HJi3yqFCzrWX 2fsEqDPPVbjwcIWGm3QZQ7XNS5DJGKoMwmeAdoy4KNePD4bMgl/WDywhBokNUJWMbBoA0Zfz8XrIx UrO5PAk85jgF8h8riTEjf1cZSvQr97OKgIn7Dun1vGRYdVFZTTTd1zLH8kTW92e8jRhlAB3Ge2dG5 LzP9vdBfN4hM+Q99Gcas230bLlW3Y+MseWawh49JDVYqrPVIC0kxuGelLP39NATONKVkUHAxaUITz IqRQ90AhlWbutgrCZHCa7tnW74AeQrFGLzqA==; Date: Tue, 28 Jul 2026 20:04:01 +0200 From: Andreas Kemnade To: kr494167@gmail.com Cc: broonie@kernel.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] regulator: tps65185: handle gpiod_get_value_cansleep() error returns Message-ID: References: <20260724125858.75635-1-kr494167@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260724125858.75635-1-kr494167@gmail.com> On Fri, Jul 24, 2026 at 06:28:57PM +0530, kr494167@gmail.com wrote: > From: Surendra Singh Chouhan > > tps65185_vposneg_enable() evaluated: > if (gpiod_get_value_cansleep(data->pgood_gpio) != 1) > return -ETIMEDOUT; > > gpiod_get_value_cansleep() returns 1 if active, 0 if inactive, and a > negative error code (e.g. -EIO or -EINVAL) on failure. Evaluating != 1 > treats a negative error code as non-equal, swallowing GPIO read errors and > masking them as -ETIMEDOUT. > > Fix this by capturing the return value of gpiod_get_value_cansleep(). If > it returns a negative error code, propagate that error immediately; if > it returns 0 (inactive), return -ETIMEDOUT. > > Fixes: b0fc1e770194 ("regulator: Add TPS65185 driver") > Signed-off-by: Surendra Singh Chouhan Reviewed-by: Andreas Kemnade