From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8933147668A for ; Wed, 29 Jul 2026 11:37:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785325047; cv=none; b=ptBwbbDhi6YXAc3dh8POeceCifoFXx2K3kKPpfHfiX9WrTMn43tZsrgfJ6EMqylJxgOHPzqQ9YWYWVIAwMTp9he1Gj7N/6NjQ+WHWdegErI/MdQ5hVie2vyF2tyjmVWFBxi6W6QHUctyWGNhlnesbj/0eQRNNqTfFWFYWaRIqlw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785325047; c=relaxed/simple; bh=jX4ytLiDlHTnwLtKQDI8GK7zxpHUjDcs70Q2mGNIQzo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=N2zQpgFINVlWs2wNCtz2C2OU3w67AuH/0gGEPigNgL/poS1UEHrsGZasFxe89OcLsc6PP+JPeKUkv2Jj93M1x0fQU/8a9AVYVQvxbLGXFQbhhrKJcG2Jbyc4DoFoYCx2+zIi+lV0iyIqXZYz8xfwD3ncX+ZaNCyJnSshDpuhLW8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eIGCXOBa; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=P3MRLgyi; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eIGCXOBa"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="P3MRLgyi" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66TBWhtO1910483 for ; Wed, 29 Jul 2026 11:37:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=JuKTV+oT7PmTQiu/vwLbiWOH 3Hnm+6HCgD4PAqwboi4=; b=eIGCXOBaDq/Zp7sSl4VKuXuBoKeURK9h1aUx1Qdf WxYgF+TOi0SFUK3WUv0HFr8eROt7ET2YJE3RhAVVBI9c0Y4inDjpj2gtkXTmcAiO DSaa7US8bmg2Txje04V9JdOnh4lYwbXrf7+veFWnJU2kX3LP8SINp1M7DiEuVwd+ TiNYsL1mDBf5Mnto78xbwxEQOUwv2LwQ6uLO+S9lwLeRq/1/hZkVXMW8hnI/HH7l e77HEm1hY+J/GOItZeEKhTQaa38ieXVOPbc3WQGkK9y66Aebmr4pJ7z00pJSnF/q hPyf+IvN4B9k3GU3xrV2t+ogec+uLgypwtw3d5kl7tgWQw== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fqgr680qj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Jul 2026 11:37:25 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cb74d5db64eso899281a12.2 for ; Wed, 29 Jul 2026 04:37:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785325044; x=1785929844; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=JuKTV+oT7PmTQiu/vwLbiWOH3Hnm+6HCgD4PAqwboi4=; b=P3MRLgyiKvx/ky9o5xqdnWhr8yk96OGjl4ukIryEzpigZTuFtr0Nf7Sui7wWBzMGUL o71ioLaAx0s9XCc1Ee6VW3sDf4D5GODB6NPooyuWiUiOPmHjxMnVN0QKx3lXvyLA9vwV mOH8gPOm3nHXMq+1fjPUth8xB/odCiFKRwFAK3uLXR6nGcV+uMaxNpQKK4BOYrwkJyCx 1qGD1T+ISuONdQpeRxpSNsoqNiDq+oW2vmTDx8hWq7wMrut4iDpQ6yXv12KciuXyNf8I KV4AVBidQKqcRuaxUZThnoISB7Mw0/INvV3bwT+l8Js+HbhHHHYHQYpiU8Yv1Eg/XFSH Jwjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785325044; x=1785929844; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JuKTV+oT7PmTQiu/vwLbiWOH3Hnm+6HCgD4PAqwboi4=; b=cPmLXCzhFbW9vcNDyBgydwo9jPGJpaA4fboIRqXGIdtwHvjOpNQCMIdr76Z1QBczJO DIeX2O0uF48DncROESt6lWvGXnBk2/0cJ1Xc9Ui/BWfuA7rbB0Fribzq45SHkvKH+leT 5donZuixq2Ac0mJjapHE71SwGtvf9OBokChpWjg4QL6fhd41TTEpBKgkSMUl0bvuwyVQ OhJdRPW31u0IppIIZf2CkPAnmM1aFbXY8tSuGVbGbvClWns93eNWrVRhoveALnUdhAdb 4S2/k9I/iSLEjFj/WUtJqJyIq7uGDttSJGVkgfL+UQP4LCwqnh7f3Ea3wkwKUHM5nxbg dd8w== X-Forwarded-Encrypted: i=1; AHgh+RooJxa3fV3uA02sfHzlKsCQpxCPzsADlWauOjm/JA7OrWo8k2C6yIxGMq5NWuYa+FAPEWf5/rfPRM8a+rQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1/VpSx4s8luD5tTFKapOWIiiP8Ehl++pNEcFgydeHDwocpiHz 3Q2efFIQsxtuM0tGo2JpR9q24yb7qp5VhEdN0pJ5S5jZvFLBPCPa7ulxOiT5YCLRcCsgGf+/zqR CnCVQ8zFx0Gc4vKn+NIxv2CUg2iAl6Ob5zZ3qblTgzOlU3ePhuXjDgPT4jCppWE5Isc4= X-Gm-Gg: AR+sD129rBMfBSPiUT86qV5IBFhg3gmvFlRAEWwJQjFkEFQiVRTQodB3OQOos1+bEs5 eUdAGTbPvM96YTD4G4wcP43wftCXqAKIZHeq15BA5GwAUObU70VSnaZnaQOKNQ9PGVVvb3PW5jZ pBEu43fH7zoFaLAUJjMjPC3VjEkeBXghTC2ET9Io1q8FsUqzBxdvTO2LOibPBSyeB+iVi7RsSof yNTXBFlIuGxIlaGQfau2evDzpKCEwW8FS5KOC0bB3oRF/mUyQLx1oX90+as+g3nVgKF1w2xkGVu qLhaaUyM0MvYD8RDcM2YJZsUXRe/XiQsmTXEizE/5mg3/PPSgBt9hODEBloNWJE1/twTD2jA60O AKUPgY3ApgmuAmNuLu+52/7ifcg== X-Received: by 2002:a17:90b:2701:b0:36b:bec8:94c5 with SMTP id 98e67ed59e1d1-38f6a4585e5mr6625875a91.10.1785325044116; Wed, 29 Jul 2026 04:37:24 -0700 (PDT) X-Received: by 2002:a17:90b:2701:b0:36b:bec8:94c5 with SMTP id 98e67ed59e1d1-38f6a4585e5mr6625838a91.10.1785325043665; Wed, 29 Jul 2026 04:37:23 -0700 (PDT) Received: from hu-mdsor-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31504db2c4csm9199730eec.28.2026.07.29.04.37.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 04:37:23 -0700 (PDT) Date: Wed, 29 Jul 2026 17:07:13 +0530 From: Mohit Dsor To: Krzysztof Kozlowski Cc: Sunyun Yang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, venkata.valluru@oss.qualcomm.com, Jessica Zhang , Mohit Dsor Subject: Re: [PATCH v8 1/2] dt-bindings: bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver Message-ID: References: <20260728-lt9611c-v7-v8-0-bda216bfaf37@oss.qualcomm.com> <20260728-lt9611c-v7-v8-1-bda216bfaf37@oss.qualcomm.com> <114159dd-0271-4d15-b07d-20fc1e28ee6d@kernel.org> <20260729-truthful-cinnamon-giraffe-f250d6@quoll> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260729-truthful-cinnamon-giraffe-f250d6@quoll> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI5MDA5NiBTYWx0ZWRfXzEhK/aLHySxI Btiy9QSe9f0wafgJfNTjpg6dGHbZnZVgMnS9/Re/QihPbDNNIWPBwDp4yM7iNZP3U1pVbGkI3wM eEWlqsnrdVXWkEh3hBYI+PAhlLirLfgJXwNZ+1aBPrFSQViTE6WEA4n0bJgC9lroyJTme5wmSqC 2OT07yPcivsj4Bs1xCl6VGZubhfP36eaEr9lQh3YDsVhKlRv7ZJKS+N3dNn1IGaowyNvwZhHeT6 rCaDHKV0tcB8ple9jikzzXfWgjLUisB898yJOeusxEHMwL8rs6/dQuJrWxRMEQVlskzUXuPbenM 4iaX45oJ23yf/6z0v3Rd8ZUon+KagT9M1xpPRYVk1Tw3t2Dw4IehVrumymwS2vt+4q0DSBL0S2c fjVk51qGgfQbeJsCeF4VnUQt0mYvO17LTUTCeIfO67R/h82pzU+CwvM39fXfNarz3z/ialIoGEa 1LMwAdpSLQlMK1H24fw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI5MDA5NiBTYWx0ZWRfX8Ds9KuxO3ZJC vU74JtKwUAIufu5etIQVdU7bnQf4EL+uGqeaPQZl4TUKGROPC0e0auEgnqR4Y3dHUlHy9uHglCm U+zuUzQquG1nXeR+W5C3MXAeUxfKMTo= X-Authority-Analysis: v=2.4 cv=Cv2PtH4D c=1 sm=1 tr=0 ts=6a69e5f5 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=Kz8-B0t5AAAA:8 a=9bdzyRqNf_OfPh25cPwA:9 a=CjuIK1q_8ugA:10 a=3WC7DwWrALyhR5TkjVHa:22 a=RuZk68QooNbwfxovefhk:22 X-Proofpoint-ORIG-GUID: RktfyfXxOTeTaqjOFaMDcgxuO_VC2Ayx X-Proofpoint-GUID: RktfyfXxOTeTaqjOFaMDcgxuO_VC2Ayx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-29_04,2026-07-28_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 spamscore=0 priorityscore=1501 impostorscore=0 adultscore=0 clxscore=1015 suspectscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607290096 On Wed, Jul 29, 2026 at 08:37:42AM +0200, Krzysztof Kozlowski wrote: > On Wed, Jul 29, 2026 at 08:18:58AM +0200, Krzysztof Kozlowski wrote: > > On 28/07/2026 13:09, mohit.dsor@oss.qualcomm.com wrote: > > > From: Sunyun Yang > > > > > > LT9611C(EX/UXD) is an I2C-controlled chip that Receiver signal/dual port > > > mipi dsi and output hdmi, differences in hardware features: > > > - LT9611C: supports 1-port mipi dsi to hdmi 1.4 > > > - LT9611EX: supports 2-port mipi dsi to hdmi 1.4 > > > - LT9611UXD: supports 2-port mipi dsi to hdmi 1.4/2.0 > > > > > > Signed-off-by: Sunyun Yang > > > Signed-off-by: Mohit Dsor > > > --- > > > > NAK. You received review. Sending the same is wasting our time. > > Actually you ignored TWO independent reviews, so I will not waste time > on this patchset anymore. 1. >> So you need "if:then:" block disallowing port@1. >Ok, need to add in driver code? Will add this in v8. Sorry, I missed adding this in the bindings. I assumed a driver-side check would be sufficient, so I added the following validation in the driver: + if (lt9611c->dsi1_node && lt9611c->chip_type == CHIP_LT9611C) { + of_node_put(lt9611c->dsi1_node); + of_node_put(lt9611c->dsi0_node); + return dev_err_probe(dev, -EINVAL, + "LT9611C does not support dual DSI\n"); + } If I understand your suggestion correctly, it would be preferable to enforce this constraint in the DT bindings as well. let me know if this is correct approach for DT bindings: --- a/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml +++ b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml @@ -82,6 +82,16 @@ required: allOf: - $ref: /schemas/sound/dai-common.yaml# + - if: + properties: + compatible: + contains: + const: lontium,lt9611c + then: + properties: + ports: + properties: + port@1: false 2. These are some odd characters here. I guess this was in earlier versions as well.... I am sorry for this, I missed it. I will correct it in v9. > > Best regards, > Krzysztof >