From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DDF533DEFE for ; Wed, 29 Jul 2026 14:51:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785336679; cv=none; b=uSu1sWZtvw0lt049MWm+2l0p8b7xvG9YqFpv33vLbWzoroe7Lq/1ySSCElFMwA2oJml8a7+IZB1HDytFih2NOpoUhVkqjjskuRBpPmS7Fiqrqy+6NdU1dFdaKdyRCZEyAl9kgmrt5Y9c8HrEMhSFUQiblza38g3yMTmVI2DthtE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785336679; c=relaxed/simple; bh=PYDfl+F41hxq/6bv4+Ht5LZxugkjPCkp9xIdMHB4WZ4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WInkbmoOWlgsmaIFIu91/nMKMd//DmxZZ89Iye9zSjk3DWAwEYC/NTIHmITsXl4wGy4GHZeHrWHsqqhczs5orDiN6GAtX86mLtvY3XUYFSqLmevysJv7DseDNOZQDzhm2AtRQYsUPsdD24bJyZLBJ94F1t/zJvR/WaqJ5RsE2HI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=q+P97zgV; arc=none smtp.client-ip=209.85.210.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="q+P97zgV" Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-7eb787dec99so784750a34.0 for ; Wed, 29 Jul 2026 07:51:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785336675; x=1785941475; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=xHFMieRAasgbYmTSFjzwUgJo6vktMkwrcW3pgKwavBI=; b=q+P97zgV85/XuT0CsJDnZhZtKY85nDqY5wQN0sCdLcmnmhW6z3/Okro7WfBRCl0dDz DhE0DBNyj0HQgWb8SVDS7aZrf7Jbcj7a/ESUDzFw0TUKMNUYdJjn39VW31438+1yIlvg Vszj4yvBuQYJnH5fjx9doT9tm3KVzU6gj5JCYsRagGe+ZZnp3zeeHKaBB0iGkOOfKCqD iVimBw5RwP33sTF5d+vc3VGTCYFDRc78SR6s7+DxPI1zJ9SmLH8FjLMjg3Z7vAp7VmRN WkQ9VYi4v2SeGrzIYwpPss5MwociFUfp2+WZ5Y7gwWc0YUOwh/xjYTS7lKMpxMVKBXN8 DkLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785336675; x=1785941475; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xHFMieRAasgbYmTSFjzwUgJo6vktMkwrcW3pgKwavBI=; b=qQYsAZDVctfJD4Nfzh4isxp7fEaBVdp9+PUYhGmmms48zS1M9lVGxKJLZvmMZj6IxS f4hQLTWjQI+j1M5AoxfIui18kZbk41eCe/v2VD6xGrQ6i4xEKEt/m3t7fgHtFTYrFHRU lJBWteHIAWCYJybFFo10YtmrtQH5BRt2b2hnDolRh7kbOPKvhe+JI8E7MCSYy9rCvWjE JaJFnwcRSCeOf/homnBbu+63S8BO3kyEKxDS5pIOxmH9ceTDUAVxtPs/yhz7pCk2QTMx Ak16P6Uq/YWSbpFFOkAHMOCkxsFJUdGjkunvUK2bdeyFwybFF20/QATvjAiAXxGkW3pE 0CBQ== X-Forwarded-Encrypted: i=1; AHgh+RohiSoSXi/C+QHAYkWBromWPiHoxwHKyi2OOttY7ufig5kT6xk1DMhsKh2Qt28lxnsfwTQ5G1oN22FU0UM=@vger.kernel.org X-Gm-Message-State: AOJu0YxUnXXQKNvlOTK/ki9EKMoXupG9SYsIIWF/rpnt7wEnRt8fCTlE OPFExWbHD3rbfjPRzLRCVCGPhajk/QFo7Cv3PX0flMIeuIxEAKahB3bLwxx+pIv5 X-Gm-Gg: AR+sD11cuSjr17L3Nbpfyzj1j7LNeWUFAZqT0cX5kWUcme5Mc+8NjM/ZyxIaMvN3+CX CL6IItQK9FZ1s16Qd6Akwv50ydInEbxGUhvs9XQ/joVi3QJDbDrTJp393tk+Q63+E+FfToQG+hN NTyS+NGvaAfwFTLUxeCUnUL4VXQxUVTuKrqMR5a/pML/wQl+tf+FmKEGkcSh77r1rsHWZRZfWgv Zz5dk6bfkK4gBHvr7Dt9NgRvXeHgfyr8aHXMLnARWMvMbHagZwtnlGebDi0bc3/KK+YLMoTGQPa sUyXy4gDFZRsgRrE8pfpPGr+l1wMS+VXp6eyZLB8RD0YG5A0hgFArmb54TEZg2/i9oTIXHz1kRd 2Cn7ILXazenYo0vkJwsUepqaLCWSN30Kqqe1fG6Z9WwEsFH7V14H8oXmHaSszH9ENuv0A8JJmgM e4UOs7GeovnXOCXQ8BAeMCKOr+Ot+gkr+sdYuh4czMslZlpb4Yk6xkUOONc/l/a6IaO50TsXfwE OXY4MEXIG2kF9ALA8ICxcnidpeBfeevkH7vaR1VLQrlFPYq6L0cRgsjkgFPfjuFlHFB X-Received: by 2002:a05:6830:82e3:b0:7e9:ea28:4c1f with SMTP id 46e09a7af769-7efff0c0181mr4161623a34.8.1785336674711; Wed, 29 Jul 2026 07:51:14 -0700 (PDT) Received: from fedora-laptop ([172.245.82.59]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7f00d5f3aebsm2457915a34.9.2026.07.29.07.51.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 07:51:14 -0700 (PDT) Date: Wed, 29 Jul 2026 09:51:01 -0500 From: Ming Lei To: Caleb Sander Mateos Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] ublk: consistently use u16 for queue and tag numbers Message-ID: References: <20260729012951.3744582-1-csander@purestorage.com> <20260729012951.3744582-2-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260729012951.3744582-2-csander@purestorage.com> On Tue, Jul 28, 2026 at 07:29:46PM -0600, Caleb Sander Mateos wrote: > The u16 nr_hw_queues and queue_depth fields of the ublk UAPI struct > ublksrv_ctrl_dev_info constrain the number of queues and queue depth of > each ublk device. However, the ublk driver is a bit inconsistent with > the type it uses to represent these values, mixing u16 with int and > unsigned int. Change all queue number, queue depth, q_id, and tag > variables/fields to u16 to save some space. > > Signed-off-by: Caleb Sander Mateos Reviewed-by: Ming Lei Thanks, Ming