From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC8F939792E for ; Wed, 29 Jul 2026 15:14:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785338098; cv=none; b=jrZeh6vS7PHuozJ/kj8Mn7hocxetrdgw2U3u2wxDKQ/HG4JTaUFIHGFgNkb9017rKkpmsRcNOHUJesMUbrZcwR/yALtWjdLI3SLVAPwXjg2W8gq9EhSK3A2WReheil1biU4iwmXvtTDQTawOwjqvxbS+58Ut4HdXhcQa2f16Osw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785338098; c=relaxed/simple; bh=JCVcinsThvVIH6pBjhjm7FWTCthambnHPL3kOMzJnyo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P2BUlSeTCLE/EE6OCSM3cwKBRqE+VSUyxfPQ5TK8yeReMSK88w5MiFYuv8j0MggnO+7yl3Is5a3txJHkQxvlmg96pviWmqCnVrzIvVTky8BJOPzMcUGPYuZDNGdoYek8mAy5uFDJOr62CaK9MVDiuUKLdXk4smplMpQxApIWvWg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=OMnexOAU; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="OMnexOAU" Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-92e55b62640so63676685a.0 for ; Wed, 29 Jul 2026 08:14:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1785338096; x=1785942896; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=2v6EYAF/prndNnQMY9/VeGyA6EcrPV2/qkncXAHToaM=; b=OMnexOAUiQcgRvkWEnOmmnEXSwmvoXAN3uL6HiHWVwB5E2JEyzVwdv0iMI7FYdcWCU 0n3Z41o1UkBkwauJ1+pcRckvGC/r31ktxn0dPM7FLbiKL2HTEYYYs/hcsTeOMMEZME8K PCIxKc328qb1rfNsa8O7Tag+eLWD34eYRQrMK5XwhIq5qMYfVgeQu//HzlPCapOJbmoH dTBZtKkzNzHTNWW1Oql4kfRHQ6Za7/XrMDgtX665/1iXhZDZfc0qLX+BXYUD3MN7vHCw S+e4Fu1LDwYk3gQTeMl6B3ItrlkN/2OEd1vgY2fL6lM8/KEDLxKUHUlQm4gMG2zrhWl5 SkEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785338096; x=1785942896; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2v6EYAF/prndNnQMY9/VeGyA6EcrPV2/qkncXAHToaM=; b=d3hLfRJCK0OV0SgtrteEq3xl4qFALuMppMtDC2cL4njDYfNUtWzQbiYHPPLAqxKKHI 56HM5k9seEtfNu3FbaQm3soQ+jCevJm33GnZ9PcNmXK2BbLq/t+T+QkNGo2AjHLORMkZ jEfoXDioplYHTTbb89aeRul/tfAV7fE7Ugowm36Lz8SynBEOXPtL7tfYaclCravGAYDZ de5pgyewUp5oXJ/2UhcY6XQnA50Yf7osLWIuiEBU9xRFl7fvi7nzDHdVUvRwPqzPHTYb UT0ZHNLgr9zQx6hyStSwKNrQZgSrhmZXvdZSMBPeWqNIMPN2W1UQF5SRjkk2VB/5UPgO PzIQ== X-Forwarded-Encrypted: i=1; AHgh+Rr2eWudG8PkJivpwJAmi0+ZfeNvcU7FNl24mi3mfbncZtWPMTFODN1H7Gko9kn4vJJkfFbT7gKd17Ot2u4=@vger.kernel.org X-Gm-Message-State: AOJu0YwephXvLx/lo0JtfbLnMv/33dzEd86e5cg0uS32dpzakA6V41ia 0CnxWEa26BMIe/YV6Bk1dfiQLy9PNNal/nH44cenyZm9GJB1oRJVJfWZwpw12uwZ5R4= X-Gm-Gg: AR+sD10uBGxGWzG21IVbKjTbP8LC/0NM74QhMYGE6svy7JzufjvdjNc3NEJgDZajmFY P52g3LFrR8g53wubZzP8vw/2xUUIiw7J7Wt4qk5lycZY5Jm0LmED41aPn4WQDk+wChlcqbfR1YV BBzRCPbRC+FKWmcf8UNEx1aeT9o23dUiuu9D/T9pLW+gfVtMA1cJv7OpSjQJJvGXKFVf7BsZcp5 RMtUFBm/JdcDpZqEoaRvTZAq3UGFE1T7JH2E3zx8UIWg0Byl9zHzXqKssUlBAbizb4uBeSOM56H OMt7Bab5dNoD/845dDCeJxKuhg+/l65Bsl1j5mYg8Gh6jBulSAntgNzmnyEkc1JsdMDurcFZIu/ 70SH1g8i1YsX6IwOCJ7Uqmjvb6bp/FQEKNTa2fkr0/o5YR7B1B8MMVW0jK00mRNq44e1u2BUJSQ RxlJOGNkKKDdpQgpdQVTDw7ph9TWTwrwX5zW6wwUlERrcyDQSbHGsWjLVtWriOSyPw6PYbcxXYN d7dvVhykxteP81G6BzPA53KqEPQ3Vo7trQqmsiXd4vE X-Received: by 2002:a05:620a:6885:b0:92e:612d:87cc with SMTP id af79cd13be357-933027745b6mr659175085a.46.1785338095672; Wed, 29 Jul 2026 08:14:55 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id af79cd13be357-933d3263c35sm187961685a.16.2026.07.29.08.14.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 08:14:55 -0700 (PDT) Date: Wed, 29 Jul 2026 11:14:53 -0400 From: Gregory Price To: SJ Park Cc: linux-mm@kvack.org, damon@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-team@meta.com, akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev, usama.arif@linux.dev, vbabka@kernel.org, jannh@google.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, ying.huang@linux.alibaba.com, apopple@nvidia.com Subject: Re: [PATCH 1/4] mm/damon: defensively skip zone device folios in damon_get_folio() Message-ID: References: <20260729142228.88390-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260729142228.88390-1-sj@kernel.org> On Wed, Jul 29, 2026 at 07:22:28AM -0700, SJ Park wrote: > On Tue, 28 Jul 2026 22:01:01 -0400 Gregory Price wrote: > > So, what do you think about adding the check under CONFIG_DAMON_DEBUG_SANITY > with good comments at the moment, and later converting to folio_allows_mm_ops() > together? > I think probably we can drop the commit since it'll be a little odd to add ifdef's and then take them out later (the latter check will be functional, not just a sanity check). ~Gregory