From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1EA941D659 for ; Wed, 29 Jul 2026 22:34:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785364443; cv=none; b=ov2+ZbsLfzynTwsK8io+4gRk/gf+pmgw8JWUPdGSsffvIsUdch8YywLhEDToWerM2LsTfTiHm8vCQ6ttMTUpcaoHBXRqUmsVTW8FVUHIiekDbAQdgD5HfNBmssN3v0ndJsxx2wrVV40lWoHmXyJlPKKk/kkr2HFFnJOeLDxL9lY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785364443; c=relaxed/simple; bh=0d7s90ZVVazxLIkAIFc6fAAnvqb+0IdFdB9k+3p45E4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fnas0V22xOThgJfWPK7C4DKQb3PFvLwIJ5CVoeZ/omaxLX62ixzT6KeegdRYN1fxQddsgUp2y8sWKq9LlScfRdAUqG9y2X/UCJwIG2Nuo0FoEDQkqJMJiWhEifpTUl+RyBhBhW25kypKNgfYEuJYBhzeJ4O14CdxkdhpkMC6Toc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H95hzxXO; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H95hzxXO" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2cf27856f9cso16044165ad.2 for ; Wed, 29 Jul 2026 15:33:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785364439; x=1785969239; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=XmJqv3LbtEXaKjjxddFIB/CCzuAW9BtsEymREcKNJvA=; b=H95hzxXO5wanvU1SI/N86iX84fmyh9EKgtvSTGA0KU7JMA53PurBLw/wpB4xC10dlI fzKVI8LUT1xB1q5QF6UBo85wBFZ2KFxO/qy6ARxnNbWZUYQVU+iPpq2V6zhP2Djl6z4v aJCD/4uEgdl5sIVc4ptlrob0veF5Z000nbwrUxJux3zepj6Nu+fWu2Ak0cieJpIhksFB YKTDjevNlHTl0H1TstyQRKUoPO/NV1vag+3uXJ6NUiKXb/+ar51izxvdUD8RYMLr2MN9 bl538I93Qd6gyyDT/i5cnQ5tdtUn/MZOGVPacS0+ChQ1z57+kIeF2CtConjZMY+0oQWD M0SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785364439; x=1785969239; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=XmJqv3LbtEXaKjjxddFIB/CCzuAW9BtsEymREcKNJvA=; b=YVXFkPyqW4UHmERU+xp2f/CO7GudxnN8RSLI+DraTW0H2Nbv1UKTS27sVW8HepG5Aw zmwIIKQWSTNBtVSKIzFNF7pdjttX1XYrV+o5q8sIJEMdaTU4RKqEH3HucXzxdkdH+SeN p2qYrgeqHrRSfB6nQ5rgGa6SaL6Sa0WoypHCLIYX4h2VVaGfEPjt45fg0RHHjn1Q+Ds+ tSKWk7Z2M07OUZOdBzUhaZFFNjVzKqCOGybsbiOS8J6Jzoj+Y32CGLcZAM7qrD6wQICC 0o4FxDO3/YOe5xDKsy7TCG96QsCVG/MrhwpnGt5zBUmzlK4T34fw2y/q/RqI/EqBI3yb jwzg== X-Forwarded-Encrypted: i=1; AHgh+Rrmlwa3uMO2Tz6KEcJxGxmKIggaRSx8TeN5O57UIkOjfVV2opnbA8luhSCm4IOYRaj0BkpGfrjPfWDeTUs=@vger.kernel.org X-Gm-Message-State: AOJu0YzKp9hIL1qgXmnqKezM+YTu5hJYQZ9LDwYDtTBjyhv/Nqqo4ctg QTAzsJd66aLCUgQM2XdV/e24yHzCgayohNByxqvcaoT7jjiHowfxJaW5 X-Gm-Gg: AR+sD11a8XFy0rLFOGc3o/8z4fWG9kwTSi6BbxR2EnCVZsueG/Vb5NKP3ZbJ4cTsb4x UNYyyoxl1eAylza5Y0+mSxWuC7LtQ2/EhvwWA+CW1RJaNlJLNzQolmWRogXQLCRRnTPzBgslkgy FctD/FK0RYlNJwn1W0DQgCvpw4qS2GGundGDzFnbeb7LwpWn+KSFJfcwzz4EpXAHnT7wfca3jW7 5MVWFXBIzTmKGQq+6/j0zVf8FzipIYaFE9wQdxl6vLDDdmt3fkwehMe7mAXRqOxw4ORPV9MYJbX r+pWFfQXbOHVvnPJPw23rvwz/ZJYmnQAk1mp93Pact3Wa3k4Bu22Y8YhqRR2yFLiZay2ZsSWHIq rbPRWQyVwA9DimqWF6hwSb5Kn88DWM4b/cOyPrILG+7OYKNC/JkNuNFbgXRNY6Ccg8VxAzUuF0x DzvwYoFzI0MrILQaBbvVGKhQy3GBPTwYbtKjeU+n0MwS0UpF5HgMXjOsu6cck= X-Received: by 2002:a17:902:e888:b0:2ca:d151:383a with SMTP id d9443c01a7336-2d035c10f84mr2037815ad.20.1785364439062; Wed, 29 Jul 2026 15:33:59 -0700 (PDT) Received: from localhost ([2001:19f0:8000:3e6e:5400:6ff:fe38:3d01]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d022a468f7sm17125555ad.28.2026.07.29.15.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 15:33:58 -0700 (PDT) Date: Thu, 30 Jul 2026 06:33:45 +0800 From: Inochi Amaoto To: Anup Patel , Inochi Amaoto Cc: Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Yixun Lan , Longbin Li Subject: Re: [PATCH v2 3/3] RISC-V: KVM: Reset the SBI extension when disable it Message-ID: References: <20260706021154.210289-1-inochiama@gmail.com> <20260706021154.210289-4-inochiama@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Jul 29, 2026 at 01:32:40PM +0530, Anup Patel wrote: > On Mon, Jul 6, 2026 at 7:42 AM Inochi Amaoto wrote: > > > > The SBI extension validation callback can only fix the parameter if > > the extension is enabled. However, if the extension is disabled after > > modifty some parameters, the state of the extension is still broken. > > > > Reset the extension when the extenion is disabled so it can have > > s/extenion/extension/ > > > a clear context. > > > > Signed-off-by: Inochi Amaoto > > --- > > arch/riscv/kvm/vcpu_sbi.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/arch/riscv/kvm/vcpu_sbi.c b/arch/riscv/kvm/vcpu_sbi.c > > index b737e9a7a12a..3eb7b7c57059 100644 > > --- a/arch/riscv/kvm/vcpu_sbi.c > > +++ b/arch/riscv/kvm/vcpu_sbi.c > > @@ -221,6 +221,7 @@ static int riscv_vcpu_set_sbi_ext_single(struct kvm_vcpu *vcpu, > > { > > struct kvm_vcpu_sbi_context *scontext = &vcpu->arch.sbi_context; > > const struct kvm_riscv_sbi_extension_entry *sext; > > + const struct kvm_vcpu_sbi_extension *ext; > > > > if (reg_val != 1 && reg_val != 0) > > return -EINVAL; > > @@ -229,6 +230,15 @@ static int riscv_vcpu_set_sbi_ext_single(struct kvm_vcpu *vcpu, > > if (!sext || scontext->ext_status[sext->ext_idx] == KVM_RISCV_SBI_EXT_STATUS_UNAVAILABLE) > > return -ENOENT; > > > > + ext = sext->ext_ptr; > > + > > + if (!reg_val && scontext->ext_status[sext->ext_idx] == KVM_RISCV_SBI_EXT_STATUS_ENABLED) { > > + if (ext->reset) { > > + ext->reset(vcpu); > > + vcpu->arch.csr_dirty = true; > > Let's not blindly set "csr_dirty" when any SBI extension is disabled, > instead we should set "csr_dirtry" in kvm_sbi_ext_fwft_reset() (just > like we do in kvm_sbi_ext_fwft_set_reg()). > Good, I will move this line to the kvm_sbi_ext_fwft_reset() in the new version. > > + } > > + } > > + > > scontext->ext_status[sext->ext_idx] = (reg_val) ? > > KVM_RISCV_SBI_EXT_STATUS_ENABLED : > > KVM_RISCV_SBI_EXT_STATUS_DISABLED; > > -- > > 2.55.0 > > > > Regards, > Anup > Regards, Inochi