From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23758382295 for ; Thu, 30 Jul 2026 03:25:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785381910; cv=none; b=P/G56Sp5+iyPs8slyd1LzABppofWf1haIf7gYu1ktDNIXMwt33Nx4QLk3QQjUiLkEk1G7qGVrrKgN0P7DaiximzYjx/tOsdMkFhhVFsUVc6moANDDuXbiUusMTzoRlI/o/YxU8w41YD1s+8fOioIjwo6deDIBYpLDp/ZYqZLGXM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785381910; c=relaxed/simple; bh=moxFj4LK5eQ0iKGvXBlohU775jHJeBxgyTnS3/nFR50=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LlVgyI14UcD0Ed9k1/XCJEaWx5hRt3k/0ybMyFubkiZ+Z8fqqLeXUWaSIJdWiAuxabPk8AjT7xkJ8yjUzx6F46+iVbDd28JtbyWrS925gbVjPnGeWVQyUXe/czn5WeSsuclumhdGDM/5wIkCp9iP8PHlA1th2XMxATd+en5km1M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kYm/gNJ3; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kYm/gNJ3" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-84830c774a0so1884858b3a.1 for ; Wed, 29 Jul 2026 20:25:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785381908; x=1785986708; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=+MFNjhf4fLcryxrPI0kEcRFU59dAVTf4ieRyCYark9c=; b=kYm/gNJ3YBFXhzUhqCpvyn703+TDZ92HQ2AJMk4F2SN2rE5uFf60cVHBQvdJgI5hdl zkSCYVjdqCrQOYJL7p9q90JK99t47jigRGP6C0VQi1cfhvbkT6EP/HzgTlx7tyWHR0D+ 5nod/Xfc/4AIB57Al0qggb7dI63bMYM7UysRcOxzHjP8ewv41VPI4iogqV6B3znWMr9E PA5E5trwIXJpVIl8/xTIl6ZDYlmhtbDXYJMhZuxXE1HzBgr3w/S0Oh+ZcJaKz8XRI9kd ilkV0qDLHlFCpfAbPT2GzIbpqvPe0mDXq7I/QA3AnoJvFgWF+2q4xlTOzXFFWvghosYX wVuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785381908; x=1785986708; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+MFNjhf4fLcryxrPI0kEcRFU59dAVTf4ieRyCYark9c=; b=QzWwW0W8+WFX1d6PCtXn9B+ywybFZkgn4lG3xMR0tmXGeLPkDc3q9Bar1yf+WiZHMv NMYIv7+duXy8kLjVnvulFwUD9USD7SogbHeMo2Oxbi5SETZDR0ayaLVzQLy9nNHvMrwq MXK693UbkuPRV/VZAilsLP0YpF/nGHc4YO5P9SFPROJI3PN391yuYQL8qbi2Y/bmwUNU a6xyjgygs7gv3DNRxaHQ0Fd5IqqjYYpWKX6h80VqyS3SmXebU0M3Bcoijl7v7qdbL5+H /ILyKlov2IUWQZR6bQHuIVCc+e/OXZ+IGoernVLPnP/vdhOdcsXpy6SPBVoUwp9IJ06D hSaw== X-Forwarded-Encrypted: i=1; AHgh+Rq/LsyqSc/BJO5UZjCqAS/EpX3cTJA6QDrjpBEJxjzbkrZ3m8Np4opJsgQFTaG/WLjeCd9C1X4ShY0Gh+E=@vger.kernel.org X-Gm-Message-State: AOJu0YyrDJ9PaevSq9+V9/y+XVmRCkD0xkRpe4GA6hAtQAR7aQTZXUld uhURo0+jIinb5ega/qvP5RHhPvGTcZVzGIAnOjS5Y347F30jukk4qTiy X-Gm-Gg: AR+sD11O9PnaIZV9e812G0JT8Ja0GDZiig8sbo1UrrJmIngbbuqIiBW6UMFCxsIezpV px14WBBMPPwuwjZMhFXg0oOfPnl2QKkR8wicmgJQY8mKhliQrsHwTc4IGjvaITvcADh038rBUgA QKC/L2eff3hAEN3mGKDVyPtmezgDxSDKURvb/nF0Yw7AJky+7DRUYwrZ61epAWq6vzCD/vUNGrR RwoFHTIFBn3JQaDn9gCIjJI1xZXs/yUx9rUt8fg6uP77a+fJ932xrRqLK8SEEitmHQcpIsk7p30 iq+2giJCenp57SxKRWgC5vRtYi4MkAAc5+WHamEIp3ysf+892xcWsdiKxLDMkXTeBPc9MchiLCJ /oAC7pGa/nJh8qoRVkTLpw8tISBAtqywZjK8FQDdc6DW9z3kARdpjHAf6bdh6Ez8wZm7FyE6I8H AbaC2WVJq6fRonZBBTdhq9UvzJvTtx/7o56a7m2g6Suk85FeXz3HueOd4LYgSkoEBj0w4g4RfZH wxBQXTtQ9YoOBUSzcaG1lSfJima1M0EeGOtiWuC9a+mSoJS4vv9dzU= X-Received: by 2002:a05:6a00:e13:b0:848:438d:3665 with SMTP id d2e1a72fcca58-84ebc3ddc5dmr956581b3a.41.1785381908265; Wed, 29 Jul 2026 20:25:08 -0700 (PDT) Received: from nxpwireless-Inspiron-14-Plus-7440 (61-228-203-195.dynamic-ip.hinet.net. [61.228.203.195]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e9fe238ffsm2272593b3a.12.2026.07.29.20.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 20:25:07 -0700 (PDT) From: Jeff Chen X-Google-Original-From: Jeff Chen Date: Thu, 30 Jul 2026 11:25:00 +0800 To: Rosen Penev Cc: linux-wireless@vger.kernel.org, Francesco Dolcini , Johannes Berg , Kees Cook , "Gustavo A. R. Silva" , open list , "open list:KERNEL HARDENING (not covered by other areas):Keyword:b__counted_by(_le|_be|_ptr)?b" Subject: Re: [PATCHv2 wireless-next] wifi: nxpwifi: embed rx_reorder_ptr Message-ID: References: <20260729183715.691287-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260729183715.691287-1-rosenp@gmail.com> On Wed, Jul 29, 2026 at 11:37:15 AM -0700, Rosen Penev wrote: > rx_reorder_ptr is a dynamically allocated array which is done near the > main struct allocation. Combine the two to avoid freeing separately. > > Also fix the type to what it actually is. void is normally used to avoid > casting but there's no need here. > > Signed-off-by: Rosen Penev > --- > v2: fix unused variable error > .../net/wireless/nxp/nxpwifi/11n_rxreorder.c | 23 +++++-------------- > drivers/net/wireless/nxp/nxpwifi/main.h | 2 +- > 2 files changed, 7 insertions(+), 18 deletions(-) > Thanks for the patch. Tested on nxpwifi with iw612 chipset, running iperf3 stability tests. Tested-by: Jeff Chen Reviewed-by: Jeff Chen