From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DAC542FCBC for ; Thu, 30 Jul 2026 13:06:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785416784; cv=none; b=prRiv1n+ZASyIM+j/avJSzhRO2hkkg5kZkKrOIClY+sJ+2NqsApLQBL4ivTLJvYqqRD8bQJWvzdYRKWvNeJ+uU8E2iJhShiueFr/QxQpmEShKCWQvWyUgdPY6Xp/nByLagd1kIpJ+qR4+BJo5vL8BLdKrk3jf1HjiPJGNESTz/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785416784; c=relaxed/simple; bh=r4K3ZVt18WAGvJtyk/TPvennSIuJFefaDJtGXcRDTjw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Pi10tF+ptpnslQF97fMLaxS6B9bQR6mm29CgKtW0ipkkxqi4xvfziqAq4djdlNA2hyJY8iHNTmHp3ybJ7EkdsMTv1J7+YtM23cE9iLsoBNFnIrrhSo2fM6FRu3vpQx3nCV9I5S1uhWPSa3YKfDdBCJJA7wsABZYK1/LiK7/+kn8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=readmodwrite.com; spf=none smtp.mailfrom=readmodwrite.com; dkim=pass (2048-bit key) header.d=readmodwrite-com.20251104.gappssmtp.com header.i=@readmodwrite-com.20251104.gappssmtp.com header.b=qJMJYVjX; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=readmodwrite.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=readmodwrite.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=readmodwrite-com.20251104.gappssmtp.com header.i=@readmodwrite-com.20251104.gappssmtp.com header.b="qJMJYVjX" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-495635a85d2so16963095e9.0 for ; Thu, 30 Jul 2026 06:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=readmodwrite-com.20251104.gappssmtp.com; s=20251104; t=1785416781; x=1786021581; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=sxXEd+HzJtwi1wb5EKcD7k+cVu9vp/hmZ7y5pUznXvs=; b=qJMJYVjXUHnjicG7z7fH1ka+sksga/NP0pOe7FFngqlI+7GH+vt9ZXpzbQQtWYynTX JShA0VOGVLBLxFJlKaghABdTsi2tnpLWYxqulr1qAFazGgv5nEGP1GYvjsae1Z4r0Fhq f21ZRTEvtF613bKxXHtl8xW1fCYAkFdYuw2u2cfRnPuItvB9YLK4iFEr8ix7rzd4dZJM vKxCq6yhz3t3tCGVzD9z3nGUIh9bMd6yryJtvrgbUF7rtpSHfMaP6m9McATMki78dzEC oNOxsynM4DsmCokAYKXLpisJqe/jt0/zJSir771QasP31BBldusQt9quiuDbBxFKiPmI dHWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785416781; x=1786021581; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=sxXEd+HzJtwi1wb5EKcD7k+cVu9vp/hmZ7y5pUznXvs=; b=dgnG0hNtXglrRk8tBjLwbJrlq/fLZEaG+Lei3VNFEbGX1WdKnnbtp/A3BW86WoT2uG i/LUKfIiQ2aKNdE/nG8Lpc8P0ndZSB8J+e53+u+KgofTqFH37pkWsEn6xl8BvaV5tB2h t9TlBZSmGQGMnHnijimKpuTELfwB120PM6UYIs83XWhHlkKWz2XdPiKH9WNIkscVQo/+ IaxJFtygHzV4OKywkUVkojzXTONkhXExRwaaVIIu9Kgbj7SsLv71bEPue1P3oz9rpA3i SSdL1o6H3h+oIADeHS/FB/IH78chzBDLpY0c4sK4VTTbnPUrl380qDZWRMWTKzN8WLOY hYmA== X-Forwarded-Encrypted: i=1; AHgh+RpjgOtDKMz+4KvSrZELNFzTRBneEh1JsZpr/d4LmgXu626yjinSaQjy24enRurYQZpuxNkH1QQwMvNdcQ4=@vger.kernel.org X-Gm-Message-State: AOJu0Ywp5qmTpQXojveHx+/DxkcR7JuYO9qCcDe5gPlbKLd309UmYU/0 QlLmkWQdKQ69y2G5rhkjwfh14sTAfNTN2B1PyHtTk4vBVwehYQ03pobKC4/k8WKBQf0= X-Gm-Gg: AR+sD125/hiNWXUW8GQnGR6aOgBZBsMAUXCN68btZRtMarwgzJX1VdDZFlSHO0B6wFr u5tIwA4ftdXnJzT9l4sTw8QhEaW8KUztWI8ISjtZlCtMDChqEmD+JL8PThgbNiSF7JvzP5TMVAV kumPT8VWp9UYJ3vC+rYfjQMC4MUvWAz+AyPgjRE/H0niGVkZQeDM2IyN7YYvAluC70qfhLoU2Ox INyifSgCVawMwG6PahNINYRiezHFnC+id/Q9s2/Zd/4JTqQswVeXfII7rFchtQa1PHtVWcS9RT1 GKMWP0XZug7uAbXAmJjRItY/nj+XFPxmYyx6sORsL33FWeiVQshGh/C+0Gcuzp6Fe+zLG/sYTUF 2H4Z88NxccK3PUQ98kqMobSJXXTJNkJ1/WHF9DRUcGFh5FQA9tPaK6hJ0rqbDAuctv/BbVEAvFS 0TKvCnhrwJmGWEYbdyoRkJUUy4MpSV8BSxvPU1aWM1PrgHATg= X-Received: by 2002:a05:600c:8209:b0:495:6b8a:5227 with SMTP id 5b1f17b1804b1-49800ebed12mr33012005e9.23.1785416781243; Thu, 30 Jul 2026 06:06:21 -0700 (PDT) Received: from localhost ([2a09:bac6:37a8:ebe::178:11c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fc892cdeasm6356992f8f.22.2026.07.30.06.06.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 06:06:20 -0700 (PDT) Date: Thu, 30 Jul 2026 14:06:19 +0100 From: Matt Fleming To: Brian Foster Cc: linux-xfs@vger.kernel.org, Carlos Maiolino , "Darrick J . Wong" , Dave Chinner , Christoph Hellwig , linux-kernel@vger.kernel.org, kernel-team@cloudflare.com Subject: Re: [BUG] xfs: sparse inode allocation can trip i != 1 after AGFL growth Message-ID: References: <20260717130429.1838767-1-matt@readmodwrite.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jul 29, 2026 at 02:50:13PM -0400, Brian Foster wrote: > > I want to think about that a little more and need to run more tests, but > unless something better comes along I'll try to post that soonish. BTW, > I had to make some tweaks to the reproducer test to make it work on my > fedora based test vm. Is this something you plan to post for upstream > inclusion? > > Brian > > --- 8< --- > > diff --git a/tests/xfs/842 b/tests/xfs/842 > index 9e694a56..5455998f 100755 > --- a/tests/xfs/842 > +++ b/tests/xfs/842 > @@ -293,9 +293,9 @@ inspect_unmounted > read -r free reserved used <<<"$(ag0_reservation_state)" > reservation=$((reserved - used)) > outside=$((free - reservation)) > -bno_level=$(agf_field 'levels[0]') > -cnt_level=$(agf_field 'levels[1]') > -rmap_level=$(agf_field 'levels[2]') > +bno_level=$(agf_field bnolevel) > +cnt_level=$(agf_field cntlevel) > +rmap_level=$(agf_field rmaplevel) > flcount=$(agf_field flcount) > bno_recs=$(alloc_root_field bnoroot numrecs) > cnt_recs=$(alloc_root_field cntroot numrecs) Thanks for catching this! Yeah I'll submit this upstream. Thanks, Matt