From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f51.google.com (mail-yx1-f51.google.com [74.125.224.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9B923FF1B5 for ; Thu, 30 Jul 2026 14:38:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785422294; cv=none; b=egY19t6DBMPx8Q7VhipqXZJ4/H0++KGgpSSjci+4/0/M5ilKK+nbbUUCVlB7IRCDHbu7bL/tLcw4EaCi/OZPYpxP5x+T8FKci0ZlsMWVHAbSWgAEOBp0a2dbg4KlQ/G+ugx7ThlkqDDfS9ZW5cb9frINUb2kG3cLnhjXyBS2nAg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785422294; c=relaxed/simple; bh=ljSc69aX7CTWHRJdJgdDl33WKuH5zjh5+KLUUrTuits=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=reElmOjbPpqauWAqzDMko/AmO6XtjRbvQxwOlYn64Ui1wFWHPaxHhHt+UOZfjVR0fgP5CXPCpgVD9RFDqrgyf0Y7DTaJqqpQg/kU7p6C6W/OkcPwRbrEP2Ldsy/YbOEl4M5kUy/G5mqhhTC2FEt7vujW6qEL7GCDh6b6l1paqnI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hsZNs6G6; arc=none smtp.client-ip=74.125.224.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hsZNs6G6" Received: by mail-yx1-f51.google.com with SMTP id 956f58d0204a3-668c1b780e5so3280215d50.2 for ; Thu, 30 Jul 2026 07:38:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785422292; x=1786027092; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=1PX4tMMPrcdGijfVy8V6872YM9hf92en2GXQCdp9uYQ=; b=hsZNs6G6om5mxPyofUaQROUzuJzPDM4SsMVyAjU78dawP6bxQ+CQklL1YsbOJLOy2z MwCxbygrbrdfIQEpF8cwhAv/DtRktS/alddUAg5jsxb/bM1SYKwJvMuRaYWihQo8rosH 5Sgjwr4TfpLt6t/Pb/VEEGUr8QM84ymbAf9czuY6/CxKuTahmE4NJ7ygmhnvubb1pZUh 9eLxE/DZzLTpVlUWGfnNA8tMyMp3oKQaNTWJ6RCnVYD1PdJviVSjbwmHdDNIXwgVHluD JLE87ix2Lw96RjLSR/3ip0mXYlBusowlze+DqyDhTNvk3YZGjG1jG1mvjCOckko79sod LDCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785422292; x=1786027092; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1PX4tMMPrcdGijfVy8V6872YM9hf92en2GXQCdp9uYQ=; b=JAVLcaWIqUOaJ5uXHcRWZsn6JErg4q1twwKXsCDd4F7IY57P+vBMULyfVIggiQKVxZ 0WqL1r6AxoTMn7kp09HTQ83fuPBFb3zPjiPgLfgYn38avyoE2n91hOyJ0TKXkLILZdgN KInYTTdrWoQAHz+0q3XbkJLkRQCuSPw5zPJnCQsYRnhg/mRB5QVZ68fANn2zfFdXYJar z9gAk3UIZOr1YC6INWvxkcNPyXwkpLGf4CrzpdHW3mn33kI+tuKTnNjrkhyrC5lz4Ihh Sdkc3ncUMOjxhTZDsgc1YS+LfeTXl7CqI0urdYABB48eO9Skffu+s4XooLWqRMVllS41 nyhw== X-Forwarded-Encrypted: i=1; AHgh+RoWGE1pQOg46k6mAB/g5AnszIp9bqtGULyySFLM4/DGZ7JSjTAdzEBUWJqidQuMwdNHeDW2hAsfT/uudFw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0kv0PZeZZCNKv0JQs9j5+oPLObXlrSyp7eN2Bf7XdvEV/I8h5 v0REinBxanf55a6c/Ns+i+lNSlya+9fRWP7vv790Yqy3J+03jGE3HdB4 X-Gm-Gg: AR+sD11ijAlof8Na8xi9tC24IreVK7i5gjQb0DxCN4OSofL+4Qe9AqLoC+fvZz/i8Hs +QPa7Mt9mSkbS6v7wo77JEscVH/a9s0VcQPjIg116MPo81l42txQT5Ef7EyxveZpMEu8HUHJpsk E4n+atUohOxB6+kZIpQ0XwZJz/4c3PvfR2rpoB8kIPQC0ul2m/XA+kJy/vjnkX+24ZUqG5YWNMe TAvge73MUjrYYYtiIGt0oTzpLbu4gmPlsVYHtscAG25Rix1mdZYzfnwIQQVnC2lckLbb2GJtaOf pV4Px9VeqeS2yLgeSvLBprSRqczRo/GWcizTYI6pqzGWdlBdalyY9wxB9GN1ZHUbEWiSwOvE2bU +d5rgsTZ7PLHI76+7dze7qIHHgN19uCTj5+Re56KOAud1/4wBIDLpuE5c99BWq6AsIjRF1eC9kw Ov6OckHHb6xBQqKEkYtbWecNrsLglcYZyQEvablQlitCBmXxEHe3stQLEVJsBGkGUooCTHzSHvQ +5ud4STUUTrFcdOAJ/JCF3q9A3LfRv/RkgOSRKdobnoDqgppIZJhvubI5gekUYu6ikYRc6WV3S4 F74= X-Received: by 2002:a05:690e:438b:b0:667:bb60:78af with SMTP id 956f58d0204a3-6692f7b02e6mr1322456d50.90.1785422291746; Thu, 30 Jul 2026 07:38:11 -0700 (PDT) Received: from fedora-laptop ([172.245.82.59]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6693b131342sm127756d50.19.2026.07.30.07.38.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 07:38:11 -0700 (PDT) Date: Thu, 30 Jul 2026 09:37:50 -0500 From: Ming Lei To: Caleb Sander Mateos Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] ublk: split request validation from io_desc init Message-ID: References: <20260729012951.3744582-1-csander@purestorage.com> <20260729012951.3744582-4-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260729012951.3744582-4-csander@purestorage.com> On Tue, Jul 28, 2026 at 07:29:48PM -0600, Caleb Sander Mateos wrote: > In preparation for moving the struct ublksrv_io_desc initialization from > the thread submitting ublk requests to the daemon thread receiving them, > split the fallible part of ublk_setup_iod{,_zoned}() into new helper > ublk_validate_req{,_zoned}(). Only ublk_setup_iod{,_zoned}() accesses > the io_desc and cannot error out. > > Return a bool value from ublk_validate_req{,_zoned}() as the existing > error code ublk_setup_iod{,_zoned}() returns is only checked against > BLK_STS_OK. > > Signed-off-by: Caleb Sander Mateos Reviewed-by: Ming Lei Thanks, Ming