From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFD6F374A02 for ; Thu, 30 Jul 2026 19:52:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785441150; cv=none; b=qRw/8QJ//jjaz2kEGftMdPLKxxI1pN9KqSkUMrilWT9MuIKJI2tO8vivQZwZZZpdMLNfjFQorrhflblTlDIrSr37nMPZEuGCm2kPhpK3KGSr9ulhkBDrCYuheLtvF6ndlSbPFt7mycBRuaBVr/ZRmCmDiAhH9pl6CxW14EbczSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785441150; c=relaxed/simple; bh=7y/fmud0L6LJFIjbeO9EwLlNT5k2p42f8i3RLwyzJsg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BOr4Vtk6YUFQKO2k+j0bCIIO9I5ksRoPA/hvq1WVRsrB7+vhoczs03H1Fbb8sYrBmpGPXPIIdayJ3LA4fMfkXqqYEk/RbvC/pu66Ip51+PYAc0vePXjGkUB4i0F/G3XNzj6RWC5cqKzzFKdWvhIdkka4VEB/yujhemmOqikVcyk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=hXCuhh/2; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="hXCuhh/2" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-47f9ab7ee38so60497f8f.2 for ; Thu, 30 Jul 2026 12:52:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1785441146; x=1786045946; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=vwVWNRy6nalbM0tK/ypHZd0adndrVP+y49fN+aH/CbI=; b=hXCuhh/2g07obWSJIgtZw3p0q+6WdrpA0O+n+i3vVlsblpBiWhgAcWdGxstW0P60w1 0nqIB+kgFeEVJCN9VJ9pvpzyDh35qZUR5U8NfuknPo5WxjsEhI6RmN1ixSVsoarat00e 5mcNpSRoIe/HM1q93uYftsNiUsSDI2Pf8fhkyN24zVilhK+tB4jZLHj6rzkGBidKT0yj RZA5mIK+F94wd2W5fxN484wMHe45f5eMNW/m3DLRXN1VegoI6uFNFz8RPeTuVKMCne7k gonLTCCjOMALyGgOVXpqc1x+2HdwYaIm8kxxLYXG/u35uj7GubPMjkSNPP7p/Bqtrckp s09A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785441146; x=1786045946; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vwVWNRy6nalbM0tK/ypHZd0adndrVP+y49fN+aH/CbI=; b=sQqCXyFB/1lFNS3s7CqkJbnhfvafl8Rg0JHFM4xJW0kErrNmtW7RJBeasNGivyCf4q frp1Yv3+3moeCzfi5AhtDTV9KiQf9zYBb6MyYkVjxDLUA8HCV984ZOJPsVNDUPTHIxrL CZr7YYdYSg5OxQ1/0KR+XfZb3MIn8mjfsBvk2crjEefsnwKgc8mleoL0xUkL/gGJfH2K dRjaJvPqyp2Yxf3mL0yr0sUSBRbULCAEj3amJVAcpnNii9x8YTQDKv8Ln1TsnMxUzjfm pMUj6THcgg96so0/7hokqpwu4FxVOFJDwVgRzJoX9Ys6e9eqwocJzlW+3E982xNbnnX9 sZDw== X-Forwarded-Encrypted: i=1; AHgh+RrlCHTdOkXmTyfoivPnKK4fYI8xQWg9VCvC/q+1oEHHFu8bJpsZd1xWDtwjEwqA+s8nm8iNu7xM86t6lEU=@vger.kernel.org X-Gm-Message-State: AOJu0YyL4fYLCmYSrcz0JA/9DsA0XSO4d3NU1UoBZ9akWNZvHT4FKMgg QhIms7njpXA1nEnNrgk2ACG6wKkbc0lzVGjPFzkI/1anQf9VRz+oz4SJtu3HOAbl4bc= X-Gm-Gg: AR+sD12JqL7+XBDXwSNluypX/RpoKXN/9AykbLgZ7sqUok3mbsL7WWULQZTQ7Ausmen 9F/bK6xScxWv12KEvQPqfnI5VRYggbe3dl+ECwGOuvsacgd5x6PeOE5SZicZb23Fe5bZL5t1HOO eXeFT0jJnl40jsVEO/lExx19Ft2F7T8f49Tx4xlGIcLE1hb7jY+8gFVR4HwaSitUBI1pOiZDozq /I1jvb6y0gA5O8MqMTBHuGGz7VYoTTmp0Bdh+OGOnogqP+OQkxVaT3W3TJODeGLaH9hoDIwXgh7 xUyNXW9qXLWiqV8UkNmhRN6LNBwBcNcqGCdt/IcY9XKlSMqqp8bBbz9ux5tEnePqaNujiWzwNTY 3EfAqCllVbJSfBGzhkg2zYoLmtVtscj2NpDhtCqkatmQo99VGQ77JPcZNrhijOuOviWCE7kAzNX cnLDS8zPJS7gGZNeQ+nNs2yD/UZeuFC0M+8d4DhftBRa3oyHaXTrvW3WtCWDA03H2sesmz0dBXS JrFSA== X-Received: by 2002:a05:6000:4383:b0:47f:9254:d45c with SMTP id ffacd0b85a97d-47fc82305a5mr6432813f8f.31.1785441146101; Thu, 30 Jul 2026 12:52:26 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47fc892cc3asm9575726f8f.23.2026.07.30.12.52.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 12:52:25 -0700 (PDT) Date: Thu, 30 Jul 2026 21:52:24 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Dileep Kumar Nagavarapu Cc: Jonathan Cameron , David Lechner , Nuno =?utf-8?B?U8Oh?= , Andy Shevchenko , Michal Simek , Conall O'Griofa , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, git@amd.com, Sai Krishna Potthuri Subject: Re: [PATCH v3 3/6] iio: adc: xilinx-xadc: Split driver into core and platform files Message-ID: References: <20260729125455.95893-1-DileepKumar.Nagavarapu@amd.com> <20260729125455.95893-4-DileepKumar.Nagavarapu@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="b5ow5tkqlkhhbeq5" Content-Disposition: inline In-Reply-To: <20260729125455.95893-4-DileepKumar.Nagavarapu@amd.com> --b5ow5tkqlkhhbeq5 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v3 3/6] iio: adc: xilinx-xadc: Split driver into core and platform files MIME-Version: 1.0 Hello, On Wed, Jul 29, 2026 at 06:24:52PM +0530, Dileep Kumar Nagavarapu wrote: > @@ -19,21 +19,13 @@ > #include > #include > #include > -#include > +#include I wonder why so many people recently add in their patches. Is there some tool that suggests that? Anyhow: Please don't. is already enough to get of_device_id (which is the only *_device_id this driver is using unless I missed something). linux/mod_devicetable.h will hopefully go away soon, so each patch adding an #include for it is annoying. Best regards Uwe --b5ow5tkqlkhhbeq5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmprq3UACgkQj4D7WH0S /k483wf+OGssOXqZyZNhVlMbxIFkvol7gw7dRZpH+FLGCwaz+YoZOShc6uF/dy0R toxrO3NuL6fqemrQygPUT7CDqUxs2H+fpREr6fqwxp28MDtOMojPvp98Hz3WkGsy 32ONJaOn6e/cqTNYeRBts9+710rveP80zM5/iO5Hl2srSXemwjlip72uWRymUdme lJLVrZbJJMTt2zVeJIfx0HrstM+ZeG8BnU0+oTSoUaFkfVRbeyJYqmifZ6Y/jtB2 gaTmouQCp47MEEUcEmXHf3tJ2o4Dt576bsXp3x++/XW3KCYvHgA+HRkgLWjZ1QNz TfvUbzG14aw7+PZE5PzAT3zdD16KaQ== =rINs -----END PGP SIGNATURE----- --b5ow5tkqlkhhbeq5--