From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB44C3D4127 for ; Fri, 31 Jul 2026 11:02:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785495765; cv=none; b=ZNGMNv49k9aVnkJ0UMtSvkdWemLYsjfJik1mPm6agBopsnl5VFHe+BUl64zDYKxmgojhHsXvAylh4rvGYhB2OaAJJ0KxwlnHtt9P6CxSbh7Uu4/CQrSJd/3k3Zqd0EJ7LB4JsFvWol5FAV0qZhds99bhF1N7Umy5RJJ9iHUZESY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785495765; c=relaxed/simple; bh=UttL/smsbJtkih5lb1VV/UF9Ho2WkKRkc69jT3EqbN0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rtZLr4ofP6VyXoRpkvWsIs80AtWD0BjsN3amvBioiRYhGKM3WHq47HroBSsIChSe94ENw2CfIUkwXwvGacRDd2sNNg8VldgYP+wj+JPLrQpof72/o/PWb8x9Gh42KgjvJqnNO4X25eiTU7hf5DZu8Zk7vxrZ4WcwkbGr/b8/Qrk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QLvkpUrk; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QLvkpUrk" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-c16794450aeso111610566b.2 for ; Fri, 31 Jul 2026 04:02:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785495761; x=1786100561; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=/6uNV2GL6C0ZsZDyZS0/gYxz+j9PZV4eKokd6xszxy0=; b=QLvkpUrkBx9djJyaGxE8XTdkArP9dXk8o0eUdITSVPatV9z6+AOyHLd9PhSzKCR9P/ yBAKV0HD2I9ajA7w32f30PJwiYVxa/0oxz8BQoUBonFjPI9NFZxKc7DqK/c0pZIb4o64 y628uy0c3IqXMsVgmBVwe78qo1vQBrPh4xoPM6ts4mVLCqbDC+YaxpMW1cTCegd6ODrC As8wZoz5RW+64eSZ9nDY6UfbfvzekBK1vfk+LRS3tcyez5zTYaN4n2Iz8K8toQUUeeDh d4Q5U6+7Ta6tPllDCDk/avNC9oVokpw+dp9s1H43inV+SLNdP6hYi0v9ndAqgqMCLsQS mNzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785495761; x=1786100561; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/6uNV2GL6C0ZsZDyZS0/gYxz+j9PZV4eKokd6xszxy0=; b=dpr9zvvEbh5VSHy4YP1vfBXjvwNkSiFz3veP2t28Nk5aJ0NSJWpQQUSZQx7Emc1KyU IgVE6HArtt/68Ul9Kys3scroSGQ/QiyteaDkIS/dn/UCRv+XRf2K6OPmC68nV38CKmDF u288LvnmkoXo7Celdyndkc6h4/J6ITR+Xi/3JjOSGe2VlXPYJLdQq6U2lEKilRyhve9e hxn4LLJlKOqZ/ZE2tPnqeqLCYYjU3QfTcGEq4LSxBbWCXLO4rTThhpgqI2aR2zSni6vQ vwyCt/mwqqc9YuajcvDxzeFdDqLGiBrbG05PMyM3hFoPnhQepYtGmb4Pxp2BlwQLofKK VSnw== X-Forwarded-Encrypted: i=1; AHgh+RrTkW2ZUNzN17wpZNPZbLnkfBhou4/roboU/sSeYzmDsnZktaCAwcdNp07dTOR4Hyj6DqyHv75ZLsZxvEc=@vger.kernel.org X-Gm-Message-State: AOJu0YzDQd8Xv6pMOfeSJhUPS5HmeQrBGA/1QxDosbXV0QqyHbPzqxk8 zk498AUi8bNu/6cy4qck8x1wJckB/uTrnOzbfOytfjPoCNnJo+RvxanD X-Gm-Gg: AR+sD10uvoCr0kKR7uwn+7JacaqszPgwjMWmzg3lW0SuvDlVlkwYVfYKnkavUA3bVo6 nJch/321KkUaaxyHHyXc7LY86PPMlxYtMlJdWIs5Njt3j9PSpUzek7OBKwQ9CqcgxRiuo8iz+Ad Kazkt4QN/2RTVJB5eNI6P1BQOx6Esn5Q4+hbVT4B/AvD9zAP/XFTrMjCa7EAyfxyOlum1rhJhkF opSJMOUOhvwvEOti3yWTpnguWz1EsQzm15nkEqUNXd+/Q0kxKwJunAYqWwU6CNvViin0obfaStJ UpVDI+5iJ3+ySwNxJ0gtNX8L7J0+HoSpxw1JPQo+cDw+sxGEWUsmaf1qi3JUS7RZqG+U1ZcEE8w WLl4QPxnkKifYsQUY8YDjOIjbfjexCavcIqzCCtVM3u1BSI+bDPj++X3PA0BIyc7zPTHS/OCGIU OkEPNjSAvk/yaX4Fi5mz2t8Dd7KcOmIlBRkfwlOOcSre2bFfJUL8eSBeESWg== X-Received: by 2002:a17:906:7948:b0:beb:133d:cf02 with SMTP id a640c23a62f3a-c1fd24147f3mr89622466b.26.1785495760950; Fri, 31 Jul 2026 04:02:40 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd3c93a87sm114875166b.18.2026.07.31.04.02.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 04:02:39 -0700 (PDT) Date: Fri, 31 Jul 2026 14:02:35 +0300 From: Dan Carpenter To: Hungyu Lin Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] staging: rtl8723bs: propagate errno handling for mgmt xmit Message-ID: References: <20260731070546.20959-1-dennylin0707@gmail.com> <20260731070546.20959-3-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260731070546.20959-3-dennylin0707@gmail.com> On Fri, Jul 31, 2026 at 07:05:45AM +0000, Hungyu Lin wrote: > Convert rtw_hal_mgnt_xmit() to return errno-style values and update > dump_mgntframe_and_wait() to translate the result back to the existing > _SUCCESS/_FAIL flow. Update the prototype in hal_intf.h accordingly > > Signed-off-by: Hungyu Lin > --- > drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++++ > drivers/staging/rtl8723bs/hal/hal_intf.c | 9 +++++++-- > drivers/staging/rtl8723bs/include/hal_intf.h | 2 +- > 3 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > index f5ab94a2d0a0..0027f9333738 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > @@ -1990,6 +1990,10 @@ s32 dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *pmgntfr > pxmitbuf->sctx = &sctx; > > ret = rtw_hal_mgnt_xmit(padapter, pmgntframe); > + if (ret) > + ret = _FAIL; > + else > + ret = _SUCCESS; > > if (ret == _SUCCESS) > ret = rtw_sctx_wait(&sctx); This is awkward. I would have allowed it either way, but it's good to note this kind of thing in the commit message: "After this change the error checking in dump_mgntframe_and_wait() becomes quite awkward because we need to convert zero to _SUCCESS (1) and negative error codes to _FAIL (0). A follow on patch will change the dump_mgntframe_and_wait() to use kernel error codes consistently." regards, dan carpenter