From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C25D3D5668 for ; Fri, 31 Jul 2026 11:03:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785495839; cv=none; b=EDK1Jen/CpLaqYHc3+rd/p86iodV2nQfdRpzXH7f3PvZZwUlL/lklhLMTEs7sudRTw4TaB4QW9bPo+61vRc68LxtQy66XJL/ZT7gWtMkgR4LyubX5wPoA06RyFGm8n6MLrrFIDjsEWU+UppDokHNcfhKMNss8gl0dpHVTxcuKy0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785495839; c=relaxed/simple; bh=sEi+tX0MQ53M+EjMBBODNoAR3sytsf15B59aogLgzi0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=G6oQqtIbphUtJAQiByv5N0h2iLvXj23o9AVeITOKRIleXuUWxbhQWV8PGz4wWMuO5+ny5wPCDdfACQIQl2h4Pgqn3KgtolVfFCvGVM7t/O7pgyHwHaNdEnRsER9grnCPvOaoovlwQQKHeGVpWP+1QJKdDpT0eC7vsnrRBgT1f3I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nEJSJ63v; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nEJSJ63v" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-c1c24ec9525so138774566b.1 for ; Fri, 31 Jul 2026 04:03:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785495835; x=1786100635; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=AvWCcfsZhC7SHwl/V5kypAzLsmxgXVBhLCLYNj64BtA=; b=nEJSJ63vNlipAgUn8RT258gufd1lg0Nb03vjwOuYSFU2bQmTNfWqY2dRfrI6nf/rmc d8H/kclsCVWjeF/8nURMR4/8K/5oP52z8wgwxzl54dlSK2LHN7/TZKo3FiEsMKj1L3kA 5yYPOtVZo3S+f5x5C+0jgRAMllenNSDaRnYrFwuHKQ0qXiEnrliNyOsnSZYZZLJbp0En vhvDe/Opoe9dqlz2pVmI9h7/h7PtVVPqycg1xn2JQQnt26YAJvZzBQ7ipfbEVkH3vITA /pVYug944CEqnHS+eugkk5lGXBDR11x0oWhVfiTDz+ApRzJj2oFU2bXCA1CNF+UNkPUv iACQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785495835; x=1786100635; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=AvWCcfsZhC7SHwl/V5kypAzLsmxgXVBhLCLYNj64BtA=; b=SqUbauqJqWp/8CgVoqu/wmVm75u5HpAU2JQblpbFoj+wVkaRP77iZmqSruhOlcGb88 7dnA/06lpIjimuOAuD52VvqE2lrUMYEzNEezaMphQCQYb8raAsJazdXYSHq31xKCGpb3 mSgzbeCori7mtK+e0Kih3tsCmHBu2pqQV0hEzOyQ6PWvJMfew1phBsU9rKYqikkHqQ9y kEIrz5syi5al9lckT1m5M3RBYiQI9AduWPV76sg5dR4fCDnoT4M0Zhsgkm2q50imL+sY 00Kka8yMGEQVuvWoU45bsh/azPoHFnsSg1u9L8W+66Zhs9fPis17mOfMRVtvtNPwSD00 Uuuw== X-Forwarded-Encrypted: i=1; AHgh+RoKAIT0k7LgAilWtxisQ7RvmvrIUdLS4/6zEG0XPEom3B2ZfS3bKw/+cGRzTpXur/pfM9vVkTZLYV1JhQg=@vger.kernel.org X-Gm-Message-State: AOJu0YxdpGl+NXCbVEm0Q5DkE2rMPCwB6Lo4maiRUxpyDUXudGCgzD40 UdKVFiRdV69qUyKW/1WrJvoYsE/zDgx+3Yfs+rWbfocYdAd9c+fQ/6AK X-Gm-Gg: AR+sD11AxmpZazbUkvGUNvNd9TSFaK1m/JwrkeNmvzDPo1JIL1pXJqz5XYndfj03OVQ rOOaBIOnT2j7Iqh5BTG8XfEQM/funn6RLt2d0jAfmPJbiwh2kK7CC9BzjtlBsA60/JjN1Ddsa28 Ou0n7VOTIlAwubt+K08vcmCwbmtaJH0g+xMA7YnFgoXU1gVAa7559R1JPjjhM2JzKxU/tRWwk7+ pP608tlyW1PPfb+dxEG2kS8fLocbrgtPy/8KsokPJ3nSOIxiQpqyhar8GDKTzd4nlYHsxxBp1pM 4nMM5uYEbWEKFb3sUZNsrlt/7OushXPR8gcLQ/E1O6uP5+WCUfCJaVjWs/fQu9D070pU1TkG9zz Eoik3ZJInKB14ofu8UZsW89ouKtiw7FWcyxtn14QwDOx7V8D1lhquAz1Ph9hGEZToQ7pvfoiw8y D0JGf7BBtH0JGQtWOUqQMT0wHtjOPOJgwSWbg9mZNLfoJ1PQpsGE8xO1uM X-Received: by 2002:a17:906:9c89:b0:c1c:62b4:1ebf with SMTP id a640c23a62f3a-c1fd2567b29mr85574766b.60.1785495835324; Fri, 31 Jul 2026 04:03:55 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd3c5b365sm120650366b.13.2026.07.31.04.03.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 04:03:54 -0700 (PDT) Date: Fri, 31 Jul 2026 14:03:51 +0300 From: Dan Carpenter To: Hungyu Lin Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] staging: rtl8723bs: convert mgmt xmit coalesce to errno Message-ID: References: <20260731070546.20959-1-dennylin0707@gmail.com> <20260731070546.20959-2-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260731070546.20959-2-dennylin0707@gmail.com> On Fri, Jul 31, 2026 at 07:05:44AM +0000, Hungyu Lin wrote: > Change rtw_mgmt_xmitframe_coalesce() to use kernel-style return values. > Return 0 on success and negative errno on failure, and update the > declaration in rtw_xmit.h accordingly > > Signed-off-by: Hungyu Lin Ideally the commit message would explain that "This is safe because the only caller doesn't check for errors". But then the question is "why don't we just make this a void function?" and the answer is that this shouldn't be a void function, the caller really ought to check for errors. Change rtw_mgmt_xmitframe_coalesce() to use kernel-style return values. Return 0 on success and negative errno on failure. The caller doesn't check for errors so this doesn't affect runtime. Later patches will hopefully add error checking. regards, dan carpenter