From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EC5D3C5536 for ; Fri, 31 Jul 2026 11:04:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785495864; cv=none; b=KDwnudnL1+iGKBm9Rc4roNjSA3FiM/tRMRs0v8/gOt/PXtfPtWhNXkTI2O4ztM49eFpCT+fk93B8GD+bn90mbdr48x9BGJKwCBlRh05Zvh2Ay1+nsUGlsSruJW56Jk27QrfhyQ+MQBvKf75nwGSi3SEKCo32Bj3bSxlmqHXWC0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785495864; c=relaxed/simple; bh=Ip1Tc14WQ8kWKUd64ygJloWb2KjHGPnwCnBSmgVeAfs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S1cJDpp0d7BS3EyUKN0naj6XDBbjrdmj4hBygIIVUyDbaD+gNNE8aHNXogyhRvwNOR7mwgXWSoypQS/NOnSzs9flG6+a2OOGRHJMXRgQzBKP+icYqaCIiwFYwLBjmvLGFFPJI7RPt7a4VVZKZepvTHZ3qnU8n7xhoEWpP0hcmaA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BPpem51s; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BPpem51s" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-c15e592da74so92689866b.1 for ; Fri, 31 Jul 2026 04:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785495861; x=1786100661; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=5k2RLQqC46IoD+6vTDAv3WcLwbLeEg+LzHDsLOj7ryk=; b=BPpem51sItYQoWKc+IyAc4t8Vn2JNbZiooZy3SVxrcFamgFbxxegiDd94wp/xkw9nI 5ZBlJdB8pT3JqpPgpCEJ3B/HET42G8ncFjM+NMck9zpStQqJNIfEK/qq8ckQa6XucMFt LYBtXPdNVKyw/UG9RkXSLJ0KSNpfMSqqqB3qYT55hmo1akTzbnUx5cA0Xkv6gM79YumJ gpvQWD7EEGilbxZNGkwBhY+NryWJ8K/oHtmOND6uKIrQGSNyn57T0TwMg2VLgJRdD3fH x+e2BFpxVeGMmPM9a1HWwrIwiyEWLYHKOMMpf0AGKvlwpk7yy27oUZsBxEGFs8t7N+8I XDOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785495861; x=1786100661; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5k2RLQqC46IoD+6vTDAv3WcLwbLeEg+LzHDsLOj7ryk=; b=pwfgO+PfBnuR+8Pf8kbFxXO3i1R34FWrwYoH0PaY+WbkkJvW0Zed7yyo//99+v9G6u IpM+3VB4+MAeo6SSact1OiWrf+JUPoG+3ib4gjG2hNVVOON16CqMhuFNrqfnEiI1oHK4 nJopFp8kIieEUCIcgb/1G9K+JrFJIFbpFmgFl3adZkGTyE0DEoSglnT4hW8YgJpiFulY LfGSkRl8doMdokjMs3brtRuCVD3sIPOTHNGwHR7Rg4qHhZSxUUTayY3hMCd5I6yuBQud PAtbGoC0VmETeSv6+/bY8Q7xypX/SpjDVSVZrMBdSLR0lnq/WGloQRquaQy8Gh1AckXz vpeA== X-Forwarded-Encrypted: i=1; AHgh+RrQpElM7ub9gS7a53DkAbOx29ZR3xoz5pvcaLAOvglHa8CNmAxil2VCYjQbAMTlO3eC4d6iu7NM/UefAU4=@vger.kernel.org X-Gm-Message-State: AOJu0YymOjC+o7KKklG/gM9mMQbwNtnoO+NnaYVcBm9oe8xgClbInVlh uazfpeKxfPa8U/Trc4TIw/PnbLcUm998jrI0dEFEjopYmBKkFx7Hhddg X-Gm-Gg: AR+sD12dT/Ft/kjcRMrQ2NGnCl8pfpAJZiXG9X2h4A2ILm8+cLqXcfTo0r7irYpniTy 4WGjZMVL3tN4wgqgO9H+Dz+bzAU9NGUsKTrEPCD1lx1qBBT5WHGIRbJdssXQ1xbdbkpGVqCzQBb NQDNq2fU5kb++ZVd7pRJZ9LoTMFBspWTk+1obpuqxbEEUAbw6JPxX4Sw2fMvG4J+8rXzb4PoAPU dpeNqEKwgAOCeEZ4RatNzS21OdtiZkGqHFzvszrPuOl3VwqLXid8DJcl5RC2BrCYQX8SxO2+LeZ CO6AnY/McynXwtpUHZ5/JVyRIclEwbeCIb1xJn+3uKwr8ykYLYFx8BY9yLPEtjrIIg8h4bEecAv GReM9Z9ap3zg4iSPlkzVN83LbHjP3Adng5DZ9VBLIk05xbJMxiJcdAm0ks3hTI2m0qKC+PRVYLg fVeW/FoLfRT50LsQJVk/Pe9r/9LSjgQaKj/CcLavmktzocr5RUKAfWtMyO X-Received: by 2002:a17:907:d1d:b0:c16:7402:1abc with SMTP id a640c23a62f3a-c1fd26e85fcmr97603066b.47.1785495861256; Fri, 31 Jul 2026 04:04:21 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd44ebf2esm95392366b.44.2026.07.31.04.04.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 04:04:20 -0700 (PDT) Date: Fri, 31 Jul 2026 14:04:16 +0300 From: Dan Carpenter To: Hungyu Lin Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] staging: rtl8723bs: convert dump mgnt path to errno Message-ID: References: <20260731070546.20959-1-dennylin0707@gmail.com> <20260731070546.20959-4-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260731070546.20959-4-dennylin0707@gmail.com> On Fri, Jul 31, 2026 at 07:05:46AM +0000, Hungyu Lin wrote: > Convert dump_mgntframe_and_wait() to return errno-style values and > update its declaration in rtw_mlme_ext.h. > > Signed-off-by: Hungyu Lin > --- > drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 13 ++++--------- > drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +- > 2 files changed, 5 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > index 0027f9333738..da74184fd07e 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > @@ -1971,9 +1971,9 @@ void dump_mgntframe(struct adapter *padapter, struct xmit_frame *pmgntframe) > rtw_hal_mgnt_xmit(padapter, pmgntframe); > } > > -s32 dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *pmgntframe, int timeout_ms) > +int dump_mgntframe_and_wait(struct adapter *padapter, struct xmit_frame *pmgntframe, int timeout_ms) This is like patch 1 where nothing checks for errors. I feel like the right thing here is to change it to a void function. (Based on the "dump" in the name and not based on careful reading). Either way it probably should have an explanation in the commit message. regards, dan carpenter