From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6F622264C7 for ; Thu, 13 Aug 2026 00:16:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786580218; cv=none; b=tktBUEYIrF3wlAphZirL27ehAi0KgTq8Rwd3QfpyTzL9AzlKToH6cYZhJNOsSpk0pvQPDct0DnVlOSYKThzYndIoh2Ed7yrejyExQEgPuqJNdJfaeuKLYJndHPYgtHYeUk71iO6CmL4SPXMhCsrFOP8RAyf7iv4N+InRY2/h2X0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786580218; c=relaxed/simple; bh=rj+2YVxpFBxwMriFLetMJMWkavMI/yhxuIBVc8tSPYk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=kZRARpu5HkymJy8uHDu4OQjsvtGp+GVp7IUgr1bOHbOquzs36FQuMm++VHwd+/LBvPzOXIzYP7PQFcSRbTXZNkJmAY/vAL9UwXLEfIqQgqNxaIPDG78FSrFb/gxAVPWKt5/5aPBcJ8H9caMFt9hXUZjriVbZYiyt1N9e2aLOxfI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=dUNif9FA; arc=none smtp.client-ip=209.85.215.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="dUNif9FA" Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-cb835525b10so206511a12.2 for ; Wed, 12 Aug 2026 17:16:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786580217; x=1787185017; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Dmmb7kHHOuSL08Tsf/+CaC3gxX+k6w8HGJQJEOhDkmw=; b=dUNif9FAJeykZgXQiQdASCnf9+DpWTyvq1tdtFP66gbkyXsjqMEOwesADaVZG3PatX DoG7pvb9wQr5TibG/jZpQzHRfyvsfxcLR2igzp1zVm9wQpAreyCMcNeUyEnhmmGHUDVz +IxFEVfG7C43AbAWZ1UDn/bsL5LmpBF6qKkQGHWRSaIK9qkKtNMRQxkYITynTBAq7siF 3uQy9MQeKHareDB698PQd5PMRdyND5PokoY3o0aSDivxfInQKymARQPoKQE6Vk5zXKi1 ufVE8RmAHeSt6CUUF4ht3UtRpgGnPOK1mjU/sDt70PM+p2VVo68XV3H9Mq2QMuH1+0ep esdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786580217; x=1787185017; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Dmmb7kHHOuSL08Tsf/+CaC3gxX+k6w8HGJQJEOhDkmw=; b=evtKt6wDtk8MPy+Q4zsAluUXg1xNmY8ZkEd1Eq5It2nn68P5R4CzZGbJALqCIvjxmo P/lzGjdUfTerKj694mXYYcqBAYYHp/G/ZGk5XB2Ij9UmZqJCeM2llVufZmfw5iLllDF6 yKBGhQ69p1xehZ/92477pokiSi2avwd6uodhW2a/zyx0RMbiZyhu25xEpGoDjkGrKjxD EYXJ8fkE2XsB/JOQsTiEtl3yQ6rr2MOPN5MfrNzCReIa9yddmJIoumA/nPRZ6hGPY4oR kJMALspZMd4wel7qlgIYkzguo16MsfCLRavmWwYs2TInxsWfoI5qylKlQElL5mCfr3W6 WxPQ== X-Forwarded-Encrypted: i=1; AHgh+RqZ2cSiFdStYyqRXz4cfQV6hcoFNACYbZcnXkfW9dydEzNqaJRFJ/SkXOl8H1nA0IqI8jL/TQsEIaSLGpY=@vger.kernel.org X-Gm-Message-State: AOJu0YzSy6+2abwrfDHAdmBp70g6Rf+zxVBffzjCSzMlJs7OzcN42id6 ovBL/HttjuHdqfjfQtjqt1YukYcwZmhGyrzFO6TINh10A9DoTJoXq9+9aXqu/u3mn4yXdRRnExI fjWcMFw== X-Received: from pgld13.prod.google.com ([2002:a63:e0d:0:b0:c99:3b68:c9d7]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:7286:b0:3b2:8685:118b with SMTP id adf61e73a8af0-3cc5524622bmr2530914637.20.1786580216761; Wed, 12 Aug 2026 17:16:56 -0700 (PDT) Date: Wed, 12 Aug 2026 17:16:56 -0700 In-Reply-To: <6bb1328d-e995-4ad7-9744-3ab01d2ae591@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260810112200.2326727-1-xiaoyao.li@intel.com> <20260810112200.2326727-3-xiaoyao.li@intel.com> <5dfed336a46329ba39922dcb3a8723116dae9ae4.camel@intel.com> <6bb1328d-e995-4ad7-9744-3ab01d2ae591@intel.com> Message-ID: Subject: Re: [PATCH v2 2/3] KVM: TDX: Fix the exit reason handling From: Sean Christopherson To: Xiaoyao Li Cc: Rick P Edgecombe , "pbonzini@redhat.com" , "kvm@vger.kernel.org" , "linux-coco@lists.linux.dev" , "kas@kernel.org" , "nik.borisov@suse.com" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" On Tue, Aug 11, 2026, Xiaoyao Li wrote: > On 8/11/2026 8:38 AM, Edgecombe, Rick P wrote: > > On Mon, 2026-08-10 at 19:21 +0800, Xiaoyao Li wrote: > > > --- > > > arch/x86/kvm/vmx/tdx.c | 35 ++++++++++++++++++++++------------- > > > 1 file changed, 22 insertions(+), 13 deletions(-) > > > > > > diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c > > > index 7338ac0af693..a89885d550c9 100644 > > > --- a/arch/x86/kvm/vmx/tdx.c > > > +++ b/arch/x86/kvm/vmx/tdx.c > > > @@ -921,10 +921,10 @@ static __always_inline u32 tdcall_to_vmx_exit_reason(struct kvm_vcpu *vcpu) > > > return EXIT_REASON_TDCALL; > > > } > > > -static __always_inline u32 tdx_to_vmx_exit_reason(struct kvm_vcpu *vcpu) > > > +static __always_inline union vmx_exit_reason tdx_to_vmx_exit_reason(struct kvm_vcpu *vcpu) > > > { > > > struct vcpu_tdx *tdx = to_tdx(vcpu); > > > - u32 exit_reason; > > > + union vmx_exit_reason exit_reason; > > > switch (tdx->vp_enter_ret & TDX_SEAMCALL_STATUS_MASK) { > > > case TDX_SUCCESS: > > > @@ -934,23 +934,33 @@ static __always_inline u32 tdx_to_vmx_exit_reason(struct kvm_vcpu *vcpu) > > > case TDX_NON_RECOVERABLE_TD_WRONG_APIC_MODE: > > > break; > > > default: > > > - return -1u; > > > + /* > > > + * Synthesize an invalid bogus Exit Reason, as the TDX-Module > > > > I think this blurb came from Sean, but can we standardize on "TDX module"? The > > code currently uses "TDX module" and "TDX-module" and "TDX-module" used much > > less. I also don't see why it needs the "-". FWIW, I like TDX-Module to clearly identify it as _the_ TDX-Module, versus a potential TDX module provided the kernel, i.e. a tdx.ko module.