From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 996A63955CF for ; Thu, 13 Aug 2026 08:43:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786610609; cv=none; b=M8D8YnP4TcDgzvk3BttV57Iqc7y7wg3VhOj81Vmi80pilEfNIncZfCEeuAuvV5p76udkuLYjUR+eCdrYDiMA4SJKBSc+Y1aJm9yt8tRwNPXI8UvB07dSvOMZl5Zw05VftAD8vFSqVX6fFvVSMeS4rk7R5KhAbdglsIR8efB3egs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786610609; c=relaxed/simple; bh=7eh/tEEaVVT82VWXjTL8vLLDWxnKGlVuFG9YrOF+sW4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ls99Ne14MqKAMFPUjz3Spudho8lS3Hz1QHiJcI4pehxen1ZxGeIBdFa3BRotQJu03jMJj/NkoAWMl1IBJItzbHcuUVVLOQX+p3UmtGhjBpWRYVPKneXrSs8/jrirjmqlrbZwWq+QjRbK2Te4lqe2Iz12qXJEiI4y+qvVB+c9ZRw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=S2JCR5C+; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ik2qCxHc; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="S2JCR5C+"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ik2qCxHc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786610603; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w06Zz5eZ4ZoMZ6QYcdF6VhN9WY/dFLXdTr47WLmeFiU=; b=S2JCR5C+Bibtdb1Igyt77x6m6an1pIPccIGliwOzbcuCm6wHwQ7zJnmw1CeG3hifzmbiZB 8dAsPWgTzbYSAj9OELkjmx4qSTeULP2zNIEM8cS5TkkiTycmW2hN5WgXun1tAw/7eeRHAl R00gXP0jC+ONpobNPhu3enyyOAjHCXA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-422-WF-RSlBSNeSJbUONg3AScw-1; Thu, 13 Aug 2026 04:43:22 -0400 X-MC-Unique: WF-RSlBSNeSJbUONg3AScw-1 X-Mimecast-MFC-AGG-ID: WF-RSlBSNeSJbUONg3AScw_1786610601 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-49808ea1b64so7895985e9.1 for ; Thu, 13 Aug 2026 01:43:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1786610601; x=1787215401; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=w06Zz5eZ4ZoMZ6QYcdF6VhN9WY/dFLXdTr47WLmeFiU=; b=Ik2qCxHcfDQXW/ptSsJw9EdL07B7t9DTVSJl+ervMaNTFogPPLvaEji1diWYFd33/b LgJeRMeD7kUlWa0lsuQfD0J2VnEl4jjvY43+bt0aPWhSmlHcO8rhr8r1EoNyn9Wa5WjI 7LNwUU2i6/oQ1TO9LPAoGXd2SLxHqhuE0ERcPjFTC7OPNfHh46YCon+sn1EfpSUzHMOE YLl8jTlctq0giCporKOfR3NTOGF2ANzvvcOtWYPHB7YhYa8l8rybeN/RZaVqdTWcD/b5 LJ4D7IeoJHtEIvzYWgaCnsfbmbh818M5GdHNFzg33UzSI6WKtv7NNW22wIOGnf1C9lch JwpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786610601; x=1787215401; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=w06Zz5eZ4ZoMZ6QYcdF6VhN9WY/dFLXdTr47WLmeFiU=; b=imvHr9ZoBrO96fC+ELjg0nvnhpDpLs41Mr9aB40SPe6z0HUa1hC4ElXjpHuVxr9rsu dlZNLwtxgxg99LFEoXM7Cz8AHKh99G09iDonS+7/AViTbIKzHUnWmNariBpdXccNR7jT bmyaWjngZoSAWRwXCUHTe/oh9hWcnbyKiR+wma81/HJZwVNHDptI+7u4cSrmIZJb9ghd WTUWiwQNdTSufrmmJxWhxijusBltvpFvrcs7KXpKYNIi9Vp4DPw4BVSdAOuai5VTMIK/ zNDNfWJLYmkwJtalAzW9DG77E50GKPdOKEcHKId3sGwh2/ByJLfC0AYuWDB01G6sMsm2 /9rg== X-Forwarded-Encrypted: i=1; AHgh+RpyZwaBxFqRG/9geRgIJm1yFIkOIqVluMBZKQ68c1e78DNJA9rlcOCNkXiSrXTrnFwliK3qMusjQcc7EvY=@vger.kernel.org X-Gm-Message-State: AOJu0YzP+sZ9eOcwezxsHTIjudtIxM+bEK8ChKpL1S6tOTLavDl7ttWd 29XDR0eyBmt+KzU3NRRDDhNTpOHaPO+xRn6f88Zafgy7wF/kVY9CtOOZS9f9L3SHHk0biMgjWEK WHhFUUmQomMJciuFe0Fj2sjII8qvOZV8LTdc5V76pRaj5U5yyvln25DjjGKIujaEg6g== X-Gm-Gg: AR+sD10pWZjiSoKUaEB8YLVhZcYCeLpAZIeq/jOoNim/fuprYXLC+SPhDX2c3fYVdic 8EJ0NPIhAMPDeaEVwXbpDI2wPdaskuG0BSmy3rUoYAYVGqwRl5NkuInzd82+hEePl+q/YMB+JYh 9nuEZzmvAvcUWLQlQbJ/iqJNfp+ixgCyWKcxXifK5ry6ejPIWk3k/VJNMMy6M2mrPzwD9RAOiCu cmJRONk5WulBVcYcqIIV6GA4Q9Vf2cEh3xlz9r2/SdiY/SopW4XHJLyr4ePR28ytBJTKauZaFH7 WTjfuV6zGTw/RAPxriwn6U0u/K7fIx6wglMsmyKqC8KGiS98Jv7yZVjNnqSaH8ojqh29O7pjTbT jVRrwEXgyXMn2VAabVo9V0LiOORLBUJS17zTjaWq8/Q6lXNbFmas3 X-Received: by 2002:a05:600c:4708:b0:499:596b:2e91 with SMTP id 5b1f17b1804b1-49982200a77mr35404325e9.3.1786610601137; Thu, 13 Aug 2026 01:43:21 -0700 (PDT) X-Received: by 2002:a05:600c:4708:b0:499:596b:2e91 with SMTP id 5b1f17b1804b1-49982200a77mr35403785e9.3.1786610600655; Thu, 13 Aug 2026 01:43:20 -0700 (PDT) Received: from sgarzare-redhat (host-82-53-135-154.retail.telecomitalia.it. [82.53.135.154]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49981b0f6b1sm48409915e9.4.2026.08.13.01.43.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 01:43:20 -0700 (PDT) Date: Thu, 13 Aug 2026 10:43:05 +0200 From: Stefano Garzarella To: Nguyen Dinh Phi Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Dmitry Torokhov , Andy King , George Zhang , Wupeng Ma , virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/3] vsock: use sock_error() to consume sk_err after a failed connect Message-ID: References: <20260810170935.2242314-1-phind.uet@gmail.com> <20260810170935.2242314-4-phind.uet@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260810170935.2242314-4-phind.uet@gmail.com> On Tue, Aug 11, 2026 at 01:09:32AM +0800, Nguyen Dinh Phi wrote: >vsock_connect() returns sk_err to userspace but does not clear it: > if (sk->sk_err) { > err = -sk->sk_err; > >For a blocking connect() the error has already been delivered as >connect()'s return value, so leaving it set causes subsequent operations >like poll()/epoll() to keep reporting POLLERR even though the connect >failure was already delivered. > >The error should be consumed once it has been returned to userspace. >Switch to sock_error(), which reads and clears sk_err atomically, >matching the behavior of other protocol implementations such as >__inet_stream_connect(). > >Fixes: d021c344051a ("VSOCK: Introduce VM Sockets") >Tested-by: Wupeng Ma >Signed-off-by: Nguyen Dinh Phi >--- > net/vmw_vsock/af_vsock.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Stefano Garzarella