From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 477473939A2 for ; Thu, 13 Aug 2026 08:27:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786609660; cv=none; b=R/yK4WMd0UuBTElTxvyoMBp56+Oi7appxPWa7AipdP1GsgSZD83QYv4rR5QqsPQRLGUG2bAUJ2ARzAqDU9K56AJ7JceezxlZ2XivJU1AHFS2B84nKPwIPhDDvpAPlSvlptFM4HpAR0DizrinSgVnaBuLknbSvaXzDLhmgQPjrA8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786609660; c=relaxed/simple; bh=I2Z3Lt0zyIesAusnAYiav2A+GTcePjF7nWszKETHBnw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lfybSjJEmclqZ5e9hA0L3Juh+iRgHLIT3gEWv06CQRSK9SfBNDyvd2q6gcBdctExfDKo0WpV2Hn0xlabp5bla7PVe0OhXs87z1iDqJZIPG7DXgxgGnOyPxd32XAzUtfCXvgSzN9lES4yXKheAVrIVWxzakNu1Jp7K9gRvWfHaQA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Rdqhe+if; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Rdqhe+if" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-4813ea321cdso426612f8f.1 for ; Thu, 13 Aug 2026 01:27:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1786609657; x=1787214457; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=9K1rmCOf2/ZVat80yjoIGMbcH4J2enbzgcI1jz4HLNM=; b=Rdqhe+if5EXhw6G2OfjwVdaEe97J/ckIBwf4AOfiw2BFY8fewKRLMWBmEOc2xU3Fdh 9UX/TX++r4W4aR3sA7tHsZP43dkMV5mqOuyukBwnwAryJU5RGbRVjCknz+a/rpBxrfCa 6txDvJYaTLLzIWhBQolr3tZqor0uOQ31u8LuKqS844wETu3Gp8mUcyM82MvsR/1tKjcb mFABA7JiL8DaIaBMpEhsJbFAqnnH1lCzYbiNGyfTwVboJC0STPzZgWAFXBAdr8UF5hNc z+vR+/cRnXHAqzYormMCzO68Gfvm2tK8OIuilaZ008THhqRTJmUAEUv/MM2jrsjVq+hp LZ4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786609657; x=1787214457; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9K1rmCOf2/ZVat80yjoIGMbcH4J2enbzgcI1jz4HLNM=; b=Gb6z/GZGqqZXSokNGZ+3/jHiSIJ3DR4obn/Ps+hB2mUCh3jroEPiM1HzZYAhfTYZTj MOmeQdoVPSFTz56smtgRhdvJJk1S6Ru6RxjghVdDKXzQU3ZudS3A8pe9GxuNPRHvaDVP BSwj2wh1crTUSPt/0gYerw428Zda/mbhEWcO6e+eWAhTkOIu7YIbypXcmD6JDIVt520U dboKb0QdmEgQvKdWZ2JZMJnQ6FmYIJ5dyNIEBcYs1CieUyD2ARmdluDmAHdo4MonK6Ik Gy78hjcL3T5i1vhRhlJsK+ZTDrJYqRKhezFjrxFJNnNZaCQt3z+AqlJ7Vg63r+V6THOi qBjw== X-Forwarded-Encrypted: i=1; AHgh+RqmZowCdd3heeXxixpoA3vFmNWasirNGMNV3IBztWebOBOc6ahNXeT4oqGwpRPKW3HLrJXumYBur++2bzQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwRfGCFAMD0tZQo0bmQ+g0y78gBkbVuvROkbjR1BWPtal8WOFM0 SatM65c7vnBJ9N+XNyn/OuUpI/a6H/5G8Whze5xZul4u2WAQk1ojUJFGkUmWeFiteIE= X-Gm-Gg: AR+sD10SlYcfjQATbh1j/H1ejnw6Z7dv+hRc0v3FOw8xGMpLxIibl+W8lCEa4tCcDUE VOQpKU1ucaKpgIJ33OxlDIwbu1oe+jGBrnNs7mAPVBeDsStjf4CauBTI9UICegbS7OZ+YoR221P 5QcX+RZDwkcG57d24+gjiXSjNCm0OElPLuzpElrpp+kxeJVeUkyX4wBOuW1tf4j2fLE21ZseFBg 6tmVf052WVH7RHORjarBl22MElvoIoe9O9KMuJSXQzwkIN21Y5D/JnjGbTE9WIKY66D1ZLA78fw utAaLrf716hdGgzpJB85z/DLKW9SrTQ94V6kUJFTA55auaqY5+/0PkrTJjrRWKuUFJv5DtJhFpI ZTBYWerC7mtYnhp1R2cCeI2oCk7DNMNB34fL+bfEiODgnZE02XjCL1wstPnAF9QsASDpz7LsyX5 TjFQ88zPSHvcmQugLdNkLgreJ4QqoIgvX5BJhqtmj//7HW67AskMSv0zDHQinNkanHyVv2iActN cCI X-Received: by 2002:a05:6000:61e:b0:47f:8603:a879 with SMTP id ffacd0b85a97d-4815a5e20a2mr4317178f8f.11.1786609657483; Thu, 13 Aug 2026 01:27:37 -0700 (PDT) Received: from localhost (109-81-29-60.rct.o2.cz. [109.81.29.60]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815a5c2769sm4395482f8f.36.2026.08.13.01.27.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 01:27:36 -0700 (PDT) Date: Thu, 13 Aug 2026 10:27:35 +0200 From: Michal Hocko To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Roman Gushchin , Muchun Song , David Hildenbrand , Lorenzo Stoakes , Kairui Song , Qi Zheng , Barry Song , Axel Rasmussen , Meta kernel team , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/9] memcg: remove the per-node soft limit tree fields Message-ID: References: <20260811203203.3456029-1-shakeel.butt@linux.dev> <20260811203203.3456029-8-shakeel.butt@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260811203203.3456029-8-shakeel.butt@linux.dev> On Tue 11-08-26 13:32:01, Shakeel Butt wrote: > tree_node, usage_in_excess and on_tree only existed for the soft limit > rbtree. They also doubled as the buffer between the read-mostly head of > struct mem_cgroup_per_node and its update-often tail, so replace them > with the explicit padding that CONFIG_MEMCG_V1=n already used. > > Signed-off-by: Shakeel Butt Acked-by: Michal Hocko Thanks! > --- > include/linux/memcontrol.h | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 7b02f1b3bb88..ce24e04967d8 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -95,20 +95,7 @@ struct mem_cgroup_per_node { > struct lruvec_stats *lruvec_stats; > struct shrinker_info __rcu *shrinker_info; > > -#ifdef CONFIG_MEMCG_V1 > - /* > - * Memcg-v1 only stuff in middle as buffer between read mostly fields > - * and update often fields to avoid false sharing. If v1 stuff is > - * not present, an explicit padding is needed. > - */ > - > - struct rb_node tree_node; /* RB tree node */ > - unsigned long usage_in_excess;/* Set to the value by which */ > - /* the soft limit is exceeded*/ > - bool on_tree; > -#else > CACHELINE_PADDING(_pad1_); > -#endif > > /* Fields which get updated often at the end. */ > struct lruvec lruvec; > -- > 2.53.0-Meta -- Michal Hocko SUSE Labs