From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE9FD44163B for ; Thu, 13 Aug 2026 08:24:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786609501; cv=none; b=hDWk7hTOwi0WE5QEvNXTJ5iTiw6WTD1T6FgvPcX5LBnz3ndoESj5qt4zVaM4aMHSgOhmIPdRuk1H159TaufNURtX2TdjwjoKXvTKWoYV1+btfG9oVc8QIZSpX8HimAGHmAcwVHNfsqMZhI09ea27Eg6dt4wHQN/PIsh38Kbkra4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786609501; c=relaxed/simple; bh=37vAtmNfOujMcH3MWHXINElpCL9eyAWFyk+kSktAwy0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Jdck3Lg8DBzeMdHaLip5XhoscgWLMZ6aMkcshuzTz7ISpB5IjUtZuScKykvm9l/tVpcxtP94Vju51W4aTLoinEdVZUCMCxLWU9hxL9C203bSqwAlaW5ws0SzGn8BeRWCpVKEFyBaI4TpnoBPjTPoEHKzvtEqOp1RnIe+q8WzTI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=PdLYFM79; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="PdLYFM79" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-4798bea72f9so951533f8f.1 for ; Thu, 13 Aug 2026 01:24:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1786609498; x=1787214298; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=olz8czTGt9Myorg9Ej6EStVuWMdLaEwvC+90rEKHcaE=; b=PdLYFM79/GqP4V+lmM7tuqa5xML/i1dgIteWYIrQyDZWDAyD/YvHcgiQVqFs5WaqFd ZKObpOBZr7tLh/TS25TGZtph7owr4sZ7mmeZP53gLxYyQOt9dRmNVaiU4NmTAkM2V8te pnljgPlekMBi+I1LF31ggnn/7syz/Up5BeWv88LX5NQgu3ibo2FgvFNEAf+U6mlWKPpj GqSIUca/iSDdR54dYXZGDhxjEraAy78ZXsRo5Q4zPxhtV4ZVFFMU6PP3qXSxak6+qXOn gB1oABxCyu1Pfy4fjnWt+UMmpquIREeQ41laccdb0AYTXX7vMoZHaSXgE/Sq/8AHgm5o +/9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786609498; x=1787214298; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=olz8czTGt9Myorg9Ej6EStVuWMdLaEwvC+90rEKHcaE=; b=PaRVdrTJcwJvVvIDtgj5gx0DG1jDNupx4jkcAkjNjBvgiUB21j/08u/JKGSZhZOJK2 ctbF+CSEFgUNflpvzyM0ATlr0peoSscJHm455zuIy95VTtox8AieBRxsOGpKanrscHQL bDCtBdM1DOOUoeqCsCI5hHbHiWZkQyIgtJxL0N7i4FuB2t10ls/DR+W4B8FZ6UNXpyXM sGy3JrU1ogTdb6iqPTxdaKgkG88Oqa6Evv8B69UNYRQScjjWwb/nV+RxOt98ZwZlkPXK Ylrvg4uVNvh+DD0NnklrTbTOQtdyPSpiTY4243N8YRHcvUaHEZGq5u3Yoz3rg01OKWZC +CQw== X-Forwarded-Encrypted: i=1; AHgh+Rr0FOjnvnXvvUOGgJI3Ogeb0j1B6GJ/BnKrhtq8B6p7YurzPakN2NiJGg6ILYiLY3G2UWUbkFjSQal4Vx0=@vger.kernel.org X-Gm-Message-State: AOJu0YyykbKwkF6X9ptk7X3DiAiw8sWEgC+XM3ECtxuSjS+PUkCOSqZS lEoD0ulkXh4L5sc6SMpxFfsCzm7ImluUKZRjn1LWAeNL0UGHTk1ZKFBvpQK5caeVLDk= X-Gm-Gg: AR+sD10WF66ikbeMLgthm6vLFr0M7blAmSW3Tzw/7bqpm/KKKpKyrp2i3MfN2dYr9bA wsczY3dXywHpjaYn5FZ4N+lrUPT2r/U8fk2EEaMbbUH/nRhx3kOpH/ZvbgeZnMN4ZDVAiaUJ1Ad LEWIdgcCAWUFNt5w8+t2y85/e5MIaejllCWUAriaGXYjr+EN3kMdMGsEDHUtvXnz62bnK3bjhp4 tWhN061akLXea4j1YZVRsferYjjb0lfpiqSRfd79b9Ra+ueso6mIi/k0nUCYZ72zjZucpbSX0yC U69JiF8iZgQcAgxcCX3/Ct9z00bTtE4+47v8+8WrtXO01h03W1rmC5y39Ok+fOqbgoy0B1mDSx+ D0dJRJzTzHXc6i32no6f656cSl5rJb7T4l3DuhGxrQP5roHHzcmevrhaNVBD9Md4jERO41iF/QC htbG5TKjmrdBRrDphslwvqwRR2rjBKBFfpmSYnFScfslpzCC1pbZrXkEsS8hvrExFgJ3vOXyak2 lDX3UgX5Q== X-Received: by 2002:a5d:45c8:0:b0:481:4dcd:aefa with SMTP id ffacd0b85a97d-48159ca6290mr4320423f8f.6.1786609498024; Thu, 13 Aug 2026 01:24:58 -0700 (PDT) Received: from localhost (109-81-29-60.rct.o2.cz. [109.81.29.60]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815a5af19fsm4502301f8f.24.2026.08.13.01.24.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 01:24:57 -0700 (PDT) Date: Thu, 13 Aug 2026 10:24:56 +0200 From: Michal Hocko To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Roman Gushchin , Muchun Song , David Hildenbrand , Lorenzo Stoakes , Kairui Song , Qi Zheng , Barry Song , Axel Rasmussen , Meta kernel team , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/9] memcg: remove mem_cgroup_shrink_node() Message-ID: References: <20260811203203.3456029-1-shakeel.butt@linux.dev> <20260811203203.3456029-4-shakeel.butt@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260811203203.3456029-4-shakeel.butt@linux.dev> On Tue 11-08-26 13:31:57, Shakeel Butt wrote: > Its only caller was soft limit reclaim, which is gone. > > Signed-off-by: Shakeel Butt Acked-by: Michal Hocko Thanks! > --- > mm/internal.h | 4 ---- > mm/vmscan.c | 41 ----------------------------------------- > 2 files changed, 45 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index 678ce8d03515..b2315bdb7350 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -85,10 +85,6 @@ unsigned long try_to_free_mem_cgroup_pages(struct mem_cgroup *memcg, > gfp_t gfp_mask, > unsigned int reclaim_options, > int *swappiness); > -unsigned long mem_cgroup_shrink_node(struct mem_cgroup *memcg, > - gfp_t gfp_mask, bool noswap, > - pg_data_t *pgdat, > - unsigned long *nr_scanned); > > #ifdef CONFIG_NUMA > extern int sysctl_min_unmapped_ratio; > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 032b14793d91..790b50c78a2e 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -6795,47 +6795,6 @@ unsigned long try_to_free_pages(struct zonelist *zonelist, int order, > > #ifdef CONFIG_MEMCG > > -/* Only used by soft limit reclaim. Do not reuse for anything else. */ > -unsigned long mem_cgroup_shrink_node(struct mem_cgroup *memcg, > - gfp_t gfp_mask, bool noswap, > - pg_data_t *pgdat, > - unsigned long *nr_scanned) > -{ > - struct lruvec *lruvec = mem_cgroup_lruvec(memcg, pgdat); > - struct scan_control sc = { > - .nr_to_reclaim = SWAP_CLUSTER_MAX, > - .target_mem_cgroup = memcg, > - .may_writepage = 1, > - .may_unmap = 1, > - .reclaim_idx = MAX_NR_ZONES - 1, > - .may_swap = !noswap, > - }; > - > - WARN_ON_ONCE(!current->reclaim_state); > - > - sc.gfp_mask = (gfp_mask & GFP_RECLAIM_MASK) | > - (GFP_HIGHUSER_MOVABLE & ~GFP_RECLAIM_MASK); > - > - trace_mm_vmscan_memcg_softlimit_reclaim_begin(sc.gfp_mask, > - sc.order, > - memcg); > - > - /* > - * NOTE: Although we can get the priority field, using it > - * here is not a good idea, since it limits the pages we can scan. > - * if we don't reclaim here, the shrink_node from balance_pgdat > - * will pick up pages from other mem cgroup's as well. We hack > - * the priority and make it zero. > - */ > - shrink_lruvec(lruvec, &sc); > - > - trace_mm_vmscan_memcg_softlimit_reclaim_end(sc.nr_reclaimed, memcg); > - > - *nr_scanned = sc.nr_scanned; > - > - return sc.nr_reclaimed; > -} > - > unsigned long try_to_free_mem_cgroup_pages(struct mem_cgroup *memcg, > unsigned long nr_pages, > gfp_t gfp_mask, > -- > 2.53.0-Meta -- Michal Hocko SUSE Labs