From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FE0F340283 for ; Thu, 13 Aug 2026 07:08:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786604897; cv=none; b=p1KtvSoEwKU7j6L+Ob5lISkjb08FmMFsLYbciFZNO605LLK/RfDfSs8914elDg/W0tY9NUST5BkdhxpnDBDpxeskt/ZxtdX4FUMS3Xe022kcVrUn2+DOjaGPZn1+l3cW/XtvNTIDP+kZsWXui1loALkpG60tK6wmgQb5j8//h8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786604897; c=relaxed/simple; bh=bh4B7O/nniVK1wq8M9cB8RIRsbzfRKwBou+ARWbIlmA=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=XXq+GtSxpJxiFXINBmMpm8on99+S0cpZgRu46AyxomJJtuCO9qe4XkwF0dOP7oGnAtz52Ry6R/ExnmV50icPhy/6L9f6xcwWOK4Oo1y7Z6hwtUqrwllASG25PYXFoSTh/tWdfVvvYUB4HjmG/9dgsldQUtsBIQAQP3/N49OXRyU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=djmJiA+H; arc=none smtp.client-ip=209.85.160.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="djmJiA+H" Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-52d37b65926so9874771cf.2 for ; Thu, 13 Aug 2026 00:08:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786604895; x=1787209695; darn=vger.kernel.org; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SSbJwX3mVENBYQLVT50jOp9wDyIPziduBiZzfCOk5ZY=; b=djmJiA+Hg3zzM7IFZxSXdt3GnZXkQVK5TMETfh8TUPU7vY4f8r7jUBt6naH9f0GD7h 6YncLIglUdw7M3M0lP2UZbHnD3zlcA3ER73zclB5Xu1TgQd/bfMWW0r+wtXSrwNSrm6a xmAWddILUPYUgKRE0i/oDpbBeZ5D/z0bYm4j1bqBK6+igodzDV8aU0xG0NT+hYkZ2q7e zNtbDwoMFj6+JW74aEZCKNNeK2onDTGc+XY3LuicspSJbE2ka563yqtkhUPIF+A9WedS aSglBNV+hXMfCUixZ9K+u2XnpF2MFDgymRCzLzZcl/vo7pb/OnSafsNj4OoTOuyroRXs DSHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786604895; x=1787209695; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SSbJwX3mVENBYQLVT50jOp9wDyIPziduBiZzfCOk5ZY=; b=FobHxL4YJwqRFgKU1dqTG4SZxlEceBqQQXcTdm9BlLfj8NxGmaIokJxXWm2Gvwd5BO DUlRQ4H/wH0MImjarH0V5DOB/GbNuaAL9kcovgd3XAyOoJJhR0tph4bn+m850QgKCY/s rJpdOGn9GBbXl93ycRKoRGpGTsO2QFnfvRaClaHitOFQef+2FP3V7kllpZ42TMHGN/tC JmnFO3GpV/ydUJhGyLGlEvkNXWoZ6PYnKE2XS1s09ZgJWGQykotqgvg8BmxvhfQZt272 mj8+IKV7a9Q4KU6cCTbg0Tq/n1bv4YLz98nS3NAe6iYW7KJ8ugbmz1JHcjki9udwlZ+h DZzA== X-Forwarded-Encrypted: i=1; AHgh+RpcCEZCP/AAMGCqVdcmxLBcEGO0mV0YLAnlSKW2zuqLM0zaBfs2ky8PGLmB97QIPegJnSW+i8vsh4ZdN2o=@vger.kernel.org X-Gm-Message-State: AOJu0YzbjKH1qqYKWQ7pLF8hI8r27DxzzKoKQQpiNbBxP4i2O5aEmevi gNkWmJFCbD85mBhdjy/YFvRtCMnzg1wYJb8j6AvuADbSLloUfZLr9c81 X-Gm-Gg: AR+sD11kCxlnX3yrOihPNGxSp+MHlZpnD50EtbhNsfYLAvDlpkqoI42HceE2NvDKx6S AR1m4LJcWjSI6QFCVhJEq6y88o84nTcJXaVabfDoYe7l0WOZffVv496mvTQtDu/sxH/i3by7eHQ aMh9Le8F6NB8fTcftvBqCtJTAIvZziihY7HZPd9Y+felkov3fWGZ+GmwHjFJPIBSGH5k68PBtn5 b7oyPJIIAsIkLa71qEYLAxh//huiXPTB6q9pGYX8juhlnXzorhpO5GrF3PYrWulS6kgOFy//aXu 2+63HwM3pd24Y645v4Zw13ULo+JZhUWIYFF2dGdHNFYOCyC4X0HXre6+qcXcG392nJRAeW85YQ+ YYz5fi7yePBLlK8rgcVEJGoEMjawPAlhTA0orjjPnGTktuanTUkb8G9/X1iB/U730rrTtZiRVNN +wXcFa4F/MFZQtEFv/D6wksK42rH/9O10aDYsAVPTevGJAZa+BF46EUs2IcE3Jw3A= X-Received: by 2002:ac8:7d0f:0:b0:519:8b76:2ce0 with SMTP id d75a77b69052e-52d73e0144cmr31264241cf.37.1786604894953; Thu, 13 Aug 2026 00:08:14 -0700 (PDT) Received: from localhost ([37.19.206.57]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52d73dfaf51sm11432531cf.6.2026.08.13.00.08.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 00:08:14 -0700 (PDT) Date: Thu, 13 Aug 2026 10:08:09 +0300 From: Dan Carpenter To: Dave Airlie Cc: David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Simona Vetter , "Michael S. Tsirkin" , dri-devel@lists.freedesktop.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] drm/virtio: Fix a NULL vs ERR_PTR() bug in virtio_gpu_user_framebuffer_create() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding Smatch complains that returning a NULL here will lead to a NULL pointer dereference in drm_mode_addfb2(). Return an error pointer instead. Fixes: dc5698e80cf7 ("Add virtio gpu driver.") Signed-off-by: Dan Carpenter --- This code is obviously over a decade old. I think this patch is correct. None of the other implementations return NULL, but I haven't tested it. --- drivers/gpu/drm/virtio/virtgpu_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c index 44ffffec550f..85ea252c658e 100644 --- a/drivers/gpu/drm/virtio/virtgpu_display.c +++ b/drivers/gpu/drm/virtio/virtgpu_display.c @@ -344,7 +344,7 @@ virtio_gpu_user_framebuffer_create(struct drm_device *dev, if (ret) { kfree(virtio_gpu_fb); drm_gem_object_put(obj); - return NULL; + return ERR_PTR(ret); } return &virtio_gpu_fb->base; -- 2.53.0