From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9162361969 for ; Thu, 13 Aug 2026 07:09:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786604970; cv=none; b=XNq07U2MHpp8FpCggStFHmM+AX0tgiPNMJJlgi0WOGQG86W9g/9+Fgw05VydcOJ9r64omY8xAGrQSM2g7QjqtdfADP8V6dqCEvWoIKYX7o+cjobyylOFRZ56hccHZF25XAniRXfVj3/ybrEVoqnBKlMfS4lJQEjDE5YCs/+yoGM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786604970; c=relaxed/simple; bh=g4Oc/MET58u7bnkBeWdGiQn7AbTG1XWXh7hiIo63e1M=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=XOkpkzJeMb7BVg4I2jk3gq+Iji/vLtebaaOlTI0q4fkOaz0zl4kOTL+WydMkcEdIJluGtoC0FD1/EfuTDAmqGbpS9nYoQTn/QZfTk635LGPw5ek6k+1+FKcSjsW5DS6rkl5Zk8oVzI20KtX7iFQVAXOZD+6K3/vOHVGxPjUE3dY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qtKlC/ID; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qtKlC/ID" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-92e512a9a6bso79427685a.2 for ; Thu, 13 Aug 2026 00:09:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786604967; x=1787209767; darn=vger.kernel.org; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=NZroItyF8XgwHC+4+NtzUTIlcTQFjRyMSooUeMz2hX0=; b=qtKlC/IDW2Vm0X6SNutWuWLKBLqoDtbOmdepgsFpHOCQ7HqfAXQHn5EjJl01JGnEYp voQaMq7wgGzP09y9qM9IpiWFkjei+hjU6a6PRGkmivA61JMsS9SOKBli1ueIDxPEbUNz oZIk2AmlTTRtVDUt/MamSLrjNb/IOtXQ41WPbfWGQ/0wxF9IeiJN5M6aiD+uh63rzRiq KbEN4jIPbVsjUEzc7bX23+KJlwiSZh6zcOT62Naz/q1aaCETO118mRpim7Z9W/cwTefp Gyo2CVGioVQ4GkmHhHgQZlNVAoK6EoBvmN1QZAPsGgVHLcrZDh4XMXfZv6zuOeoawL/U eVLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786604967; x=1787209767; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NZroItyF8XgwHC+4+NtzUTIlcTQFjRyMSooUeMz2hX0=; b=X0JOl1Jyi0x5h548c7Ff6fIcMZDXUJ73t3EcDh4R5vcHQeeJxJPEqmV0uvODHz0xKE V1KdrP147wPJ2a0ptVocipNgO6i7wRUfm4+hoj8s2dAjGypc9oRnwaGmQ7UH6TO0xQG9 oU+FT2nAdswXVGkBdiF9xWM0Rr8Z+4r58MRqQLiG7qmVsqOA226m825Q5gYpbPWSusaZ dJdPGelZfPLntMn9MoOnV5LcyYd2NqA+gpFHaOtIA6f1a8g4NaNe+QA5slm6tDERl/RJ Oi+7ucgCPlp7oIatRVVN+Wal0nzq8KIps6vtaQLsrrZ8VvBrEjZiSr1P5scx76IPQHTZ UIyA== X-Forwarded-Encrypted: i=1; AHgh+RrIzI+WgQ0hI8yQaH3n8CTeqhH0tke22yNOvicFo5jNIAH9XnhlxnXrOosa2Ntkg8Bl3D/Sct6Pv+Uw/oA=@vger.kernel.org X-Gm-Message-State: AOJu0Yzqr5JKSHZPSDLxhSJD3WZ+JWgRIZ7rc8DZaRtv96BGIimZgyYf WMDcilTzoLWRMFXnhZLIaScS4WmjoXpVAetwV18riOrXEyFiqR2SCJJ+ X-Gm-Gg: AR+sD10jWeqziMieacSj5auGGeWzlitVZGchw+4H+nye1Dh8JEcECTk2+kogvQYR3cI 9p0Fa19w9o2bdFOOBmOAMS8Z93+y4okq5Yme5IOtIvAmFnndnXmC96ESJ5tqpBnp0Gu0aFOHthS lSqSkr90f9FLVjlNWD9/JuXYwpk5EWzCI3o+nsnFmai/wJDuSCthYl/olQL/hhWVqm6BDoGAAev Oc16PxvSMhiHgK7JTrzV1gxIt68+tcr+cysmzIuY1JUjuTA/HAExEL/L/KsJPqHuXMio1G+j0tA jxDGiaHYHD9rVqD6bqIhOKFG656ndDhl3WAN/4/vBnWwtynWjI08eXupbVaSZHdy4Q6+g4SB4rb cBLq+qctIrEHB6sP5ub68pDj/7FObLFLfKGD1jmbhsxipC3PtaduOJ639jVdG994WgZfO8SbK3Y v4GM1HdRd+38K3QHS6d7W1sjy0rlCif8BIwGkJE5Zxsz6R9LfPhsq+ X-Received: by 2002:ad4:4ee8:0:b0:907:bf98:c8fe with SMTP id 6a1803df08f44-90a80c5013fmr27517096d6.23.1786604966749; Thu, 13 Aug 2026 00:09:26 -0700 (PDT) Received: from localhost ([37.19.206.57]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90a817bb1a6sm9190316d6.12.2026.08.13.00.09.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 00:09:26 -0700 (PDT) Date: Thu, 13 Aug 2026 10:09:21 +0300 From: Dan Carpenter To: Konrad Dybcio Cc: Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] soc: qcom: smem: Fix signedness bug in smem_dram_parse() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding The "ver" variable is type "enum ddr_info_version". Enum types are dependent on the compiler but in practical terms here, "ver" is basically an unsigned int. It needs to be signed for the -EINVAL to be handled correctly. Fixes: 1d234eeafc56 ("soc: qcom: smem: Expose DDR data from SMEM") Signed-off-by: Dan Carpenter --- drivers/soc/qcom/smem_dramc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/qcom/smem_dramc.c b/drivers/soc/qcom/smem_dramc.c index 63ebe7f6db59..6283e9317f19 100644 --- a/drivers/soc/qcom/smem_dramc.c +++ b/drivers/soc/qcom/smem_dramc.c @@ -382,7 +382,7 @@ struct dentry *smem_dram_parse(struct qcom_smem *smem, struct device *dev) return ERR_PTR(-ENODATA); ver = smem_dram_infer_struct_version(actual_size); - if (ver < 0) { + if ((int)ver < 0) { /* Some SoCs don't provide data that's useful for us */ return ERR_PTR(-ENODATA); } else if (ver == INFO_UNKNOWN) { -- 2.53.0