From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAF4F36402E for ; Thu, 13 Aug 2026 07:09:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786604980; cv=none; b=olwlQOOvxtn3QoEP95PTyCvGBy356xOSKCwUf04Tc036h1UImL7kRKAiiDt9YOGtsfo1BtN4oOi5C9GcA2sjR0OxTK7Zkm/It5zdY1zh2dh0CAdlh6XyAsyXD+RTdty3P6Z0jnv29Kazb+9xoY3gCrcB70f8CU6nnAL613ETQiA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786604980; c=relaxed/simple; bh=ajlICF5UKF3zQ8HymZznpcIpyBV/7FAyjz382zjD7S8=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=lfk9e72ZRL7Z9ihdCDgRtjkisSigXDJUob0d60DzbBpzk0f9BI0BwmQcnXxP9KLis07jBamjiYj2EwlbloWoinpjNKZHs5BtE4NIcPZpuIu9HVvA74hSmWz1H1FSwDfCZQik+uI4mLkW1IU9RWY/WqTR4xJI1R3xYSyN+5XIWJ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=r38yequ6; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r38yequ6" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-92e6c4a867cso115782285a.0 for ; Thu, 13 Aug 2026 00:09:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786604978; x=1787209778; darn=vger.kernel.org; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gw73m5PwUErvfwwmzv0TlDv6S2DhMcVdC6Gz7QT0ok4=; b=r38yequ6LKTbxDuYyvJMJQcfHgIpNwqcqvjtmDtFiJQLDPH2RhhIaMTM8LTvZKOVB8 ol9M6xDuVkwv+RX4Mjg/CR/uRIePjvZTUfP8gJmX6vPHCbTnoUMIVPZjNoL9GRCZ1Cgq tPbAsQsLKmgZX/lYIfYKgjpwrBlNz+FT9pvn9QRnsknFeqQRiYSVofkOnYngIBF7/d8P idP6IgV6dwaRZ8BGYeVcghbZLh4S/1UXJTJ9NuPNj+sb49HAB+LSG9ZsfbntPK7t1L5p F/bVBXB+zt8FSLIDIzO35w5yQYtyVJWz2dyTwHPwuPH60ZlEBa9tpL0tPhmcfvOfdRlq 7rgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786604978; x=1787209778; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gw73m5PwUErvfwwmzv0TlDv6S2DhMcVdC6Gz7QT0ok4=; b=aa7m7+RZrpBnMRe/wyuRp2Z558PiV67Wjqwnpa79ZcidNXxwDTK25/u4zRp+/vjjo0 ymRxPN9WHTjq2uSRsX4HjSIhL/ce09aV4VrQJ2rHNRz+x/bXeJDgAtlfUNL0iEyMlymi Hj5YXOJnFgxzgxnZnUaDXS5hdNZ+VPHMQKUKRkXetNy+2GxBPS+fISB6ETprbGgym5dG zNckjtGeVxO9urGk7L72PjoQOxxXYjfE1wFgbA/Qil1mgvzErUZQLmmBsUfYWUreGKEx pnAZkd+X31OLuCane0TPwfzecHpv0h0JdE45q6KXNjWnMGTkKlqKtna5Tafjtw3+gzn5 BaGQ== X-Forwarded-Encrypted: i=1; AHgh+RrPEF4Bxg22lJ8TzRFZL7qaIb+h6KPvXeTgW7/Cx0jKa5a/c/NE64LUDXJKo0/84QWjr8Fw7GIJ/c67x3k=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+dYxNqWCboC0cqGRCJkwLYhGcpXFFZRAZeY7fX8c0OaAHKa5v ipJZU3iwVX9p6k8+bYvg/3ctFsWbwvM9gw4owjOXkS5rtA/roH3lc57Q X-Gm-Gg: AR+sD10n0M8MKjkd9KC3kcem3hU8EtZt+wVHi/3fzaBdM6iqJ1pMQCSSIPnowtcla60 d2+d3jS4E9hx2qDvFJT5uJF2LDSjXSdszYFwOL5heJJ6HJiQBCjdN45pvfYr8ZezsUn/sPtmXxX qIery8mhQqwl497XGtHOqAEiuZSL1D5wy3oqwpNBzR+Ev+DljsDgY8FKfoZEHaX5uGm25VHAbjd WzSjBErWWx8TNIknh7ttJjYDPZ8FYVnCNtGjXliQqoQJWO5lHOoRa8719U9eR14FRcW1yzmy+Rc VJvIQd7/7jPmbbSDy6UmmH0zK43zMFOD+XVKHtMnrN2G98QuGhcBORHcgv4Qcw1eQvL+oX+gsdT LkUPIfKW5xoiyUQNaSSDgH0YzPjerBXQwHnpg9hH6WJHvMzYRovLo1f8NwLBzKVs8cG7QjBKvo9 7L8VFwwjJtshYRgXiDWCTjJUPkNzESWfVvjoDoolNP+jI9azlh6r3m X-Received: by 2002:a05:620a:2804:b0:92e:76a1:96d3 with SMTP id af79cd13be357-936bfb36a6cmr330873485a.34.1786604977813; Thu, 13 Aug 2026 00:09:37 -0700 (PDT) Received: from localhost ([37.19.206.57]) by smtp.gmail.com with ESMTPSA id af79cd13be357-936c1b4d57asm86530885a.35.2026.08.13.00.09.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 00:09:37 -0700 (PDT) Date: Thu, 13 Aug 2026 10:09:32 +0300 From: Dan Carpenter To: Justin Tee Cc: Paul Ely , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] scsi: lpfc: remove unnnecessary NULL check Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding The "evt_dat" variale is non-NULL at this point so there is no need to check. Delete the check and pull the code in a tab. Signed-off-by: Dan Carpenter --- drivers/scsi/lpfc/lpfc_bsg.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c index c95165905483..7354ae9ba8e5 100644 --- a/drivers/scsi/lpfc/lpfc_bsg.c +++ b/drivers/scsi/lpfc/lpfc_bsg.c @@ -1329,10 +1329,8 @@ lpfc_bsg_hba_get_event(struct bsg_job *job) else bsg_reply->reply_payload_rcv_len = 0; - if (evt_dat) { - kfree(evt_dat->data); - kfree(evt_dat); - } + kfree(evt_dat->data); + kfree(evt_dat); spin_lock_irqsave(&phba->ct_ev_lock, flags); lpfc_bsg_event_unref(evt); -- 2.53.0