From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64932420463 for ; Thu, 13 Aug 2026 14:48:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786632517; cv=none; b=rXMRlTulslnUNpTif3QN9VTX8dK5PAuZXG0JoZyibtk3ShdL6KdUSQ8bo2fJBDFUgclGb5etsYhHDhm/PEL0QdhZUjiJXe802uNr5X8ZWQSqSg6xKulDU1aKkEtXSpygcC4KeRq29jANn+drVzuitedu5HKq4cOkDihTuy9s9hE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786632517; c=relaxed/simple; bh=fPVZ1ihw05vS5fOYEENuHWqa5iPU8L2MRPmEcSIB9pY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TVgPkoL9RF8zlT4yn7yoRDCuo1PFgl8mNfw1tiIfERCNq9WnrofdJzzaxAeAvcAaU/X5AEhtV6QjzYL7JtjTztiEAw6gp8UwNYsJaVLEmj75Yqc6B37aFrfhU/3cYspnfzSLRAwlA2j4lFHC0YDZC02FHoQafyaR1GyMfABCqUQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VnhDxUpA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=krdFwZ1Z; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VnhDxUpA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="krdFwZ1Z" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67DDvnYJ2971097 for ; Thu, 13 Aug 2026 14:48:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=uRZcIZWzwhsQClQoWCRDPoqO ksp7QGY7YMrfX9l8rqM=; b=VnhDxUpAYj2LZJPIekIvknYaa1JNyZjhQy+ojpxH yBnTIjMnLs/XnUgUeT7A+5MiXVdTcWQerfUzU+spDZuw4SvZO/Gd3oKCGkPuDIUN Qw1qdHn467m/fXuzEMF+X2tGGo/rxsy+h4pi4xElCATBw8pieNc04e1llY9+Ff0z +x5s4BOS95OjvF/zkD5x/OX1YMAoaIVrGEjajoHX+13Ms9wGmwaIs7korH1TeHuQ JISnjjBWn89UqlAYYQN4NerCTNO5nUhc/yRmwPYStfGVRcgaRuSVo8oa6VWv0FPK bD95PHSYzGdUdlQRs++N/VSGhcEkkdQGuswCEe4J6uLvQA== Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g1f94g7qn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 13 Aug 2026 14:48:35 +0000 (GMT) Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-7e9dee2f7b5so49132a34.1 for ; Thu, 13 Aug 2026 07:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786632514; x=1787237314; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=uRZcIZWzwhsQClQoWCRDPoqOksp7QGY7YMrfX9l8rqM=; b=krdFwZ1ZC+hsfGdvyieKj8Wb2cn/znKoNDJkqdzEtnFx++98qeSPv+lFcP79N9hR8X pRUffY2KgycJAeWU/wG0+VbIDTwWN8XbGTbQoSj+5Skc4o1wKXWQ8jOXqHTqGRRnruQQ dHj0kOgF7raUaoGPl9uxUAACaFG0BwiqeGajmxdYmuYH0/5pTC62xGYgL7Bbqb+IUE+S EExuh9O7BEK7rYu8LXhG8OSPQ7MlltAwL9n6MH1oCFaWuoo9AjpV0tUwA/PlinR/N0mx CTpGL8dK8E4XFHb3gf9am9WbArVP9s3Ctrlg6rHcY/tKLT0CZ/kIsD1pV4u9bItNdmQZ LIRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786632514; x=1787237314; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=uRZcIZWzwhsQClQoWCRDPoqOksp7QGY7YMrfX9l8rqM=; b=Ra9Z4bYZ4vV87/zl8GZXW/EuuqSSZOAQJvAAyr88zEEF8Ggjhk8U4eWn5n/F1S+66C 2/jxUhZP3Keo/d5Jt49k2/fqKcz3gDXTXuTp3TyCnEHOLtV89lz/MhNvP0KO+JgUqy/9 UfSSOiL5YxT4pWSSOQ4OXjH82RVqlJG/Du1aoP3wMGdri9NriTmYDD62ST+MXd054ANL Pu8ULo93PIsUf/oGeZm7qO71w0twSlgoBBdlFEgpEEwjrxuha2QEf14L2xy5hJciYFWT FZo+OnGbBlsURIi7XyxgyGmPefCAmEcMExOEdf8IOOvmHDLaCZcxYWJpj7GEqfsc701C XJAg== X-Forwarded-Encrypted: i=1; AHgh+RrMxJFpp07ZdNJ5sAEPIdVYkPwIV8Esah12v/6Zc54mRXwzzdzCVBFFFZEx55pZ49YhmgOab0NrzDOz5GY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw221rBrPUwyeJL57KJifW45wX+sfPMOifz05e+KZNkOcszIJOd l3wJqJqnbNepavFkR4Cu+HWZ4o5OXMdDQYrdhGMycVZll6UUZTKuc22JDIiOyByDcXBo/MUvnb8 x7+fRYhMulohsnCmfS5zeO3WtTJfh+stIIlYZXHzCiX94EW2e6BqlNv1HbRZKttZjN3k= X-Gm-Gg: AR+sD10+nmhkY3nJnrwXvGNIvRfH+l9DcqfYfzQvrUaeDXs3aL2KAzvWWdnxLatHq+J /cE0djo6gJ6mtU3e9IqHTNu0oWDyf+eRXcBHXdW0vJw18A7QKuS+qU0Q6BM2MHWTaN34Mt/+mGO 9piHn/hKMxffMdsBA+1vmZIHROpw+4fWRIZZpSSZ3ISNMsF5BnblVlRFQtobWOHayYzbjEj6eCM XwG2fdb8Ame+WfTOzCPGL+iG5nWpfBjUYM18A2D1/R1rj88X9tHf6cTczOdeFbgCRhZ5FVNdtfZ u0BwuN6ycZzo4dFupZttf3pmVv9B7AVjIlufED7KgvRGegqF7tc/IozVGW6iLRODeNu7nRrU11T 56cdKBu4n6TghW5HwwAYmIz4mMRUFXNdd X-Received: by 2002:a05:6830:2992:b0:7eb:d848:c867 with SMTP id 46e09a7af769-7f3ca6c6723mr6288339a34.6.1786632514503; Thu, 13 Aug 2026 07:48:34 -0700 (PDT) X-Received: by 2002:a05:6830:2992:b0:7eb:d848:c867 with SMTP id 46e09a7af769-7f3ca6c6723mr6288294a34.6.1786632514014; Thu, 13 Aug 2026 07:48:34 -0700 (PDT) Received: from hu-anantiwa-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7f3c9ca7bf1sm2271803a34.13.2026.08.13.07.48.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 07:48:33 -0700 (PDT) Date: Thu, 13 Aug 2026 20:18:27 +0530 From: Anand Tiwari To: Bjorn Andersson Cc: Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, venkata.valluru@oss.qualcomm.com, vishnu.saini@oss.qualcomm.com, Jessica Zhang Subject: Re: [PATCH 1/2] arm64: dts: qcom: hamoa-iot-evk: Add eDP display overlay Message-ID: References: <20260806-edp_overlay_for-next-v1-0-c3aebbc81f38@oss.qualcomm.com> <20260806-edp_overlay_for-next-v1-1-c3aebbc81f38@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-Spam-Info: AW1haW4tMjYwODEzMDEwNiBTYWx0ZWRfX352hBuABh/ZO +w6COkN46CAy5wRNgNbK9DU13HI6bXnx2HB3RPqQMwJVBBbO9MafLCiMaoemDCi2tE6ng/6d+9k 7ttcN/PQVYA9sDUT+GmmtYS1c+HgqsQ= X-Authority-Analysis: v=2.4 cv=VYDH+lp9 c=1 sm=1 tr=0 ts=6a7dd943 cx=c_pps a=z9lCQkyTxNhZyzAvolXo/A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=JxsENykyxGhnw_pnO58A:9 a=CjuIK1q_8ugA:10 a=EyFUmsFV_t8cxB2kMr4A:22 X-Proofpoint-GUID: Ur_k0BM5mOymTS9P6CWDxd_Q4vF9h9aU X-Proofpoint-ORIG-GUID: Ur_k0BM5mOymTS9P6CWDxd_Q4vF9h9aU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEzMDEwNiBTYWx0ZWRfX4lTxgeiH1HLp T+k9mKO+Dukoh/hApafBFdXFoYc5qB9cquru1bSUQ1YCy0UKOnG7ZBZGzpWlROzTHoUxLk1DJme AscHXwcs+ahXKt10ftoigLSboc7Rd2IYXMGSLJCAo/Vfe3xIHD2ZQA57g4zfHJqvgIsa1RmO3nC ZfyXKHo+bV2P/+JLSvWXm/e0+Ch4NmJCJl1hkVxmmShe79v3JLINNI46wN7sSJX3dkR/HHwWaLn ZUaeGvjyJiEdAF1onKwX+LW2y/bKR0KK4Hruw6wIRz5rUZ1o/kR9OKilaFOS7CryOcNMEgo8c3d lEwrKwjr3mqySiLgg9IJknIsTOctiCx33xtB6s8dDMX84tnugSPkMHm2VWPMLmX6a5Djm70ieT5 9A7bQTwUFz2hcPGhT9wVianrdyeab645SrG2RxKnb6fB0Ipvv/wtBVYuPetL09KE3NXGvJ2fhDu aD9VkpabbBwJTMgRTAQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-13_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 phishscore=0 clxscore=1015 suspectscore=0 spamscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608130106 On Mon, Aug 10, 2026 at 08:11:12AM -0500, Bjorn Andersson wrote: > On Mon, Aug 10, 2026 at 01:52:42PM +0530, Anand Tiwari wrote: > > On Fri, Aug 07, 2026 at 04:01:05PM -0500, Bjorn Andersson wrote: > > > On Fri, Aug 07, 2026 at 03:30:13PM +0530, Anand Tiwari wrote: > > > > On Thu, Aug 06, 2026 at 07:05:37PM -0500, Bjorn Andersson wrote: > > > > > On Thu, Aug 06, 2026 at 10:01:20PM +0530, Anand Tiwari wrote: > > > > > > Move the eDP panel configuration and related power, backlight, and pinctrl > > > > > > nodes into a separate overlay. Keep the base DTB suitable for headless > > > > > > variants and provide a composite DTB for headed variants. > > > > > > > > > > To quote: > > > > > https://docs.kernel.org/process/submitting-patches.html#describe-your-changes > > > > > > > > > > """ > > > > > Describe your problem. Whether your patch is a one-line bug fix or 5000 > > > > > lines of a new feature, there must be an underlying problem that > > > > > motivated you to do this work. Convince the reviewer that there is a > > > > > problem worth fixing and that it makes sense for them to read past the > > > > > first paragraph. > > > > > """ > > > > > > > > > > In fact, I'm not even able to guess what the problem you're fixing here. > > > > > > > > > > Regards, > > > > > Bjorn > > > > > > > > > > > > > The problem is that the base device trees currently describe the eDP > > > > display hardware unconditionally. However, Hamoa and Purwa IoT EVKs > > > > are also available in headless variants without an eDP panel. > > > > > > > > With current base DTBs, headless variants are not stable where eDP panel is not > > > > physically connected with board and userspace is trying to use it. > > If this is the configuration that is shipping, then it better be > stable... > Agreed. > > > > > > > > This series fixes the inaccurate hardware description by keeping the > > > > base DTBs limited to hardware common to both variants and moving the > > > > eDP-specific nodes into separate overlays. The base DTB can therefore > > > > be used for headless variants, while the overlay is selected for > > > > headed variants. > > > > > > > > > > I see, then it seems your change does make sense. I don't understand why > > > you didn't explained this in the commit message though. > > > > > > > I will update the commit msg with details, currently details added only in > > series cover letter. > > > > > > > > I further do not understand how it can be that nobody noticed that the > > > display was missing on their Hamoa EVK during the 11 months since I > > > merged the offending patch - this is completely unacceptable. > > > > > > Regards, > > > Bjorn > > > > > > > Internally, we have always required the eDP panel to be connected during > > testing. In theory, this platform is expected to have a display attached > > by default. > > 1. The only difference is that the eDP connector on this board is externally > > accessible and can be disconnected quite easily. > > 2. Also, only the boards shipped to customers are delivered without an eDP > > panel attached by default, which is why this requirement exists. > > In particular since you're shipping it without display, that is the > configuration that should be the dts (and that you should test...). > > Common additional configurations can then be added as overlays - while > the developer can add their own overlays as needed. > > Regards, > Bjorn Agreed. The headless configuration is now the base DTS, with the eDP nodes moved to an optional overlay. Testing is complete for both headless and headed configurations.