From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C95A7439F79 for ; Thu, 13 Aug 2026 21:36:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786656974; cv=none; b=sUmmL0JjHxZf4bsNBgrGnXPVEeskkq6FtyJRfzsbbjcl3W8jPEex1UGNm5B31CSdfy7eOe7bvEzYrkhXtKdaTp+VMQV4zJONfpL1HQvM1Aje0/pXye4Q+MroTyPl8L4SMczO7z3rKdzHxviw6omIk4mgaTFh0hTxrrSVz61UtcQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786656974; c=relaxed/simple; bh=UJCPf56mgmNAk+x52q6atBjk2FVyvpYPHIrbM8qIL+A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pplMDajXXeyEJpywxOIDTrogW4hvtr7oYqhKfMyASANGIAzjSx0BMUqqjcqdjnS/SgQEbvR91dQ8crg/xKImBXTeHoj7yP1MZPWdGAI8yzKbXuiDEyNk3lV66gBV8k21DWVRFRLw7UWUdHyK9CMj/rmYI7J1OqKjfVQnCn/g2Oo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jQIPZ+hm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jQIPZ+hm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B2021F00A3D; Thu, 13 Aug 2026 21:36:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786656971; bh=p9f51wPt4Me2mLXjwn+nYgzJniqhQG1acKdKdYdH70c=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=jQIPZ+hmvxFBuLhDkPmCx7P6LrbuvVKn0cNRFJyqBO7VX/oLiC/z2qcRg5/Bt3HQt hVr7b+kIPkk+gCp3zRhYB3Gh8j6r2eoWb1HzmZ8n8+ci9Ia1y5Jx8v9GKqDz73RRda +kylS6Yhpy+8BKm5wjqBK0vPIK1EPdyNx7BreUJOWH7O1Z5qHcsmrGhrC2SP5OtJml Q5NpngvJNJBucvm4oAEj8HbUMwuKSIhTL9xX5P7HhzIAy6PQX1N17+NEWEHAnK3cOL sS0sxXzciRywW6ywlE91DLCo38POwg9hKegIJ7umE8poNijCb+oiSv6cbbvzRK6fst cwI67C9wzeo+Q== Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfauth.phl.internal (Postfix) with ESMTP id 49114F40067; Thu, 13 Aug 2026 17:36:10 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Thu, 13 Aug 2026 17:36:10 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFFk3kTpZ2SFvlqu/9NZoiEZe5tJqWtrVRy19Y8SztAWXFfhy/49Dkn8QCnOPK2+5 AogX8kvYOK34JJ7nqRZYM515r4tYKFep0ch8rpdETStvosQB8Lv9DKOjDF+jWme2+C48aq tDZ5Cu8cR+nP44tCYWphM1ScDJWKjd/9+x1yBekjqAYWHTj5FP+RJyW4ZhW0zewY51QP/9 9qP8GHzYdzv1w1GSaw7C27ELYUcPcV2bijCnHcsNoASmdNrOEZsVJDEdzYZnYTIstP8xq2 x/Nq2kNPuLOnPtzX9LBBWo0uhHpJAcP0wulimVm/zVnIpJajaE7ZUCmC4kf7NmFI2VTAPQ rzZ1mihRcK8Nd2qPTzFLpyfWRFoVCav5asz5EX6+oaJfpNST8T9oTkb8wrLsYUnPYseE9G KvO2gqxHhNeFN87lPEYat54EgKGM7CN3A9D4Kt+yGsNQLPkFwtDpf8+OGscPLg8lkJyGxx 9+DpF18SkYOXvo51SMkSJ87TQ32AdrocX+DDJ/Zl1ueJKugpFfeOccwjwl59Da5BomlJtv Indi661HVGvok/39k56FfTpsEPQ+QFsKw86B7cgbR6Ar7c9yrsi6ofinymRVXd5Dls7N3F xeFtiM4MXiyOVQhzljuCYehZq49xf3Zr2N9SVJbYaSIVsSvr9N3WQOmJBvDA X-ME-Proxy: Feedback-ID: i8dbe485b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Aug 2026 17:36:09 -0400 (EDT) Date: Thu, 13 Aug 2026 14:36:08 -0700 From: Boqun Feng To: amd-gfx@lists.freedesktop.org Cc: Mark Janes , Kenneth Feng , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Lijo Lazar , Asad Kamal , Yang Wang , Priya Hosur , mythilam , Mario Limonciello , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/amd/pm: Fix incorrect avg vcn utilization in gpu_metrics Message-ID: References: <20260805140227.44868-1-boqun@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260805140227.44868-1-boqun@kernel.org> On Wed, Aug 05, 2026 at 07:02:21AM -0700, Boqun Feng wrote: > In a Strix Halo system, a >100 average_vcn_activity in gpu_metrics can > be observed by running the following command: > > ffmpeg -hwaccel vappi -vappi_device /dev/dri/renderD128 -i \ > ~/sample-10s.mp4 -vf hwupload,scale_vappi=format=nv12 -c:v \ > h264_vappi /tmp/output.mp4 > > This is incorrect because the value is supposed to be in [0-100] range. > > The cause of the issue is that the metrics.VcnActivity reported by > smu_cmn_get_metrics_table() is a permyriad value instead of a percentage > value (e.g. smu_v14_0_0_get_smu_metrics_data() has a division by 100 to > report the vcn_busy_percent). Therefore fix this by applying the same > division in smu_v14_0_0_get_gpu_metrics(). > > Reported-by: Mark Janes > Signed-off-by: Boqun Feng Ping? Regards, Boqun > --- > drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c > index 568665265a13..1058338344b0 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c > @@ -566,7 +566,8 @@ static ssize_t smu_v14_0_0_get_gpu_metrics(struct smu_context *smu, > gpu_metrics->temperature_skin = metrics.SkinTemp; > > gpu_metrics->average_gfx_activity = metrics.GfxActivity; > - gpu_metrics->average_vcn_activity = metrics.VcnActivity; > + /* metrics.VcnActivity is permyriad, convert it to percentage. */ > + gpu_metrics->average_vcn_activity = metrics.VcnActivity / 100; > memcpy(&gpu_metrics->average_ipu_activity[0], > &metrics.IpuBusy[0], > sizeof(uint16_t) * 8); > -- > 2.50.1 (Apple Git-155) >